Bug 2333657 - Review Request: rust-env_home - Get the user home directory in a cross-platform way
Summary: Review Request: rust-env_home - Get the user home directory in a cross-platfo...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/env_home
Whiteboard: Trivial
Depends On:
Blocks: 2344152
TreeView+ depends on / blocked
 
Reported: 2024-12-21 16:41 UTC by Ben Beasley
Modified: 2025-03-15 15:26 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-03-15 15:26:53 UTC
Type: Bug
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Ben Beasley 2024-12-21 16:41:03 UTC
Spec URL: https://music.fedorapeople.org/rust-env_home.spec
SRPM URL: https://music.fedorapeople.org/rust-env_home-0.1.0-1.fc41.src.rpm
Description: Get the user home directory in a cross-platform way.
Fedora Account System Username: music

This is a new dependency for rust-which-7.0.1. The spec file is exactly as generated by rust2rpm, without a configuration file.

Comment 1 Fedora Review Service 2024-12-21 16:44:00 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8434095
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2333657-rust-env_home/fedora-rawhide-x86_64/08434095-rust-env_home/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2025-03-14 16:28:58 UTC
Package was generated with rust2rpm, with no manual modifications, greatly simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 3 Ben Beasley 2025-03-15 12:50:33 UTC
Thank you for the review!

https://release-monitoring.org/project/376026/

Comment 4 Fedora Admin user for bugzilla script actions 2025-03-15 12:52:01 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-env_home

Comment 5 Fedora Update System 2025-03-15 15:22:27 UTC
FEDORA-2025-64da20d756 (rust-env_home-0.1.0-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-64da20d756

Comment 6 Fedora Update System 2025-03-15 15:26:53 UTC
FEDORA-2025-64da20d756 (rust-env_home-0.1.0-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.