This bug has been migrated to another issue tracking site. It has been closed here and may no longer be being monitored.

If you would like to get updates for this issue, or to participate in it, you may do so at Red Hat Issue Tracker .
Bug 2333826 - Latest os-net-config breaks "--exit-on-validation-errors" behavior
Summary: Latest os-net-config breaks "--exit-on-validation-errors" behavior
Keywords:
Status: CLOSED MIGRATED
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: os-net-config
Version: 17.1 (Wallaby)
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
: ---
Assignee: RHOSP:NFV_Eng
QA Contact: Nate Johnston
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-12-23 10:40 UTC by Alex Stupnikov
Modified: 2025-01-10 12:44 UTC (History)
6 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2025-01-10 12:44:13 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker   OSP-33297 0 None None None 2025-01-10 12:44:13 UTC

Description Alex Stupnikov 2024-12-23 10:40:11 UTC 
Description of problem:
Customer has spoofcheck option defined for VLAN interface according to https://docs.redhat.com/en/documentation/red_hat_openstack_platform/17.1/html-single/configuring_network_functions_virtualization/index#config-nic-partition_dplsriov-nfv . This configuration stopped working in RHOSP 17.1.4

OSP17.1.3 was using os-net-config-14.2.1-17.1.20230729001034.el9ost.noarch which gives only a warning message when schema is violated
OSP17.1.4 is using os-net-config-14.2.1-17.1.20240917143753.el8ost.noarch which gives an error message for the same thing and fails execution

This looks like a regression introduced via 6a03b735d4e11974082181feda61c78aba23ac27:

diff --git a/os_net_config/cli.py b/os_net_config/cli.py
index 1b40580..7b78c01 100644
--- a/os_net_config/cli.py
+++ b/os_net_config/cli.py
@@ -73,7 +73,7 @@
         action='store_true',
         help="Exit with an error if configuration file validation fails. "
              "Without this option, just log a warning and continue.",
-        default=False)
+        default=True)
 
     parser.add_argument(
         '-d', '--debug',

This change looks incorrect to me because "exit-on-validation-errors" action is to "store_true". If it is true by default, then this argument becomes pointless. IMO we shouldn't change default behavior in minor upgrades as well.


Version-Release number of selected component (if applicable): RHOSP 17.1.4


How reproducible: configure VLAN interface with disabled spoofchecks according to https://docs.redhat.com/en/documentation/red_hat_openstack_platform/17.1/html-single/configuring_network_functions_virtualization/index#config-nic-partition_dplsriov-nfv


Actual results: deployment fails


Expected results: warning should be printed as before
Note You need to log in before you can comment on or make changes to this bug.