Spec URL: https://trix.fedorapeople.org/python-torchsde.spec SRPM URL: https://trix.fedorapeople.org/python-torchsde-0.2.6-1.fc42.src.rpm PyTorch Implementation of Differentiable SDE Solvers Python package This library provides stochastic differential equation (SDE) solvers with GPU support and efficient backpropagation. This is a build requires for the ComfyUI package. Reproducible: Always
Copr build: https://copr.fedorainfracloud.org/coprs/build/8448916 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2334202-python-torchsde/fedora-rawhide-x86_64/08448916-python-torchsde/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Comments: a) Consider running tests: https://github.com/google-research/torchsde/tree/master/tests b) Consider packaging documentation: %doc DOCUMENTATION.md c) Consider packaging examples as documentation %doc examples d) Updated build with above changes https://koji.fedoraproject.org/koji/taskinfo?taskID=127373007 srpm: https://kojipkgs.fedoraproject.org//work/tasks/3007/127373007/python-torchsde-0.2.6-1.fc42.src.rpm
Created attachment 2064145 [details] Possible updates to spec file
[fedora-review-service-build]
Created attachment 2064158 [details] The .spec file difference from Copr build 8448916 to 8453922
Copr build: https://copr.fedorainfracloud.org/coprs/build/8453922 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2334202-python-torchsde/fedora-rawhide-x86_64/08453922-python-torchsde/fedora-review/review.txt Found issues: - python3-pytest7 is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Examples could be a separate sub package if included.
Spec URL: https://trix.fedorapeople.org/python-torchsde.spec SRPM URL: https://trix.fedorapeople.org/python-torchsde-0.2.6-1.fc42.src.rpm For the changes. I kept the examples in the main project. Tom
Created attachment 2064305 [details] The .spec file difference from Copr build 8453922 to 8455818
Copr build: https://copr.fedorainfracloud.org/coprs/build/8455818 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2334202-python-torchsde/fedora-rawhide-x86_64/08455818-python-torchsde/fedora-review/review.txt Found issues: - python3-pytest7 is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package must not depend on deprecated() packages. Note: python3-pytest7 is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "Apache License 2.0". 8 files have unknown license. Detailed output of licensecheck in /FedoraPackaging/reviews/torchsde/2334202-python-torchsde/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.13, /usr/lib/python3.13/site-packages [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 505249 bytes in 8 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-torchsde-0.2.6-1.fc42.noarch.rpm python-torchsde-0.2.6-1.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp_cw8l7oq')] checks: 32, packages: 2 python-torchsde.src: E: spelling-error ('backpropagation', '%description -l en_US backpropagation -> back propagation, back-propagation, propagation') python3-torchsde.noarch: E: spelling-error ('backpropagation', '%description -l en_US backpropagation -> back propagation, back-propagation, propagation') python3-torchsde.noarch: W: package-with-huge-docs 50% python3-torchsde.noarch: W: files-duplicate /usr/lib/python3.13/site-packages/torchsde/_core/methods/tableaus/__init__.py /usr/lib/python3.13/site-packages/torchsde/_core/__init__.py 2 packages and 0 specfiles checked; 2 errors, 2 warnings, 11 filtered, 2 badness; has taken 1.5 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 python3-torchsde.noarch: E: spelling-error ('backpropagation', '%description -l en_US backpropagation -> back propagation, back-propagation, propagation') python3-torchsde.noarch: W: package-with-huge-docs 50% python3-torchsde.noarch: W: files-duplicate /usr/lib/python3.13/site-packages/torchsde/_core/methods/tableaus/__init__.py /usr/lib/python3.13/site-packages/torchsde/_core/__init__.py 1 packages and 0 specfiles checked; 1 errors, 2 warnings, 7 filtered, 1 badness; has taken 0.7 s Source checksums ---------------- https://github.com/google-research/torchsde/archive/v0.2.6/torchsde-0.2.6.tar.gz : CHECKSUM(SHA256) this package : 7680ec86eb2a53918a66cead8ca0f6b50dd2fe36acfc909b546d336d269d2177 CHECKSUM(SHA256) upstream package : 7680ec86eb2a53918a66cead8ca0f6b50dd2fe36acfc909b546d336d269d2177 Requires -------- python3-torchsde (rpmlib, GLIBC filtered): python(abi) python3.13dist(numpy) python3.13dist(scipy) python3.13dist(torch) python3.13dist(trampoline) Provides -------- python3-torchsde: python-torchsde python3-torchsde python3.13-torchsde python3.13dist(torchsde) python3dist(torchsde) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2334202 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Python, Shell-api Disabled plugins: R, Perl, PHP, Java, SugarActivity, Ocaml, C/C++, fonts, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Upstream accepted patch to enable tests to run: https://github.com/google-research/torchsde/pull/158 b) Approved.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-torchsde