Bug 2334842 - Review Request: rust-libphosh - Rust bindings for libphosh
Summary: Review Request: rust-libphosh - Rust bindings for libphosh
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/libphosh
Whiteboard:
Depends On: 2334841
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-12-29 17:26 UTC by Sam Day
Modified: 2025-01-15 16:28 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-01-15 16:28:57 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Sam Day 2024-12-29 17:26:33 UTC
Spec URL: https://pagure.io/rust-libphosh/blob/main/f/rust-libphosh.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/samcday/phrog-nightly/fedora-rawhide-x86_64/08453565-rust-libphosh/rust-libphosh-0.0.4-1.fc42.src.rpm
Description: Rust bindings for libphosh

Fedora Account System Username: samcday

This package depends on `rust-libphosh-sys`, which I've already submitted: https://bugzilla.redhat.com/show_bug.cgi?id=2334841

As noted in the aforementioned `rust-libphosh-sys` request, I'm not yet a packager and would very much like to be sponsored!

I wasn't able to figure out how to submit a Koji scratch build that includes the pending `rust-libphosh-sys` dependency, so here's a COPR instead: https://copr.fedorainfracloud.org/coprs/samcday/phrog-nightly/build/8453565/

Comment 1 Fedora Review Service 2024-12-29 17:28:38 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8453919
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2334842-rust-libphosh/fedora-rawhide-x86_64/08453919-rust-libphosh/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Sam Day 2024-12-29 17:52:02 UTC
The automated review service build failed for the same reason I was unable to submit a Koji scratch build: this package depends on `rust-libphosh-sys`, which is also pending review.

Comment 3 Sam Day 2025-01-13 08:35:37 UTC
I'm waiting on last night's rawhide compose to sync to mirrors in order to get a successful `fedpkg mockbuild` locally, before I submit the updated spec here.

Comment 5 Fedora Review Service 2025-01-13 18:59:52 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8509801
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2334842-rust-libphosh/fedora-rawhide-x86_64/08509801-rust-libphosh/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Fabio Valentini 2025-01-15 14:49:19 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
🫤 test suite is run and all unit tests pass (there are zero tests)
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 7 Fedora Admin user for bugzilla script actions 2025-01-15 15:39:51 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-libphosh

Comment 8 Fedora Update System 2025-01-15 16:24:29 UTC
FEDORA-2025-54d8dd6228 (rust-libphosh-0.0.5-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-54d8dd6228

Comment 9 Fedora Update System 2025-01-15 16:28:57 UTC
FEDORA-2025-54d8dd6228 (rust-libphosh-0.0.5-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.