Spec URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/08460847-glow/glow.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/08460847-glow/glow-2.0.0-1.fc42.src.rpm Description: Glow is a terminal based markdown reader designed from the ground up to bring out the beauty—and power—of the CLI. Use it to discover markdown files, read documentation directly on the command line. Glow will find local markdown files in subdirectories or a local Git repository. Fedora Account System Username: carlwgeorge
Copr build: https://copr.fedorainfracloud.org/coprs/build/8460853 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2335125-glow/fedora-rawhide-x86_64/08460853-glow/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I made a slight adjustment to use an upstream commit as a patch to disable tests that need a network connection. Previously I was doing this with a sed in the spec file. Spec URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/08460847-glow/glow.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/08460847-glow/glow-2.0.0-1.fc42.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/8460888 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2335125-glow/fedora-rawhide-x86_64/08460888-glow/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
(In reply to Carl George 🤠 from comment #2) > I made a slight adjustment to use an upstream commit as a patch to disable > tests that need a network connection. Previously I was doing this with a > sed in the spec file. > > Spec URL: > https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/ > fedora-rawhide-x86_64/08460847-glow/glow.spec > SRPM URL: > https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/ > fedora-rawhide-x86_64/08460847-glow/glow-2.0.0-1.fc42.src.rpm I still see sed removing the tests. Did you link the wrong spec?
Using sed versus the patch for excluding the tests has no impact on the review approval. Package is approved. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* Apache License 2.0", "Apache License 2.0", "Apache License 2.0 and/or MIT License", "BSD 3-Clause License", "*No copyright* Mozilla Public License 2.0", "BSD 2-Clause License", "*No copyright* MIT License", "SIL Open Font License 1.1". 1480 files have unknown license. Detailed output of licensecheck in /home/jonathan/fedora- review/2335125-glow/licensecheck.txt [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: glow-2.0.0-1.fc42.x86_64.rpm glow-2.0.0-1.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpfz07i3x8')] checks: 32, packages: 2 glow.src: E: spelling-error ('subdirectories', '%description -l en_US subdirectories -> sub directories, sub-directories, directorates') glow.x86_64: E: spelling-error ('subdirectories', '%description -l en_US subdirectories -> sub directories, sub-directories, directorates') glow.spec: W: invalid-url Source0: glow-2.0.0-vendored.tar.gz 2 packages and 0 specfiles checked; 2 errors, 1 warnings, 7 filtered, 2 badness; has taken 0.3 s Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- glow (rpmlib, GLIBC filtered): libc.so.6()(64bit) libresolv.so.2()(64bit) rtld(GNU_HASH) Provides -------- glow: bundled(golang(github.com/alecthomas/chroma/v2)) bundled(golang(github.com/atotto/clipboard)) bundled(golang(github.com/aymanbagabas/go-osc52/v2)) bundled(golang(github.com/aymerick/douceur)) bundled(golang(github.com/caarlos0/env/v11)) bundled(golang(github.com/charmbracelet/bubbles)) bundled(golang(github.com/charmbracelet/bubbletea)) bundled(golang(github.com/charmbracelet/glamour)) bundled(golang(github.com/charmbracelet/lipgloss)) bundled(golang(github.com/charmbracelet/log)) bundled(golang(github.com/charmbracelet/x/ansi)) bundled(golang(github.com/charmbracelet/x/editor)) bundled(golang(github.com/charmbracelet/x/input)) bundled(golang(github.com/charmbracelet/x/term)) bundled(golang(github.com/charmbracelet/x/windows)) bundled(golang(github.com/dlclark/regexp2)) bundled(golang(github.com/dustin/go-humanize)) bundled(golang(github.com/erikgeiser/coninput)) bundled(golang(github.com/fsnotify/fsnotify)) bundled(golang(github.com/go-logfmt/logfmt)) bundled(golang(github.com/gorilla/css)) bundled(golang(github.com/hashicorp/hcl)) bundled(golang(github.com/inconshreveable/mousetrap)) bundled(golang(github.com/lucasb-eyer/go-colorful)) bundled(golang(github.com/magiconair/properties)) bundled(golang(github.com/mattn/go-isatty)) bundled(golang(github.com/mattn/go-localereader)) bundled(golang(github.com/mattn/go-runewidth)) bundled(golang(github.com/microcosm-cc/bluemonday)) bundled(golang(github.com/mitchellh/go-homedir)) bundled(golang(github.com/mitchellh/mapstructure)) bundled(golang(github.com/muesli/ansi)) bundled(golang(github.com/muesli/cancelreader)) bundled(golang(github.com/muesli/gitcha)) bundled(golang(github.com/muesli/go-app-paths)) bundled(golang(github.com/muesli/mango)) bundled(golang(github.com/muesli/mango-cobra)) bundled(golang(github.com/muesli/mango-pflag)) bundled(golang(github.com/muesli/reflow)) bundled(golang(github.com/muesli/roff)) bundled(golang(github.com/muesli/termenv)) bundled(golang(github.com/pelletier/go-toml/v2)) bundled(golang(github.com/rivo/uniseg)) bundled(golang(github.com/sabhiram/go-gitignore)) bundled(golang(github.com/sahilm/fuzzy)) bundled(golang(github.com/spf13/afero)) bundled(golang(github.com/spf13/cast)) bundled(golang(github.com/spf13/cobra)) bundled(golang(github.com/spf13/jwalterweatherman)) bundled(golang(github.com/spf13/pflag)) bundled(golang(github.com/spf13/viper)) bundled(golang(github.com/subosito/gotenv)) bundled(golang(github.com/xo/terminfo)) bundled(golang(github.com/yuin/goldmark)) bundled(golang(github.com/yuin/goldmark-emoji)) bundled(golang(golang.org/x/exp)) bundled(golang(golang.org/x/net)) bundled(golang(golang.org/x/sync)) bundled(golang(golang.org/x/sys)) bundled(golang(golang.org/x/term)) bundled(golang(golang.org/x/text)) bundled(golang(gopkg.in/ini.v1)) bundled(golang(gopkg.in/yaml.v3)) glow glow(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2335125 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: R, Haskell, Python, PHP, Java, Ocaml, fonts, Perl, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
> I still see sed removing the tests. Did you link the wrong spec? Whoops, yeah I used the wrong links, %autorelease makes it a bit less obvious. Here are the correct ones. Spec URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/08460878-glow/glow.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/carlwgeorge/reviews/fedora-rawhide-x86_64/08460878-glow/glow-2.0.0-1.fc42.src.rpm
The Pagure repository was created at https://src.fedoraproject.org/rpms/glow
FEDORA-2025-17707abd0d (glow-2.0.0-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-17707abd0d
FEDORA-2025-ba7dded497 (glow-2.0.0-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2025-ba7dded497
FEDORA-2025-4d0ba2964d (glow-2.0.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-4d0ba2964d
FEDORA-2025-17707abd0d (glow-2.0.0-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-ba7dded497 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-ba7dded497 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-ba7dded497 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2025-a77f6f0346 has been pushed to the Fedora EPEL 10.0 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2025-a77f6f0346 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-4d0ba2964d has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-4d0ba2964d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-4d0ba2964d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-4d0ba2964d (glow-2.0.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-ba7dded497 (glow-2.0.0-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2025-a77f6f0346 (glow-2.0.0-1.el10_0) has been pushed to the Fedora EPEL 10.0 stable repository. If problem still persists, please make note of it in this bug report.