Spec URL: https://www.flyn.org/SRPMS/python-pycryptodome.spec SRPM URL: https://www.flyn.org/SRPMS/python-pycryptodome-3.21.0-1.fc41.src.rpm Description: Cryptographic library for Python Fedora Account System Username: mikep
Copr build: https://copr.fedorainfracloud.org/coprs/build/8463880 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2335258-python-pycryptodome/fedora-rawhide-x86_64/08463880-python-pycryptodome/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/python-pycryptodome Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Beware of bz1756505.
Are you sure angr uses this? I don't see any mention of it directly.
Python angr requires cle, which requires cart, which requires pycryptodome, I think. Regarding comment #2, the pycrypto website states "PyCrypto 2.x is unmaintained, obsolete, and contains security vulnerabilities." That same website recommends pycryptodome as an alternative.
(In reply to W. Michael Petullo from comment #4) > Regarding comment #2, the pycrypto website states "PyCrypto 2.x is > unmaintained, obsolete, and contains security vulnerabilities." That same > website recommends pycryptodome as an alternative. I am not saying which is better. I am saying there is a conflict and it needs to be explicitly handled.
Hello, Fedora already provides the python-pycryptodomex package, built from the same upstream sources as your package, but with a different namespace to avoid conflicts. This namespace is provided and supported by upstream, making it a reliable alternative. It should be straightforward to patch angr to use pycryptodomex.
See also bz1370919
I am dropping this review. Instead, I modified my proposed python-cart package to use the existing python-pycryptodomex package. I also asked about formally replacing python-crypto with python-pycryptodome: https://lists.fedoraproject.org/archives/list/python-devel@lists.fedoraproject.org/thread/UTH7MYUQSSZGN2MPQNGCHLWHDMHDNCQH/ Thank you, Mohamed, for pointing out the existence of python-pycryptodomex.