Bug 2336914 - binwalk fails to build with Python 3.14: TypeError: unsupported operand type(s) for +=: 'NoneType' and 'int'
Summary: binwalk fails to build with Python 3.14: TypeError: unsupported operand type(...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: binwalk
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Peter Robinson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 2371682 (view as bug list)
Depends On:
Blocks: PYTHON3.14 F43FTBFS F43FailsToInstall 2371704
TreeView+ depends on / blocked
 
Reported: 2025-01-10 12:57 UTC by Karolina Surma
Modified: 2025-09-12 19:29 UTC (History)
8 users (show)

Fixed In Version: binwalk-2.3.4-14.fc43
Clone Of:
Environment:
Last Closed: 2025-09-12 19:29:40 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Karolina Surma 2025-01-10 12:57:35 UTC
binwalk fails to build with Python 3.14.0a3.

4 tests fail with the same traceback
FAILED test_firmware_gzip.py::test_firmware_gzip - AssertionError
FAILED test_firmware_jffs2.py::test_firmware_jffs2 - AssertionError
FAILED test_firmware_squashfs.py::test_firmware_squashfs - AssertionError
FAILED test_firmware_zip.py::test_firmware_zip - AssertionError

Example failure:
______________________________ test_firmware_gzip ______________________________

    def test_firmware_gzip():
        '''
        Test: Open firmware.gzip, scan for signatures.
        Verify that only one gzip signature was detected.
        '''
        input_vector_file = os.path.join(os.path.dirname(__file__),
                                         "input-vectors",
                                         "firmware.gzip")
    
        scan_result = binwalk.scan(input_vector_file,
                                   signature=True,
                                   quiet=True)
    
        # Test number of modules used
        eq_(len(scan_result), 1)
    
        # There should be only one result
>       eq_(len(scan_result[0].results), 1)

test_firmware_gzip.py:23: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

a = 0, b = 1

    def eq_(a, b):
>       assert a == b
E       AssertionError

_nose_shim.py:2: AssertionError
----------------------------- Captured stderr call -----------------------------

Signature Exception: unsupported operand type(s) for +=: 'NoneType' and 'int'
----------------------------------------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/binwalk-2.3.4-build/BUILDROOT/usr/lib/python3.14/site-packages/binwalk/core/module.py", line 595, in main
    retval = self.run()
  File "/builddir/build/BUILD/binwalk-2.3.4-build/BUILDROOT/usr/lib/python3.14/site-packages/binwalk/modules/signature.py", line 192, in run
    self.scan_file(fp)
    ~~~~~~~~~~~~~~^^^^
  File "/builddir/build/BUILD/binwalk-2.3.4-build/BUILDROOT/usr/lib/python3.14/site-packages/binwalk/modules/signature.py", line 150, in scan_file
    for r in self.magic.scan(data, dlen):
             ~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "/builddir/build/BUILD/binwalk-2.3.4-build/BUILDROOT/usr/lib/python3.14/site-packages/binwalk/core/magic.py", line 827, in scan
    tags = self._analyze(signature, offset)
  File "/builddir/build/BUILD/binwalk-2.3.4-build/BUILDROOT/usr/lib/python3.14/site-packages/binwalk/core/magic.py", line 584, in _analyze
    line_offset = self._do_math(offset, line_offset_text)
  File "/builddir/build/BUILD/binwalk-2.3.4-build/BUILDROOT/usr/lib/python3.14/site-packages/binwalk/core/magic.py", line 505, in _do_math
    o += offset
TypeError: unsupported operand type(s) for +=: 'NoneType' and 'int'
----------------------------------------------------------------------------------------------------

https://docs.python.org/3.14/whatsnew/3.14.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.14/fedora-rawhide-x86_64/08480129-binwalk/

For all our attempts to build binwalk with Python 3.14, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.14/package/binwalk/

Testing and mass rebuild of packages is happening in copr.
You can follow these instructions to test locally in mock if your package builds with Python 3.14:
https://copr.fedorainfracloud.org/coprs/g/python/python3.14/

Let us know here if you have any questions.

Python 3.14 is planned to be included in Fedora 43.
To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.14.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires),
so if this package is required a lot, it's important for us to get it fixed soon.

We'd appreciate help from the people who know this package best,
but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Aoife Moloney 2025-02-26 13:22:11 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 42 development cycle.
Changing version to 42.

Comment 2 Karolina Surma 2025-06-11 15:52:26 UTC
*** Bug 2371682 has been marked as a duplicate of this bug. ***

Comment 3 Zbigniew Jędrzejewski-Szmek 2025-06-16 10:38:01 UTC
I'll skip the tests with binwalks in diffoscope for now, to allow a build to happen.

Comment 4 Fedora Fails To Install 2025-06-20 19:50:51 UTC
Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

This package fails to install and maintainers are advised to take one of the following actions:

 - Fix this bug and close this bugzilla once the update makes it to the repository.
   (The same script that posted this comment will eventually close this bugzilla
   when the fixed package reaches the repository, so you don't have to worry about it.)

or

 - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet.

or

 - Orphan the package if you no longer plan to maintain it.


If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue.
This package may be orphaned in 7+ weeks.
This is the first reminder (step 3) from the policy.

Don't hesitate to ask for help on https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ if you are unsure how to fix this bug.

Comment 5 Fedora Fails To Install 2025-07-15 08:34:12 UTC
Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

This package fails to install and maintainers are advised to take one of the following actions:

 - Fix this bug and close this bugzilla once the update makes it to the repository.
   (The same script that posted this comment will eventually close this bugzilla
   when the fixed package reaches the repository, so you don't have to worry about it.)

or

 - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet.

or

 - Orphan the package if you no longer plan to maintain it.


If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue.
This package may be orphaned in 4+ weeks.
This is the second reminder (step 4) from the policy.

Don't hesitate to ask for help on https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ if you are unsure how to fix this bug.

Comment 6 Fedora Fails To Install 2025-08-12 12:18:21 UTC
This package has been orphaned.

You can pick it up at https://src.fedoraproject.org/rpms/binwalk by clicking button "Take". If nobody picks it up, it will be retired and removed from a distribution.

Comment 7 Fedora Admin user for bugzilla script actions 2025-08-12 13:08:04 UTC
This package has changed maintainer in Fedora. Reassigning to the new maintainer of this component.

Comment 8 Fedora Fails To Install 2025-08-14 20:34:56 UTC
Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

This package fails to install and maintainers are advised to take one of the following actions:

 - Fix this bug and close this bugzilla once the update makes it to the repository.
   (The same script that posted this comment will eventually close this bugzilla
   when the fixed package reaches the repository, so you don't have to worry about it.)

or

 - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet.

or

 - Orphan the package if you no longer plan to maintain it.


If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue.
This package may be orphaned in 7+ weeks.
This is the first reminder (step 3) from the policy.

Don't hesitate to ask for help on https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ if you are unsure how to fix this bug.

Comment 9 Fedora Admin user for bugzilla script actions 2025-08-15 01:01:24 UTC
This package has changed maintainer in Fedora. Reassigning to the new maintainer of this component.

Comment 10 Fedora Fails To Install 2025-08-18 13:03:30 UTC
Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

This package fails to install and maintainers are advised to take one of the following actions:

 - Fix this bug and close this bugzilla once the update makes it to the repository.
   (The same script that posted this comment will eventually close this bugzilla
   when the fixed package reaches the repository, so you don't have to worry about it.)

or

 - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet.

or

 - Orphan the package if you no longer plan to maintain it.


If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue.
This package may be orphaned in 7+ weeks.
This is the first reminder (step 3) from the policy.

Don't hesitate to ask for help on https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ if you are unsure how to fix this bug.

Comment 11 Fedora Update System 2025-09-03 19:35:52 UTC
FEDORA-2025-7147d9c075 (binwalk-2.3.4-14.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-7147d9c075

Comment 12 Fedora Update System 2025-09-04 01:13:31 UTC
FEDORA-2025-7147d9c075 has been pushed to the Fedora 43 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-7147d9c075`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-7147d9c075

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Fails To Install 2025-09-08 09:22:11 UTC
Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

All subpackages of a package against which this bug was filled are now installable or removed from Fedora 44.

Thanks for taking care of it!

Comment 14 Fedora Update System 2025-09-12 19:29:40 UTC
FEDORA-2025-7147d9c075 (binwalk-2.3.4-14.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.