Spec URL: https://download.copr.fedorainfracloud.org/results/sfaulken/labwc-tweaks/fedora-rawhide-x86_64/08502261-labwc-tweaks/labwc-tweaks.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/sfaulken/labwc-tweaks/fedora-rawhide-x86_64/08502261-labwc-tweaks/labwc-tweaks-git20241022.d97f0a2-1.fc42.src.rpm Description: labwc-tweaks offers some GUI configuration capability for the labwc wayland compositor. This is advantageous to end users, particularly with use of the labwc compositor with LXQt Fedora Account System Username: sfaulken Reproducible: Always
Copr build: https://copr.fedorainfracloud.org/coprs/build/8506088 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2337168-labwc-tweaks/fedora-rawhide-x86_64/08506088-labwc-tweaks/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Taking this review.
Initial spec review: > Version: git%{commitdate}.%{shortcommit} This is not a valid version. It needs to be prefixed with "0.1.0~", since "0.1.0" is the version set in CMakeLists. Thus, it should be "0.1.0~git%{commitdate}.%{shortcommit}".
Updated: Spec URL: https://download.copr.fedorainfracloud.org/results/sfaulken/labwc-tweaks/fedora-rawhide-x86_64/08507315-labwc-tweaks/labwc-tweaks.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/sfaulken/labwc-tweaks/fedora-rawhide-x86_64/08507315-labwc-tweaks/labwc-tweaks-0.1.0~git20241022.d97f0a2-1.fc42.src.rpm
Created attachment 2065735 [details] The .spec file difference from Copr build 8506088 to 8507316
Copr build: https://copr.fedorainfracloud.org/coprs/build/8507316 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2337168-labwc-tweaks/fedora-rawhide-x86_64/08507316-labwc-tweaks/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> BuildRequires: perl-devel What's "perl-devel" for? Wouldn't "perl-interpreter" be sufficient here?
Yep, perl-interpreter works fine. It was an oversight on my part, as the perl-interpreter is in the openSUSE TW buildroot, And I packaged there first. Updated: Spec URL: https://download.copr.fedorainfracloud.org/results/sfaulken/labwc-tweaks/fedora-rawhide-x86_64/08507369-labwc-tweaks/labwc-tweaks.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/sfaulken/labwc-tweaks/fedora-rawhide-x86_64/08507369-labwc-tweaks/labwc-tweaks-0.1.0~git20241022.d97f0a2-1.fc42.src.rpm
Created attachment 2065737 [details] The .spec file difference from Copr build 8507316 to 8507372
Copr build: https://copr.fedorainfracloud.org/coprs/build/8507372 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2337168-labwc-tweaks/fedora-rawhide-x86_64/08507372-labwc-tweaks/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.