Spec URL: http://allele5.biol.berkeley.edu/~alex/fedora/perl-Math-Derivative.spec SRPM URL: http://allele5.biol.berkeley.edu/~alex/fedora/perl-Math-Derivative-0.01-1.noarch.rpm Description: This package provides cubic spline interpolation of numeric data. The data is passed as references to two arrays containing the x and y ordinates. It may be used as an exporter of the numerical functions or, more easily as a class module.
Fixed URLs to spec and RPM Spec URL: http://allele5.biol.berkeley.edu/~alex/fedora/perl-Math-Spline.spec SRPM URL: http://allele5.biol.berkeley.edu/~alex/fedora/perl-Math-Spline-0.01-1.src.rpm
No License test in Spline.pm
Found some License text in README as Copyright (c) 1995 John A.R. Williams. All rights reserved. This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself.
the perl-Math-Spline package has the same issue as perl-Math-Derivative (approved by cweyl), I will bug upstream about putting the license in the Spline.pm file.
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url a9ebe29ba1794d1dca60aa0c44178197 Math-Spline-0.01.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test No tests defined for Math::Spline extension. + Provides: perl(Math::Spline) APPROVED.
New Package CVS Request ======================= Package Name: perl-Math-Spline Short Description: Perl module for cubic spline interpolation of data Owners: alexl.net Branches: FC-5 FC-6 InitialCC:
Builds fine all branches. Closing.