Spec URL: https://download.copr.fedorainfracloud.org/results/ngompa/gnome-decibels/fedora-rawhide-x86_64/08512836-decibels/decibels.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ngompa/gnome-decibels/fedora-rawhide-x86_64/08512836-decibels/decibels-48.0~alpha-1.fc42.src.rpm Description: Audio Player for the GNOME Desktop. Fedora Account System Username: ngompa
It builds in COPR: https://copr.fedorainfracloud.org/coprs/ngompa/gnome-decibels/build/8512836/ This package requires an updated typescript: https://src.fedoraproject.org/rpms/typescript/pull-request/1
Copr build: https://copr.fedorainfracloud.org/coprs/build/8512873 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2337627-decibels/fedora-rawhide-x86_64/08512873-decibels/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated to drop redundant second source (it's already in the release tarball) Spec URL: https://download.copr.fedorainfracloud.org/results/ngompa/gnome-decibels/fedora-rawhide-x86_64/08513004-decibels/decibels.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ngompa/gnome-decibels/fedora-rawhide-x86_64/08513004-decibels/decibels-48.0~alpha-1.fc42.src.rpm COPR build: https://copr.fedorainfracloud.org/coprs/ngompa/gnome-decibels/build/8513004/
Created attachment 2065999 [details] The .spec file difference from Copr build 8512873 to 8513061
Copr build: https://copr.fedorainfracloud.org/coprs/build/8513061 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2337627-decibels/fedora-rawhide-x86_64/08513061-decibels/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/8521533 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2337627-decibels/fedora-rawhide-x86_64/08521533-decibels/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Does it fail to start without gstreamer1-plugins-bad-free-libs? For reasonable coverage of GStreamer elements, we might want to Recommends: gstreamer1-plugins-good, gstreamer1-plugins-bad-free, and gstreamer1-plugins-ugly-free. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. (Should add a %check stage and run desktop-file-validate and also appstream-util validate-relax.) - Please review the licensecheck output and adjust the license tag; it's probably going to need to be a more complicated expression - Please do consider switching to rpm-autospec before uploading the package, unless you really hate it or something. It makes updates easier. - Spec use %global instead of %define unless justified. Note: %define requiring justification: %define rdnn_name org.gnome.Decibels Regarding the rpminspect output: decibels.spec:27: W: unversioned-explicit-provides bundled(gi-typescript-definitions) I would just ignore this, since there are no upstream versions and there's nothing you can do. decibels.noarch: W: no-manual-page-for-binary org.gnome.Decibels Please create an upstream issue report to request a man page. decibels.noarch: E: explicit-lib-dependency gstreamer1-plugins-bad-free-libs decibels.noarch: E: explicit-lib-dependency libadwaita I would ignore these too. Our choices are to depend on the libs or depend on the files. Surely a depends on the library package is better than relying on file provides. ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0 and/or GNU General Public License, Version 3 and/or MIT License", "*No copyright* GNU General Public License, Version 3", "GNU Library General Public License v2 or later". 203 files have unknown license. Detailed output of licensecheck in /var/lib/copr- rpmbuild/results/decibels/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/dbus-1, /usr/share/dbus-1/services [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 2549 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [-]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define rdnn_name org.gnome.Decibels [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: decibels-48.0~alpha-1.fc42.noarch.rpm decibels-48.0~alpha-1.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpulaw4ig7')] checks: 32, packages: 2 decibels.spec:27: W: unversioned-explicit-provides bundled(gi-typescript-definitions) decibels.noarch: W: no-manual-page-for-binary org.gnome.Decibels decibels.noarch: E: explicit-lib-dependency gstreamer1-plugins-bad-free-libs decibels.noarch: E: explicit-lib-dependency libadwaita 2 packages and 0 specfiles checked; 2 errors, 2 warnings, 7 filtered, 2 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "decibels". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://download.gnome.org/sources/decibels/48/decibels-48.0.alpha.tar.xz : CHECKSUM(SHA256) this package : 6e5ba0722b4afc441dcbe629a5e724ad3eb006cc0cb1ef9aa24e11da989122fc CHECKSUM(SHA256) upstream package : 6e5ba0722b4afc441dcbe629a5e724ad3eb006cc0cb1ef9aa24e11da989122fc Requires -------- decibels (rpmlib, GLIBC filtered): gstreamer1-plugins-bad-free-libs gtk4 hicolor-icon-theme libadwaita Provides -------- decibels: application() application(org.gnome.Decibels.desktop) bundled(gi-typescript-definitions) decibels metainfo() metainfo(org.gnome.Decibels.metainfo.xml) mimehandler(audio/mpeg) mimehandler(audio/wav) mimehandler(audio/x-aac) mimehandler(audio/x-aiff) mimehandler(audio/x-ape) mimehandler(audio/x-flac) mimehandler(audio/x-m4a) mimehandler(audio/x-m4b) mimehandler(audio/x-mp1) mimehandler(audio/x-mp2) mimehandler(audio/x-mp3) mimehandler(audio/x-mpeg) mimehandler(audio/x-mpegurl) mimehandler(audio/x-mpg) mimehandler(audio/x-opus+ogg) mimehandler(audio/x-pn-aiff) mimehandler(audio/x-pn-au) mimehandler(audio/x-pn-wav) mimehandler(audio/x-speex) mimehandler(audio/x-vorbis) mimehandler(audio/x-vorbis+ogg) mimehandler(audio/x-wavpack)
(In reply to Michael Catanzaro from comment #8) > Does it fail to start without gstreamer1-plugins-bad-free-libs? > Yes as the typelib for GstPlay is in there. Since we don't have the typelib dependency generator, this all needs to be specified manually. > For reasonable coverage of GStreamer elements, we might want to Recommends: > gstreamer1-plugins-good, gstreamer1-plugins-bad-free, and > gstreamer1-plugins-ugly-free. > I can add these on import.
Updated spec with feedback and corrections Spec URL: https://ngompa.fedorapeople.org/for-review/decibels.spec SRPM URL: https://ngompa.fedorapeople.org/for-review/decibels-48.0~alpha-1.fc41.src.rpm
Created attachment 2066367 [details] The .spec file difference from Copr build 8521533 to 8523999
Copr build: https://copr.fedorainfracloud.org/coprs/build/8523999 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2337627-decibels/fedora-rawhide-x86_64/08523999-decibels/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
# one source file is GPLv2+ the rest are GPLv3 Please adjust the above comment to indicate which file is GPLv2+, to make it easier to check that the License tag is correct. You created upstream issue reports: https://gitlab.gnome.org/GNOME/decibels/-/issues/114 https://gitlab.gnome.org/GNOME/decibels/-/issues/115 The other problems are all fixed, so I'll approve.
The Pagure repository was created at https://src.fedoraproject.org/rpms/decibels
FEDORA-2025-dcfe0b19a3 (decibels-48.0~alpha-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-dcfe0b19a3
FEDORA-2025-dcfe0b19a3 (decibels-48.0~alpha-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.