Bug 233846 - (perl-XML-DOM-XPath) Review Request: perl-XML-DOM-XPath - Perl extension to add XPath support to XML::DOM, using XML::XPath engine
Review Request: perl-XML-DOM-XPath - Perl extension to add XPath support to X...
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
:
Depends On: perl-XML-XPathEngine
Blocks:
  Show dependency treegraph
 
Reported: 2007-03-25 08:15 EDT by Alex Lancaster
Modified: 2009-09-16 17:19 EDT (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-03-29 22:15:32 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
panemade: fedora‑review+
tibbs: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Alex Lancaster 2007-03-25 08:15:35 EDT
Spec URL: http://allele5.biol.berkeley.edu/~alex/fedora/perl-XML-DOM-XPath.spec
SRPM URL: http://allele5.biol.berkeley.edu/~alex/fedora/perl-XML-DOM-XPath-0.13-1.src.rpm
Description: 
XML::DOM::XPath allows you to use XML::XPath methods to query a DOM. This
is often much easier than relying only on getElementsByTagName.

Note this depends on bug #233845 because perl-XML-XPathEngine is a BuildRequires for this bug.
Comment 1 Parag AN(पराग) 2007-03-29 03:22:41 EDT
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
276b4863d2886df313f849b329b9e090  XML-DOM-XPath-0.13.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/1...................................ok
t/pod.................................ok
t/pod_coverage........................ok
t/test_bugs...........................ok
t/test_non_ascii......................ok
t/test_xml_xpath_and_xml_dom_xpath....ok
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
276b4863d2886df313f849b329b9e090  XML-DOM-XPath-0.13.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test
PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0,
'blib/lib', 'blib/arch')" t/*.t
t/1...................................ok
t/pod.................................ok
t/pod_coverage........................ok
t/test_bugs...........................ok
t/test_non_ascii......................ok
t/test_xml_xpath_and_xml_dom_xpath....ok
t/test_non_ascii......................ok
t/test_xml_xpath_and_xml_dom_xpath....ok
t/xmlxpath_01basic....................ok
t/xmlxpath_02descendant...............ok
t/xmlxpath_03star.....................ok
t/xmlxpath_04pos......................ok
t/xmlxpath_05attrib...................ok
t/xmlxpath_06attrib_val...............ok
t/xmlxpath_07count....................ok
t/xmlxpath_08name.....................ok
t/xmlxpath_09a_string_length..........ok
t/xmlxpath_09string_length............ok
t/xmlxpath_10pipe.....................ok
t/xmlxpath_12axisdescendant...........ok
t/xmlxpath_13axisparent...............ok
t/xmlxpath_14axisancestor.............ok
t/xmlxpath_15axisfol_sib..............ok
t/xmlxpath_16axisprec_sib.............ok
t/xmlxpath_17axisfollowing............ok
t/xmlxpath_18axispreceding............ok
t/xmlxpath_19axisd_or_s...............ok
t/xmlxpath_20axisa_or_s...............ok
t/xmlxpath_21allnodes.................ok
t/xmlxpath_22name_select..............ok
t/xmlxpath_23func.....................ok
t/xmlxpath_24namespaces...............ok
t/xmlxpath_25scope....................ok
t/xmlxpath_26predicate................ok
t/xmlxpath_28ancestor2................ok
t/xmlxpath_29desc_with_predicate......ok
t/xmlxpath_30lang.....................ok
All tests successful.
Files=35, Tests=182, 10 wallclock secs ( 6.39 cusr +  0.85 csys =  7.24 CPU)
+ Provides: perl(XML::DOM::Attr) perl(XML::DOM::Comment)
perl(XML::DOM::Document) perl(XML::DOM::Element) perl(XML::DOM::Namespace)
perl(XML::DOM::Node) perl(XML::DOM::ProcessingInstruction) perl(XML::DOM::Text)
perl(XML::DOM::XPath)

APPROVED.
Comment 2 Alex Lancaster 2007-03-29 03:46:05 EDT
New Package CVS Request
=======================
Package Name: perl-XML-DOM-XPath
Short Description:  Perl extension to add XPath support to XML::DOM, using
XML::XPath engine
Owners: alexl@users.sourceforge.net
Branches: FC-5 FC-6
InitialCC: 
Comment 3 Alex Lancaster 2007-03-29 22:15:32 EDT
Builds fine in all branches.  Closing.
Comment 4 Matthew Booth 2009-09-08 06:20:14 EDT
Package Change Request
======================
Package Name: perl-XML-DOM-XPath
New Branches: EL-5
Owners: 

I would like to add perl-XML-DOM-XPath to EL-5 as it is a dependency of virt-v2v.
Comment 5 Jason Tibbitts 2009-09-11 16:30:11 EDT
The same issues apply here as in bug 233845.
Comment 6 Matthew Booth 2009-09-15 05:31:14 EDT
Package Change Request
======================
Package Name: perl-XML-DOM-XPath
New Branches: EL-5
Owners: mdbooth alexlan

Having been pointed to the procedure, I see alexlan isn't interested in EPEL but would like to be co-maintainer.
Comment 7 Jason Tibbitts 2009-09-16 17:19:50 EDT
CVS done.

Note You need to log in before you can comment on or make changes to this bug.