Bug 2338828 (CVE-2025-21647) - CVE-2025-21647 kernel: sched: sch_cake: add bounds checks to host bulk flow fairness counts
Summary: CVE-2025-21647 kernel: sched: sch_cake: add bounds checks to host bulk flow f...
Keywords:
Status: NEW
Alias: CVE-2025-21647
Product: Security Response
Classification: Other
Component: vulnerability
Version: unspecified
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Product Security DevOps Team
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-01-19 11:02 UTC by OSIDB Bzimport
Modified: 2025-02-03 05:44 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Embargoed:


Attachments (Terms of Use)

Description OSIDB Bzimport 2025-01-19 11:02:14 UTC
In the Linux kernel, the following vulnerability has been resolved:

sched: sch_cake: add bounds checks to host bulk flow fairness counts

Even though we fixed a logic error in the commit cited below, syzbot
still managed to trigger an underflow of the per-host bulk flow
counters, leading to an out of bounds memory access.

To avoid any such logic errors causing out of bounds memory accesses,
this commit factors out all accesses to the per-host bulk flow counters
to a series of helpers that perform bounds-checking before any
increments and decrements. This also has the benefit of improving
readability by moving the conditional checks for the flow mode into
these helpers, instead of having them spread out throughout the
code (which was the cause of the original logic error).

As part of this change, the flow quantum calculation is consolidated
into a helper function, which means that the dithering applied to the
ost load scaling is now applied both in the DRR rotation and when a
sparse flow's quantum is first initiated. The only user-visible effect
of this is that the maximum packet size that can be sent while a flow
stays sparse will now vary with +/- one byte in some cases. This should
not make a noticeable difference in practice, and thus it's not worth
complicating the code to preserve the old behaviour.

Comment 1 Avinash Hanwate 2025-01-20 06:47:59 UTC
Upstream advisory:
https://lore.kernel.org/linux-cve-announce/2025011946-CVE-2025-21647-51d8@gregkh/T


Note You need to log in before you can comment on or make changes to this bug.