Spec URL: https://raw.githubusercontent.com/tylerfanelli/rust-snpguest-f42-candidate/refs/heads/main/rust-snpguest.spec SRPM URL: https://github.com/tylerfanelli/rust-snpguest-f42-candidate/raw/refs/heads/main/rust-snpguest-0.8.2-1.fc42.src.rpm Description: Navigation utility for AMD SEV-SNP guest environment Fedora Account System Username: tfanelli
Copr build: https://copr.fedorainfracloud.org/coprs/build/8548024 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2338952-rust-snpguest/fedora-rawhide-x86_64/08548024-rust-snpguest/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/8552788 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2338952-rust-snpguest/fedora-rawhide-x86_64/08552788-rust-snpguest/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
rust2rpm.toml URL: https://raw.githubusercontent.com/tylerfanelli/rust-snpguest-f42-candidate/refs/heads/main/rust2rpm.toml
Created attachment 2074376 [details] The .spec file difference from Copr build 8552788 to 8585309
Copr build: https://copr.fedorainfracloud.org/coprs/build/8585309 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2338952-rust-snpguest/fedora-rawhide-x86_64/08585309-rust-snpguest/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Steps to generate package: 1) rust2rpm snpguest 2) Adjust license FIXME with content from ${cargo_license_summary}
Spec URL: https://raw.githubusercontent.com/tylerfanelli/rust-snpguest-f42-candidate/refs/heads/main/rust-snpguest.spec SRPM URL: https://github.com/tylerfanelli/rust-snpguest-f42-candidate/raw/refs/heads/main/rust-snpguest-0.8.2-1.fc42.src.rpm Description: Navigation utility for AMD SEV-SNP guest environment Fedora Account System Username: tfanelli updated rust2rpm.toml: https://raw.githubusercontent.com/tylerfanelli/rust-snpguest-f42-candidate/refs/heads/main/rust2rpm.toml
Copr build: https://copr.fedorainfracloud.org/coprs/build/8585547 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2338952-rust-snpguest/fedora-rawhide-x86_64/08585547-rust-snpguest/fedora-review/review.txt Found issues: - Upstream MD5sum check error, diff is in /var/lib/copr-rpmbuild/results/rust-snpguest/diff.txt Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/8585511 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2338952-rust-snpguest/fedora-rawhide-x86_64/08585511-rust-snpguest/fedora-review/review.txt Found issues: - Upstream MD5sum check error, diff is in /var/lib/copr-rpmbuild/results/rust-snpguest/diff.txt Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
So I tried a scratch-build, but it's failing for non-x86 arches: https://kojipkgs.fedoraproject.org//work/tasks/1442/128621442/build.log I did: koji build --scratch f42 <srpm-path> I see you tried to cover that with supported-arches = ["x86_64"], which I thought would cover it too. But that only skips %cargo_build and %cargo_test. %cargo_install is still invoked, and that will apparently trigger %cargo_build equivalent anyways. I _think_ supported-arches is only going to work for your case if this was a plain rust crate and not a binary crate. So I think you'll need to add a manual `ExclusiveArch: x86_64` to the spec file, like you do for the similar rust-sevctl: https://src.fedoraproject.org/rpms/rust-sevctl/blob/rawhide/f/rust-sevctl.spec#_21
(In reply to Cole Robinson from comment #13) > So I tried a scratch-build, but it's failing for non-x86 arches: > https://kojipkgs.fedoraproject.org//work/tasks/1442/128621442/build.log > I did: koji build --scratch f42 <srpm-path> > > I see you tried to cover that with supported-arches = ["x86_64"], which I > thought would cover it too. But that only skips %cargo_build and > %cargo_test. %cargo_install is still invoked, and that will apparently > trigger %cargo_build equivalent anyways. > > I _think_ supported-arches is only going to work for your case if this was a > plain rust crate and not a binary crate. So I think you'll need to add a > manual `ExclusiveArch: x86_64` to the spec file, like you do for the similar > rust-sevctl: > https://src.fedoraproject.org/rpms/rust-sevctl/blob/rawhide/f/rust-sevctl. > spec#_21 Yes, it seems after I added the ExclusiveArch in the spec file itself, it only builds for x86_64. I was seeing errors on scratch-build for other arches as well, but I ignored them because the build done by the review service reported success. Nonetheless, I updated the relevant files and resubmitted.
Looks good to me now, setting fedora-review+ ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-snpguest
FEDORA-2025-efc61672c1 (rust-snpguest-0.8.2-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-efc61672c1
FEDORA-2025-efc61672c1 (rust-snpguest-0.8.2-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.