spec: https://suve.fedorapeople.org/review/php-splitbrain-lesserphp-0.10.2-1/php-splitbrain-lesserphp.spec srpm: https://suve.fedorapeople.org/review/php-splitbrain-lesserphp-0.10.2-1/php-splitbrain-lesserphp-0.10.2-1.fc41.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=128210303 Description: LesserPHP is a compiler for LESS written in PHP. It is based on lessphp by leafo. The original has been abandoned in 2014. The fork by MarcusSchwarz has been mostly abandoned in 2021. This is an opinionated fork with the goal to modernize the code base enough to be somewhat easier to maintain without completely rewriting it. FAS username: suve
Copr build: https://copr.fedorainfracloud.org/coprs/build/8552590 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2339019-php-splitbrain-lesserphp/fedora-rawhide-x86_64/08552590-php-splitbrain-lesserphp/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/php/splitbrain [!]: If the package is a rename of another package, proper Obsoletes and Provides are present. php-splitbrain-lesserphp.noarch: W: obsolete-not-provided php-lessphp Don't obsolete it or provide it if it is fully compatible but in this case, you also have to package the old autoloader (a link to the new one ?) [!]: Requires correct, justified where necessary. Requires: php-cli >= 7.4.0 Please use php(language) >= 7.4.0, see https://docs.fedoraproject.org/en-US/packaging-guidelines/PHP/#requires-provides-min-php Requires: php-date Requires: php-pcre Both can be removed, see https://docs.fedoraproject.org/en-US/packaging-guidelines/PHP/#requires-provides-extensions About composer.json stuff 1/ you have both a sed command and a patch, why ? 2/ better fix is to move "tests" in "autoload-dev", which can be submitted to upstream: "autoload": { "psr-4": { "LesserPHP\\": "src" } }, "autoload-dev": { "psr-4": { "LesserPHP\\tests\\": "tests" } }, 3/ alternative use "phpab --template fedora --output src/autoload.php src"
Created attachment 2073993 [details] review.txt
Created attachment 2073994 [details] phpci.log
> php-splitbrain-lesserphp.noarch: W: obsolete-not-provided php-lessphp > > Don't obsolete it or provide it if it is fully compatible > but in this case, you also have to package the old autoloader (a link to the new one ?) Hmm. I want this package to obsolete php-marcusschwarz-lesserphp, which is unmaintained upstream. The package in question also has "Obsoletes: php-lessphp", even though it's not fully compatible. Should I make this obsolete only php-marcusschwarz-lesserphp and remove the php-lessphp bit?
php-lessphp is retired since F32, so no value in obsoleting it php-marcusschwarz-lesserphp is in the repo If php-splitbrain-lesserphp is fully compatible you can obsolete/provide it but in this case it needs to be a true replacement: - so same provides php-composer(....) which is commonly used - same autoloader path (or symlink to new path) Else (not compatible), simply ignore the replacement and retire the old one when no more used
Using dnf repoquery shows that the only package depending on php-marcusschwarz-lesserphp is dokuwiki, which will be dropping the dependency once I finally update it to a newer version. As such, I've removed the Obsoletes completely. > Note: Directories without known owners: /usr/share/php/splitbrain Fixed. > Requires: php-cli >= 7.4.0 > Please use php(language) >= 7.4.0, see https://docs.fedoraproject.org/en-US/packaging-guidelines/PHP/#requires-provides-min-php > Requires: php-date > Requires: php-pcre > Both can be removed, see https://docs.fedoraproject.org/en-US/packaging-guidelines/PHP/#requires-provides-extensions Done. > About composer.json stuff > 1/ you have both a sed command and a patch, why ? I guess I tried sed first, then went for the patch and forgot to remove the sed call. > 2/ better fix Thanks! spec: https://suve.fedorapeople.org/review/php-splitbrain-lesserphp-0.10.2-2/php-splitbrain-lesserphp.spec srpm: https://suve.fedorapeople.org/review/php-splitbrain-lesserphp-0.10.2-2/php-splitbrain-lesserphp-0.10.2-2.fc41.src.rpm koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=128656084
Copr build: https://copr.fedorainfracloud.org/coprs/build/8587805 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2339019-php-splitbrain-lesserphp/fedora-rawhide-x86_64/08587805-php-splitbrain-lesserphp/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[x]: Package must own all directories that it creates. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. Package approved
The Pagure repository was created at https://src.fedoraproject.org/rpms/php-splitbrain-lesserphp
https://bodhi.fedoraproject.org/updates/FEDORA-2025-e927711480