Spec URL: http://rpm.greysector.net/extras/freefem++.spec SRPM URL: http://rpm.greysector.net/extras/freefem++-2.14-1.src.rpm Description: A PDE oriented language using Finite Element Method FreeFem++ is an implementation of a language dedicated to the finite element method. It provides you a way to solve Partial Differential Equations (PDE) simply. Problems involving partial differential equations (pde) of several branches of physics such as fluid-structure interactions require interpolations of data on several meshes and their manipulation within one program. FreeFem++ is an extension of freefem, freefem+ written in C++. Homepage: http://www.freefem.org/ Depends on arpack, which is under review in bug 214967.
I'll review it shortly.
REVIEW: * %{?dist} tag's present * package's licensed under LGPL and license's included in package !* rpmlint output: W: freefem++-glx non-standard-group Applications/Scientific Why don't use Applications/Engineering as in the main package? W: freefem++-glx no-documentation E: freefem++ binary-or-shlib-defines-rpath /usr/bin/FreeFem++-client ['/usr/ lib64'] E: freefem++ binary-or-shlib-defines-rpath /usr/bin/FreeFem++-cs ['/usr/lib64'] E: freefem++ binary-or-shlib-defines-rpath /usr/bin/FreeFem++-ide ['/usr/lib64'] Has to be fixed. Unfortunately, I'm currently unable to check if the way to fix the rpath from PackagingGuidelines works for this package, but it should be checked. W: freefem++ spurious-executable-perm /usr/share/man/man1/FreeFem++.1.gz Change wrong permissions E: freefem++-debuginfo script-without-shebang /usr/src/debug/freefem++-2.14-1/ src/fflib/mt19937ar.cpp E: freefem++-debuginfo script-without-shebang /usr/src/debug/freefem++-2.14-1/ src/lglib/mymain.cpp W: freefem++-mpi non-standard-group Applications/Scientific W: freefem++-mpi no-documentation * md5sums match each other. However, 2.14 is not the newest freefem++'s release so you have to package the newer version * BRs seem to be proper, mock fc6/x86_64 builds fine * final provides and requires are sane * package doesn't create any new directory and it doesn't own any one it shouldn't * %clean section fine * build root's proper !* %files sections don't look good. Manpage has improper permissions. Also, it doesn't seem to me that setting 755 permissions globally is a good solution 'cause it lead up to wrong permissions (as in the manpage case) so I'll suggest to change it * except for Group tag, everything related with subpackages seems good THINGS TO DO: * change subpackages' groups * fix rpath issue * package the newer version * fix permissions of manpage * don't set 755 permissions globally
(In reply to comment #2) > REVIEW: > > * %{?dist} tag's present > * package's licensed under LGPL and license's included in package > !* rpmlint output: > > W: freefem++-glx non-standard-group Applications/Scientific > > Why don't use Applications/Engineering as in the main package? Copy & paste error from an old version. > W: freefem++-glx no-documentation > E: freefem++ binary-or-shlib-defines-rpath /usr/bin/FreeFem++-client ['/usr/ > lib64'] > E: freefem++ binary-or-shlib-defines-rpath /usr/bin/FreeFem++-cs ['/usr/lib64'] > E: freefem++ binary-or-shlib-defines-rpath /usr/bin/FreeFem++-ide ['/usr/lib64'] > > Has to be fixed. Unfortunately, I'm currently unable to check if the way to fix > the rpath from PackagingGuidelines works for this package, but it should be > checked. Can't fix. The bug is in fltk package. See bug 214967. > W: freefem++ spurious-executable-perm /usr/share/man/man1/FreeFem++.1.gz > > Change wrong permissions Will fix. > E: freefem++-debuginfo script-without-shebang /usr/src/debug/freefem++-2.14-1/ > src/fflib/mt19937ar.cpp > E: freefem++-debuginfo script-without-shebang /usr/src/debug/freefem++-2.14-1/ > src/lglib/mymain.cpp Will fix. > W: freefem++-mpi non-standard-group Applications/Scientific > W: freefem++-mpi no-documentation > > * md5sums match each other. However, 2.14 is not the newest freefem++'s > release so you have to package the newer version OK. > * BRs seem to be proper, mock fc6/x86_64 builds fine But devel doesn't. I'm working on this right now.
New SRPM uploaded, fixing all except rpaths. Builds in mock devel/x86_64, too. http://rpm.greysector.net/extras/freefem++-2.16-1.src.rpm http://rpm.greysector.net/extras/freefem++.spec Current rpmlint output: W: freefem++-mpi no-documentation E: freefem++ binary-or-shlib-defines-rpath /usr/bin/FreeFem++-ide ['/usr/lib64'] E: freefem++ binary-or-shlib-defines-rpath /usr/bin/FreeFem++-client ['/usr/lib64'] E: freefem++ binary-or-shlib-defines-rpath /usr/bin/FreeFem++-cs ['/usr/lib64'] W: freefem++-glx no-documentation
(In reply to comment #3) > (In reply to comment #2) > Can't fix. The bug is in fltk package. See bug 214967. I meant bug 238284.
I hope mock works for devel right now (can't check). If so, I'm happy to approve the package.
fltk rpath have been removed, If the rpaths were inherited from fltk, it should work now...
New Package CVS Request ======================= Package Name: freefem++ Short Description: PDE solving tool Owners: rathann Branches: F-7 F-8 EL-5 Cvsextras Commits: yes
cvs done.
Unfortunately this is still blocked because Axel refuses the trivial workaround for the buildsys bug, so I'm rolling my own. But I wanted to see if version 2.23 had been tested, or perhaps if this could at least be imported into the repo even if it can't be built.
Well, arpack is done and in the repository now for rawhide, F7 and F8, so this can finally be built. Any chance of bumping to 2.23 in the process?
Yes, of course.
Thanks! FYI, I just noticed that 2.24-0 is out; I don't know if the changes are significant. Also, I wonder if you have given any thought to freefem3d. I've also received requests for it and so will have to start looking into it soon but if you've already started packaging it then I'd be happy to work with you.
(In reply to comment #13) > Thanks! > > FYI, I just noticed that 2.24-0 is out; I don't know if the changes are > significant. I'm working on making 2.23 build with gcc-4.3 right now. After that's done, I'll see what's new in 2.24. > Also, I wonder if you have given any thought to freefem3d. I've also received > requests for it and so will have to start looking into it soon but if you've > already started packaging it then I'd be happy to work with you. No, I have no plans for freefem3d.
freefem++-2.24-2.fc8 has been submitted as an update for Fedora 8
freefem++-2.24-2.fc7 has been submitted as an update for Fedora 7
freefem++-2.24-2.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report.
freefem++-2.24-2.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report.