Bug 234168 - GFS2's rgrp flags unused
Summary: GFS2's rgrp flags unused
Alias: None
Product: Fedora
Classification: Fedora
Component: GFS-kernel
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Steve Whitehouse
QA Contact:
Depends On:
Blocks: 235346 235931
TreeView+ depends on / blocked
Reported: 2007-03-27 15:33 UTC by Steve Whitehouse
Modified: 2007-11-30 22:12 UTC (History)
1 user (show)

Clone Of:
Last Closed: 2007-04-11 20:16:50 UTC

Attachments (Terms of Use)
Patch to fix this bug (853 bytes, patch)
2007-04-02 09:43 UTC, Steve Whitehouse
no flags Details | Diff

Description Steve Whitehouse 2007-03-27 15:33:32 UTC
GFS2 has a set of rgrp flags defined as part of its on disk format. The most
important of these is: GFS2_RGF_NOALLOC. Currently the gfs2 rgrp code ignores
all of these flags.

We will eventually need to add an interface which allows setting of the flags,
but for now, just making sure that the NOALLOC flag is obeyed correctly is the
priority so that its there for future use.

Ben, CCing you on this one since you've just been working on a bug in a smilar
area of the code.

Comment 1 Steve Whitehouse 2007-04-02 09:43:39 UTC
Created attachment 151411 [details]
Patch to fix this bug

This fixes the bug. Although it doesn't deal with all the flags, I can't
currently see any reasonable use for the data/metadata flag (in fact, due to
the allocation policy of GFS2, its actually a non-inode/inode flag despite its
name). So the only one which is really important here is the "noalloc" flag.

Note You need to log in before you can comment on or make changes to this bug.