Spec URL: https://gitlab.com/-/project/55255464/uploads/3087f3bda07151047739f8f7699a31ba/image-garden.spec SRPM URL: https://gitlab.com/-/project/55255464/uploads/7e973e9f854014d4dc54b9481bb9b4db/image-garden-0.1.1-2.fc42.src.rpm Description: Image Garden downloads, initializes and optionally operates virtual machine images for popular operating systems. All the systems are designed for testing and come configured with well-known username and password, usually matching the name of the system. Fedora Account System Username: zyga Existing review thread on the upstream project: https://gitlab.com/zygoon/image-garden/-/issues/11
Copr build: https://copr.fedorainfracloud.org/coprs/build/8568047 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2341988-image-garden/fedora-rawhide-x86_64/08568047-image-garden/fedora-review/review.txt Found issues: - License file NEWS.license is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Review notes: * Package follows Fedora packaging guidelines * Package builds and installs * Package licensing is correct (ignoring false positive) * No serious issues from rpmlint N.B. as you're upstream, I'd recommend either moving the NEWS.license file to "%license" or dropping the file entirely. It's not particularly useful. PACKAGE APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/image-garden