Bug 2342107 - fedora-welcome assumes Fedora Linux instead of reading the name from os-release
Summary: fedora-welcome assumes Fedora Linux instead of reading the name from os-release
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: 42
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: anaconda-maint
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-01-25 22:47 UTC by Neal Gompa
Modified: 2025-03-06 17:59 UTC (History)
7 users (show)

Fixed In Version: anaconda-43.5-1.fc43
Clone Of:
Environment:
Last Closed: 2025-03-06 17:59:58 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Neal Gompa 2025-01-25 22:47:28 UTC
The fedora-welcome script used to provide the welcome prompt on Fedora GNOME live environments assumes Fedora Linux is the operating system instead of retrieving the name of the operating system from os-release(5).

This is problematic because it makes the application broken for derivatives of Fedora Linux, as it always calls the OS "Fedora".

Reproducible: Always

Comment 1 Martin Kolman 2025-02-04 16:04:50 UTC
Indeed, it seems to be hardcoded:

https://github.com/rhinstaller/anaconda/blob/main/data/liveinst/gnome/fedora-welcome.js#L49

I guess it should not be hard to fix (eq. make it parse os-release) ? We also work more with Javascript lately in the Web UI context.

Comment 2 Neal Gompa 2025-02-22 08:31:55 UTC
(In reply to Martin Kolman from comment #1)
> Indeed, it seems to be hardcoded:
> 
> https://github.com/rhinstaller/anaconda/blob/main/data/liveinst/gnome/fedora-
> welcome.js#L49
> 

There's more than that. There are two more strings to fix.

> I guess it should not be hard to fix (eq. make it parse os-release) ? We
> also work more with Javascript lately in the Web UI context.

Indeed, that's the right approach.

Comment 3 Katerina Koukiou 2025-02-26 12:14:39 UTC
Addressed in https://github.com/rhinstaller/anaconda/pull/6187

Comment 4 Aoife Moloney 2025-02-26 13:48:51 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 42 development cycle.
Changing version to 42.

Comment 5 Fedora Update System 2025-03-06 11:07:04 UTC
FEDORA-2025-e8f2823c9c (anaconda-43.5-1.fc43 and anaconda-webui-26-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-e8f2823c9c

Comment 6 Fedora Update System 2025-03-06 17:59:58 UTC
FEDORA-2025-e8f2823c9c (anaconda-43.5-1.fc43 and anaconda-webui-26-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.