Bug 2342192 - Review Request: rust-triforce-lv2 - Minimum variance distortionless response beamformer for Apple mic arrays
Summary: Review Request: rust-triforce-lv2 - Minimum variance distortionless response ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/triforce-lv2
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-01-27 04:26 UTC by Davide Cavalca
Modified: 2025-02-01 09:49 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-01-27 16:26:21 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2025-01-27 04:26:20 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-triforce-lv2/rust-triforce-lv2.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-triforce-lv2/rust-triforce-lv2-0.1.1-1.fc42.src.rpm

Description:
Minimum variance distortionless response beamformer for Apple mic
arrays.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2025-01-27 04:26:24 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=128517058

Comment 2 Davide Cavalca 2025-01-27 04:28:05 UTC
$ cat rust2rpm.toml 
[package]
extra-files = [
  "%{_libdir}/lv2/triforce.lv2/manifest.ttl",
  "%{_libdir}/lv2/triforce.lv2/triforce.ttl",
  "%{_libdir}/lv2/triforce.lv2/triforce.so",
]

[requires]
build = ["make"]
bin = ["lv2"]

[scripts]
install.post = [
  "%make_install LIBDIR=%{_libdir}"
]

Comment 3 Fedora Review Service 2025-01-27 04:35:50 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8576831
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2342192-rust-triforce-lv2/fedora-rawhide-x86_64/08576831-rust-triforce-lv2/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Neal Gompa 2025-01-27 14:43:21 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import tasks:

- set up package on release-monitoring.org:

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- add @asahi-sig with "admin" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 5 Fedora Admin user for bugzilla script actions 2025-01-27 16:07:48 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-triforce-lv2

Comment 6 Fedora Update System 2025-01-27 16:22:07 UTC
FEDORA-2025-444c9b970d (rust-triforce-lv2-0.1.1-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-444c9b970d

Comment 7 Fedora Update System 2025-01-27 16:26:21 UTC
FEDORA-2025-444c9b970d (rust-triforce-lv2-0.1.1-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fabio Valentini 2025-02-01 00:35:59 UTC
Would it have made sense to rename the binary package here to lv2-triforce too, similar to what was done here?
https://src.fedoraproject.org/rpms/rust-bankstown-lv2/blob/rawhide/f/rust-bankstown-lv2.spec#_27

Comment 9 Davide Cavalca 2025-02-01 09:49:28 UTC
Good catch, put up https://src.fedoraproject.org/rpms/rust-triforce-lv2/pull-request/1 for that


Note You need to log in before you can comment on or make changes to this bug.