Bug 2342289 - Review Request: wsl-setup - Windows Subsystem for Linux setup script and configuration
Summary: Review Request: wsl-setup - Windows Subsystem for Linux setup script and conf...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://src.fedoraproject.org/rpms/ws...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-01-27 16:28 UTC by Jeremy Cline
Modified: 2025-06-13 20:18 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-06-13 20:18:31 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Jeremy Cline 2025-01-27 16:28:22 UTC
Spec URL: https://jcline.fedorapeople.org/new-packages/wsl-setup.spec
SRPM URL: https://jcline.fedorapeople.org/new-packages/wsl-setup-1.0.0-1.fc42.src.rpm
Description: Provides WSL specific configuration files and first-time setup script.
Fedora Account System Username: jcline

Comment 1 Fedora Review Service 2025-01-27 16:31:35 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8578275
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2342289-wsl-setup/fedora-rawhide-x86_64/08578275-wsl-setup/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Neal Gompa 2025-01-27 16:38:28 UTC
Review notes:

* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correct and license data is installed
* No serious issues from rpmlint

Comment 3 Fedora Admin user for bugzilla script actions 2025-01-27 16:55:32 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/wsl-setup

Comment 4 Zbigniew Jędrzejewski-Szmek 2025-01-28 08:56:22 UTC
%global is preferred over %define.

Comment 5 Jeremy Cline 2025-01-28 16:37:55 UTC
(In reply to Zbigniew Jędrzejewski-Szmek from comment #4)
> %global is preferred over %define.

Thanks for the review! Fixed in https://src.fedoraproject.org/rpms/wsl-setup/pull-request/1

Comment 6 Neal Gompa 2025-06-13 20:18:31 UTC
Released in F42+.


Note You need to log in before you can comment on or make changes to this bug.