Spec URL: https://skim.cz/tmp/perl-Text-Trim/perl-Text-Trim.spec SRPM URL: https://skim.cz/tmp/perl-Text-Trim/perl-Text-Trim-1.04-1.fc42.src.rpm Description: This module provides functions for removing leading and/or trailing whitespace from strings. It is basically a wrapper around some simple regexes with a flexible context-based interface. Fedora Account System Username: mspacek
There seems to be some problem with the following file. SRPM URL: https://skim.cz/tmp/perl-Text-Trim/perl-Text-Trim-1.04-1.fc42.src.rpm Fetching it results in a 404 Not Found error. Please make sure the URL is correct and publicly available. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
The URL was fixed.
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/8584969 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2342788-perl-text-trim/fedora-rawhide-x86_64/08584969-perl-Text-Trim/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
This is dependency for Catmandu framework.
Swap you for a review of https://bugzilla.redhat.com/show_bug.cgi?id=2360688 ?
- Use https scheme for Source0 - BR: coreutils for _fixperms macro. - Use narrower scope in %files: %{perl_vendorlib}/Text/ %{_mandir}/man3/Text::Trim.3pm* - rpmlint reports an incorrect FSF address in LICENSE - Spec file is not the same as in SRPM. Removal of a commented out line, this can be ignored.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 1 and/or The Perl 5 License", "*No copyright* The Perl 5 License". 12 files have unknown license. Detailed output of licensecheck in /tmp/2342788-perl-Text-Trim/licensecheck.txt [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/perl5/vendor_perl/Text(perl-Text-PDF, perl-Text-vCard, perl-Text-Textile, perl-Text-Tree, perl-Text-SimpleTable-AutoWidth, perl-Text-Table-Tiny, perl-Text-TabularDisplay, perl-Text-Template- Simple, perl-Text-Autoformat, perl-Text-Brew, perl-Text-vFile-asData, perl-Text-Lorem, perl-Text-Roman, perl-Text-Format, perl-Text- Markdown, perl-Text-Glob, perl-Text-VimColor, perl-Text-Unidecode, perl-Text-Aligner, perl-Text-Diff-HTML, perl-Text-SpellChecker, perl- Text-Emoticon-MSN, perl-Text-WordDiff, perl-Text-WikiFormat, perl- Text-Layout, perl-Text-MultiMarkdown, perl-Text-Quoted, perl-Text- Levenshtein, perl-Text-Balanced, perl-Text-Reform, perl-Text-Template, perl-Text-xSV, perl-Text-Clip, linuxdoc-tools, perl-Text-Password- Pronounceable, perl-Text-Context, perl-Text-ParseWords, perl-Text- Emoticon, perl-Text-Patch, perl-Text-Wrapper, perl-Text-RecordParser, perl-Text-CSV, perl-Text-FindIndent, perl-Text-CSV-Separator, perl- Text-SimpleTable, perl-perlindex, perl-Text-Context-EitherSide, perl- Text-Diff-Parser, perl-Text-FormatTable, perl-Text-Shellwords, perl- Text-Affixes, perl-Text-Haml, perl-Text-Table, perl-Text-Tabs+Wrap, perl-Text-Sprintf-Named, perl-Text-WrapI18N, perl-Text-Diff, perl- Text-German, perl-Text-WagnerFischer, perl-Text-ASCIITable, perl-Text- Levenshtein-Damerau, perl-Term-ShellUI) [-]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 8947 bytes in 3 files. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [x]: Package contains the mandatory BuildRequires and Requires:. [x]: CPAN urls should be non-versioned. ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: perl-Text-Trim-1.04-1.fc43.noarch.rpm perl-Text-Trim-1.04-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpevs7elju')] checks: 32, packages: 2 perl-Text-Trim.noarch: E: spelling-error ('whitespace', 'Summary(en_US) whitespace -> white space, white-space, whites pace') perl-Text-Trim.noarch: E: spelling-error ('whitespace', '%description -l en_US whitespace -> white space, white-space, whites pace') perl-Text-Trim.noarch: E: spelling-error ('regexes', "%description -l en_US regexes -> regex's, regexps, reg exes") perl-Text-Trim.src: E: spelling-error ('whitespace', 'Summary(en_US) whitespace -> white space, white-space, whites pace') perl-Text-Trim.src: E: spelling-error ('whitespace', '%description -l en_US whitespace -> white space, white-space, whites pace') perl-Text-Trim.src: E: spelling-error ('regexes', "%description -l en_US regexes -> regex's, regexps, reg exes") perl-Text-Trim.noarch: E: incorrect-fsf-address /usr/share/licenses/perl-Text-Trim/LICENSE 2 packages and 0 specfiles checked; 7 errors, 0 warnings, 7 filtered, 7 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 perl-Text-Trim.noarch: E: spelling-error ('whitespace', 'Summary(en_US) whitespace -> white space, white-space, whites pace') perl-Text-Trim.noarch: E: spelling-error ('whitespace', '%description -l en_US whitespace -> white space, white-space, whites pace') perl-Text-Trim.noarch: E: spelling-error ('regexes', "%description -l en_US regexes -> regexps, regex's, reg exes") perl-Text-Trim.noarch: E: incorrect-fsf-address /usr/share/licenses/perl-Text-Trim/LICENSE 1 packages and 0 specfiles checked; 4 errors, 0 warnings, 3 filtered, 4 badness; has taken 0.1 s Source checksums ---------------- http://www.cpan.org/modules/by-module/Text/Text-Trim-1.04.tar.gz : CHECKSUM(SHA256) this package : d5878a9079d33cd1766cf6abc44cd625bd00a0213d2ce8e3143fe6944abaaa11 CHECKSUM(SHA256) upstream package : d5878a9079d33cd1766cf6abc44cd625bd00a0213d2ce8e3143fe6944abaaa11 Requires -------- perl-Text-Trim (rpmlib, GLIBC filtered): perl(Exporter) perl(strict) perl(warnings) perl-libs Provides -------- perl-Text-Trim: perl(Text::Trim) perl-Text-Trim Diff spec file in url and in SRPM --------------------------------- --- /tmp/2342788-perl-Text-Trim/srpm/perl-Text-Trim.spec 2025-06-03 12:54:56.970342405 +0200 +++ /tmp/2342788-perl-Text-Trim/srpm-unpacked/perl-Text-Trim.spec 2025-01-29 01:00:00.000000000 +0100 @@ -15,5 +15,5 @@ BuildRequires: perl(Exporter) # Tests -BuildRequires: perl(File::Spec::Functions) +#BuildRequires: perl(File::Spec::Functions) BuildRequires: perl(Test::More) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2342788 Buildroot used: fedora-rawhide-x86_64 Active plugins: Perl, Generic, Shell-api Disabled plugins: SugarActivity, R, Haskell, Ocaml, fonts, Java, C/C++, PHP, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Apart from the nitpicks above, LGTM. Please fix before import. Package is APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Text-Trim