Bug 2342799 - Review Request: rust-trustfall_derive - Derive macros for the trustfall query engine
Summary: Review Request: rust-trustfall_derive - Derive macros for the trustfall query...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/trustfall_de...
Whiteboard:
Depends On:
Blocks: 2489111
TreeView+ depends on / blocked
 
Reported: 2025-01-29 13:58 UTC by Michel Lind
Modified: 2026-06-24 01:32 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2026-06-15 15:22:18 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2025-01-29 13:58:19 UTC
Spec URL: https://salimma.fedorapeople.org/rust-trustfall_derive.spec
SRPM URL: https://salimma.fedorapeople.org/rust-trustfall_derive-0.3.1-1.fc41.src.rpm

Description:
Derive macros for the trustfall query engine.

Fedora Account System Username: salimma

Comment 1 Michel Lind 2025-01-29 13:58:22 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=128607847

Comment 2 Fedora Review Service 2025-01-29 14:03:14 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8584365
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2342799-rust-trustfall_derive/fedora-rawhide-x86_64/08584365-rust-trustfall_derive/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Fabio Valentini 2025-03-14 17:24:45 UTC
Looks good to me!

Note that you can automate even more with rust2rpm.toml:

```
[package]
license-files = ["LICENSE.txt"]

[[package.extra-sources]]
number = 1
file = "https://raw.githubusercontent.com/obi1kenobi/trustfall/refs/tags/trustfall-v0.8.0/LICENSE.txt"
comments = ["add license: https://github.com/obi1kenobi/trustfall/pull/734"]

[scripts]
prep.post = ["cp -p %{SOURCE1} ."]
```

Explicitly telling rust2rpm that there is indeed a license file (with a non-empty "package.license-files" setting also gets you past the "no license files detected" error without needing to pass "--ignore-missing-license-files". :)

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
🫤 test suite is run and all unit tests pass (disabled with good justification)
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
🫤 license file is included with %license in %files (included manually, fix submitted to upstream)
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 5 Fabio Valentini 2026-03-13 21:53:42 UTC
Are you still interested in this package?

Comment 6 Michel Lind 2026-03-13 22:01:11 UTC
Hmm, trying to remember what this was for. I think it will be nice to have git-seek, which ultimately depends on this, so yes please, if you could re-set the + I will import this.

Comment 7 Fabio Valentini 2026-03-14 15:54:35 UTC
It was for cargo-semver-checks. I've renewed the + flag.

Comment 8 Fabio Valentini 2026-04-29 14:37:47 UTC
*ping*

It's now been over a year since the initial approval. If you're really not that interested any more, please just close the ticket.

Comment 9 Fedora Admin user for bugzilla script actions 2026-06-15 14:35:23 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-trustfall_derive
Monitoring:
Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`

Comment 10 Michel Lind 2026-06-15 14:47:58 UTC
Sorry for the delay! Building now, and looks like upstream has merged the PR but not cut a release so hopefully we don't have to keep patching for much longer

Comment 11 Fedora Update System 2026-06-15 15:02:01 UTC
FEDORA-2026-a59f05c968 (rust-trustfall_derive-0.3.1-1.fc45) has been submitted as an update to Fedora 45.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-a59f05c968

Comment 12 Fedora Update System 2026-06-15 15:22:18 UTC
FEDORA-2026-a59f05c968 (rust-trustfall_derive-0.3.1-1.fc45) has been pushed to the Fedora 45 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2026-06-15 16:30:12 UTC
FEDORA-2026-7fb0d2d45b (rust-trustfall_derive-0.3.1-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-7fb0d2d45b

Comment 14 Fedora Update System 2026-06-15 16:30:13 UTC
FEDORA-2026-f4dcecaee9 (rust-trustfall_derive-0.3.1-1.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-f4dcecaee9

Comment 15 Fedora Update System 2026-06-16 01:30:37 UTC
FEDORA-2026-f4dcecaee9 has been pushed to the Fedora 44 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-f4dcecaee9 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-f4dcecaee9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 16 Fedora Update System 2026-06-16 01:52:31 UTC
FEDORA-2026-7fb0d2d45b has been pushed to the Fedora 43 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-7fb0d2d45b \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-7fb0d2d45b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 17 Fedora Update System 2026-06-24 01:29:36 UTC
FEDORA-2026-f4dcecaee9 (rust-trustfall_derive-0.3.1-1.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 18 Fedora Update System 2026-06-24 01:32:46 UTC
FEDORA-2026-7fb0d2d45b (rust-trustfall_derive-0.3.1-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.