Spec URL: https://salimma.fedorapeople.org/rust-trustfall_derive.spec SRPM URL: https://salimma.fedorapeople.org/rust-trustfall_derive-0.3.1-1.fc41.src.rpm Description: Derive macros for the trustfall query engine. Fedora Account System Username: salimma
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=128607847
Copr build: https://copr.fedorainfracloud.org/coprs/build/8584365 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2342799-rust-trustfall_derive/fedora-rawhide-x86_64/08584365-rust-trustfall_derive/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
rust2rpm.toml: https://pagure.io/michel-slm/specs-for-review/blob/main/f/rust-trustfall_derive/rust2rpm.toml
Looks good to me! Note that you can automate even more with rust2rpm.toml: ``` [package] license-files = ["LICENSE.txt"] [[package.extra-sources]] number = 1 file = "https://raw.githubusercontent.com/obi1kenobi/trustfall/refs/tags/trustfall-v0.8.0/LICENSE.txt" comments = ["add license: https://github.com/obi1kenobi/trustfall/pull/734"] [scripts] prep.post = ["cp -p %{SOURCE1} ."] ``` Explicitly telling rust2rpm that there is indeed a license file (with a non-empty "package.license-files" setting also gets you past the "no license files detected" error without needing to pass "--ignore-missing-license-files". :) === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide 🫤 test suite is run and all unit tests pass (disabled with good justification) ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora 🫤 license file is included with %license in %files (included manually, fix submitted to upstream) ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
Are you still interested in this package?
Hmm, trying to remember what this was for. I think it will be nice to have git-seek, which ultimately depends on this, so yes please, if you could re-set the + I will import this.
It was for cargo-semver-checks. I've renewed the + flag.