Bug 2342936 - Review Request: rust-tree-sitter-c - C grammar for tree-sitter
Summary: Review Request: rust-tree-sitter-c - C grammar for tree-sitter
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Davide Cavalca
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/tree-sitter-c
Whiteboard:
Depends On:
Blocks: 2333626
TreeView+ depends on / blocked
 
Reported: 2025-01-30 10:27 UTC by Michel Lind
Modified: 2025-03-15 00:28 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-02-21 00:23:47 UTC
Type: ---
Embargoed:
davide: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2025-01-30 10:27:54 UTC
Spec URL: https://salimma.fedorapeople.org/rust-tree-sitter-c.spec
SRPM URL: https://salimma.fedorapeople.org/rust-tree-sitter-c-0.23.4-1.fc42.src.rpm

Description:
C grammar for tree-sitter.

Fedora Account System Username: salimma

Comment 1 Michel Lind 2025-01-30 10:27:57 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=128647104

Comment 3 Fedora Review Service 2025-01-30 18:07:26 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8587792
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2342936-rust-tree-sitter-c/fedora-rawhide-x86_64/08587792-rust-tree-sitter-c/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Davide Cavalca 2025-02-20 18:35:44 UTC
# copy in license file
cp -p %{SOURCE1} .

You should add this to rust2rpm.toml too (in scripts -> prep.post)

Comment 5 Davide Cavalca 2025-02-20 18:41:25 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 6 Fedora Admin user for bugzilla script actions 2025-02-20 23:28:56 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-tree-sitter-c

Comment 7 Fedora Update System 2025-02-21 00:12:03 UTC
FEDORA-2025-4c8da35483 (rust-tree-sitter-c-0.23.4-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-4c8da35483

Comment 8 Fedora Update System 2025-02-21 00:23:47 UTC
FEDORA-2025-4c8da35483 (rust-tree-sitter-c-0.23.4-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2025-02-21 17:56:57 UTC
FEDORA-2025-641150a4e9 (rust-tree-sitter-c-0.23.4-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-641150a4e9

Comment 10 Fedora Update System 2025-02-21 17:56:57 UTC
FEDORA-2025-17b4f01a11 (rust-tree-sitter-c-0.23.4-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-17b4f01a11

Comment 11 Fedora Update System 2025-02-22 02:27:09 UTC
FEDORA-2025-641150a4e9 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-641150a4e9 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-641150a4e9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2025-02-22 02:49:27 UTC
FEDORA-2025-17b4f01a11 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-17b4f01a11 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-17b4f01a11

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2025-02-22 03:17:50 UTC
FEDORA-2025-c20bd64f0a has been pushed to the Fedora 42 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-c20bd64f0a \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-c20bd64f0a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2025-03-02 02:19:17 UTC
FEDORA-2025-641150a4e9 (rust-tree-sitter-c-0.23.4-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2025-03-02 02:48:55 UTC
FEDORA-2025-17b4f01a11 (rust-tree-sitter-c-0.23.4-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2025-03-15 00:28:01 UTC
FEDORA-2025-c20bd64f0a (rust-tree-sitter-c-0.23.4-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.