Bug 234351 - %include should be able to grab URLs
%include should be able to grab URLs
Status: CLOSED NEXTRELEASE
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: pykickstart (Show other bugs)
5.0
All Linux
medium Severity low
: ---
: ---
Assigned To: Chris Lumens
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-03-28 13:14 EDT by Ryan Tilder
Modified: 2007-11-30 17:07 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-03-30 16:00:08 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
use urlgrabber.grabber.urlopen() to open %include files (514 bytes, patch)
2007-03-28 13:14 EDT, Ryan Tilder
no flags Details | Diff
use urlgrabber.grabber.urlopen() to open all kickstart config files so that %include URLs can happen (1.12 KB, patch)
2007-03-28 13:32 EDT, Ryan Tilder
no flags Details | Diff

  None (edit)
Description Ryan Tilder 2007-03-28 13:14:42 EDT
Description of problem:

%include would be much more useful if I didn't have to rely on only items
accessable via the local file system

Version-Release number of selected component (if applicable):

pykickstart0.43

Simple patch attached to change readKickstart()'s call to open() to use
urlgrabber.grabber.urlopen()
Comment 1 Ryan Tilder 2007-03-28 13:14:42 EDT
Created attachment 151136 [details]
use urlgrabber.grabber.urlopen() to open %include files
Comment 2 Ryan Tilder 2007-03-28 13:32:35 EDT
Created attachment 151138 [details]
use urlgrabber.grabber.urlopen() to open all kickstart config files so that %include URLs can happen

Slightly updated patch.

anaconda-11.1.2.36/kickstart.py doesn't catch IOError when calling
readKickstart(), making for not so pretty exception and exit when a %include
file is missing.  This way the interface can handle it as gracefully as
possible.
Comment 3 Chris Lumens 2007-03-30 16:00:08 EDT
This will be in the next build of pykickstart in rawhide, which means that it
will eventually be in the next release of RHEL.  If you'd like this feature
included in an update to RHEL5, please go through your support representative
who will raise the issue through the appropriate channels.  Thanks for the
feature request.

As for handling IOError, I'd prefer anaconda handle that correctly instead of
doing anything in pykickstart, so I've beefed up the error handling there instead.
Comment 4 Levente Farkas 2007-06-21 05:53:19 EDT
is there any other way to vote for this extension? it's simple clear patch and
would be very useful?

Note You need to log in before you can comment on or make changes to this bug.