spec: https://fed500.fedorapeople.org/python-proton-vpn-network-manager.spec srpm: https://fed500.fedorapeople.org/python-proton-vpn-network-manager-0.10.2-1.fc42.src.rpm description: The proton-vpn-network-manager component provides the necessary functionality for other components to interact with NetworkManager. fas: fed500 Open issue to block name on pypi: https://github.com/ProtonVPN/python-proton-vpn-network-manager/issues/4 Reproducible: Always
Copr build: https://copr.fedorainfracloud.org/coprs/build/8602321 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2343583-python-proton-vpn-network-manager/fedora-rawhide-x86_64/08602321-python-proton-vpn-network-manager/fedora-review/review.txt Found issues: - python3-pytest7 is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package must not depend on deprecated() packages. Note: python3-pytest7 is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU General Public License, Version 3", "GNU General Public License, Version 3", "GNU General Public License v3.0 or later", "*No copyright* GNU General Public License v3.0 or later". 17 files have unknown license. Detailed output of licensecheck in /review/2343583-python-proton-vpn-network- manager/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.13, /usr/lib/python3.13/site-packages [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/python3.13/site- packages/proton(python3-proton-vpn-api-core, python3-proton-core), /usr/lib/python3.13/site-packages/proton/vpn(python3-proton-vpn-api- core) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 2163 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: python3-proton-vpn-network-manager-0.10.2-1.fc43.noarch.rpm python-proton-vpn-network-manager-0.10.2-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpfv4dslm_')] checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 12 filtered, 0 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 3 filtered, 0 badness; has taken 0.1 s Source checksums ---------------- https://github.com/ProtonVPN/python-proton-vpn-network-manager/archive/v0.10.2/python-proton-vpn-network-manager-0.10.2.tar.gz : CHECKSUM(SHA256) this package : bef9002a9ee244d6c7e2fc14fc211fc4f9fecee3c807cda213391a3d0c89966d CHECKSUM(SHA256) upstream package : bef9002a9ee244d6c7e2fc14fc211fc4f9fecee3c807cda213391a3d0c89966d Requires -------- python3-proton-vpn-network-manager (rpmlib, GLIBC filtered): python(abi) python3.13dist(packaging) python3.13dist(proton-core) python3.13dist(proton-vpn-api-core) python3.13dist(pycairo) python3.13dist(pygobject) Provides -------- python3-proton-vpn-network-manager: python-proton-vpn-network-manager python3-proton-vpn-network-manager python3.13-proton-vpn-network-manager python3.13dist(proton-vpn-network-manager) python3dist(proton-vpn-network-manager) Diff spec file in url and in SRPM --------------------------------- --- /review/2343583-python-proton-vpn-network-manager/srpm/python-proton-vpn-network-manager.spec 2025-02-22 08:30:41.261714596 +0000 +++ /review/2343583-python-proton-vpn-network-manager/srpm-unpacked/python-proton-vpn-network-manager.spec 2025-02-03 00:00:00.000000000 +0000 @@ -1,2 +1,12 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.7.3) +## RPMAUTOSPEC: autorelease, autochangelog +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} +## END: Set by rpmautospec + %global srcname python-proton-vpn-network-manager %global shortname proton-vpn-network-manager @@ -69,3 +79,6 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Mon Feb 03 2025 John Doe <packager> - 0.10.2-1 +- Uncommitted changes +## END: Generated by rpmautospec Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2343583 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, Python Disabled plugins: C/C++, SugarActivity, Haskell, R, fonts, Ocaml, PHP, Java, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Just a note: there's an updated tag available upstream. Perhaps, it could worth managing all proton stack under a proton-sig, like we do in libreoffice-sig https://fedoraproject.org/wiki/SIGs/Libreoffice ? Package APPROVED.
Thanks for the review. Will update when importing. Improvements to: https://fedoraproject.org/wiki/SIGs/Proton are welcome, can follow up with a mail on fedora-devel as per: https://fedoraproject.org/wiki/Creating_a_Fedora_SIG
(In reply to Benson Muite from comment #4) > Thanks for the review. Will update when importing. > > Improvements to: > https://fedoraproject.org/wiki/SIGs/Proton > are welcome, can follow up with a mail on fedora-devel as per: > https://fedoraproject.org/wiki/Creating_a_Fedora_SIG Looks good. Having the default bugzilla assignee set to a proton-sig mailing list will ensure all sig members have visibility on bugs. Maybe before the mail to the devel list, it should be discussed with jflory7 and calexandru2018 which are the current SIG members.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-proton-vpn-network-manager
We have already created a sig here: https://src.fedoraproject.org/group/proton-sig, I guess we didn't have the page yet.
Thanks.
Can you push the package to the repos, so that we can close the review?
FEDORA-2025-eab96b8ab0 (python-proton-vpn-network-manager-0.10.2-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-eab96b8ab0
https://release-monitoring.org/project/369947/ Done. Have not updated to the latest release as it requires a new dependency: https://github.com/ProtonVPN/local-agent-rs
(In reply to Benson Muite from comment #11) > https://release-monitoring.org/project/369947/ > > Done. Have not updated to the latest release as it requires a new dependency: > https://github.com/ProtonVPN/local-agent-rs Ugh, what a packaging nightmare... the rust crate and the python module in the same repo, using relative path dependencies... :-( It would be so much easier if Proton were to publish rust crates and python packages into crates.io/pypi.org (which would also have the benefit to "lock" the package names in the respective ecosystems).
FEDORA-2025-eab96b8ab0 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-eab96b8ab0 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-eab96b8ab0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-eab96b8ab0 (python-proton-vpn-network-manager-0.10.2-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.