Red Hat Bugzilla – Bug 234454
Review Request: perl-PostScript - PostScript Perl module
Last modified: 2007-11-30 17:12:00 EST
Spec URL: http://allele5.biol.berkeley.edu/~alex/fedora/perl-PostScript.spec SRPM URL: http://allele5.biol.berkeley.edu/~alex/fedora/perl-PostScript-0.06-1.src.rpm Description: Perl package that generates PostScript files.
License is described in TextBlock.pm: Copyright 1998, 1999 Shawn Wallace. All rights reserved. Contact the author: shawn@as220.org http://www.as220.org/shawn Portions of code contributed by Dan Smeltz. This is free software. You may use, modify, and redistribute this package under the same terms as Perl itself.
Looks good :) + source files match upstream: 2a91cc23f2d8958e063f7ff09163faa0 PostScript-0.06.tar.gz 2a91cc23f2d8958e063f7ff09163faa0 ../PostScript-0.06.tar.gz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license. + license is open source-compatible. License text not included upstream. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package installs properly O no debuginfo package -- noarch + rpmlint is silent. + final provides and requires are sane: ** perl-PostScript-0.06-1.fc6.noarch.rpm == rpmlint == provides perl(PostScript::Document) = 0.06 perl(PostScript::Elements) perl(PostScript::Metrics) = 0.06 perl(PostScript::TextBlock) = 0.06 perl-PostScript = 0.06-1.fc6 == requires perl(:MODULE_COMPAT_5.8.8) perl(PostScript::Metrics) perl(PostScript::TextBlock) perl(strict) perl(vars) O %check is present -- no tests defined, however + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no scriptlets present. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. + no headers. + no pkgconfig files. + no libtool .la droppings. + not a GUI app. APPROVED
New Package CVS Request ======================= Package Name: perl-PostScript Short Description: Perl package that generates PostScript files. Owners: alexl@users.sourceforge.net Branches: FC-5 FC-6 InitialCC:
Builds in all branches. Closing.