Spec URL: http://allele5.biol.berkeley.edu/~alex/fedora/perl-perl-Bio-ASN1-EntrezGene.spec SRPM URL: http://allele5.biol.berkeley.edu/~alex/fedora/perl-Bio-ASN1-EntrezGene-1.091-1.src.rpm Description: Bio::ASN1::EntrezGene is a regular expression-based Perl Parser for NCBI Entrez Gene genome databases (http://www.ncbi.nih.gov/entrez/query.fcgi?db=gene). It parses an ASN.1- formatted Entrez Gene record and returns a data structure that contains all data items from the gene record. The tests are disabled because this package has a circular BuildRequires with perl-bioperl (also in packaging) and also has an install-time Requires dependency with perl-bioperl.
Correct spec URL: http://allele5.biol.berkeley.edu/~alex/fedora/perl-Bio-ASN1-EntrezGene.spec
License from README: Written and maintained by Dr. Mingyi Liu <mingyi.liu>. Copyright (c) 2005 Mingyi Liu, GPC Biotech, Altana Research Institute. All rights reserved. This program is free software - you can redistribute it and/or modify it under the same terms as Perl itself.
Before I launch into a full review, a couple comments. A stylistic comment -- if you use %setup -q -n Bio-ASN1-EntrezGene-%{version} vs %setup -q -n Bio-ASN1-EntrezGene-1.09 in %prep, you won't have to manually change the version in two places whenever a new version is released. (Not that this seems to happen frequently, but...) There appears to be an examples directory, why not include it? :)
So its upstream mistake to tar Bio-ASN1-EntrezGene-1.09 as Bio-ASN1-EntreZGene-1.091.tar.gz
Sorry Chris for picking this for review as I want to review perl-bioperl I need this to be reviewed.
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url fabb888e03435007e08050def1aed0ac Bio-ASN1-EntrezGene-1.091.tgz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test disabled for circular BR on perl-bioperl + Provides: perl(Bio::ASN1::EntrezGene) = 1.09 perl(Bio::ASN1::EntrezGene::Indexer) = 1.09 perl(Bio::ASN1::Sequence) = 1.09 perl(Bio::ASN1::Sequence::Indexer) = 1.09 APPROVED.
1. As noted by Parag, upstream made a mistake. 2. I added examples subdirectory. Spec URL: http://allele5.biol.berkeley.edu/~alex/fedora/perl-perl-Bio-ASN1-EntrezGene.spec SRPM URL: http://allele5.biol.berkeley.edu/~alex/fedora/perl-Bio-ASN1-EntrezGene-1.091-2.src.rpm
thanks for adding examples directory
New Package CVS Request ======================= Package Name: perl-Bio-ASN1-EntrezGene Short Description: Regular expression-based Perl Parser for NCBI Entrez Gene Owners: alexl.net Branches: FC-5 FC-6 InitialCC:
Just had a look at new SRPM and it looks OK to me. Re-Approving new package perl-Bio-ASN1-EntrezGene-1.091-2.src.rpm
done
Builds fine in all branches. Closing.
Can you please test new packages only in "devel" and build them for the stable branches some time later? This one has unresolved dependencies (for FC-5, FC-6 and devel).