Bug 2345948 - Review Request: rust-binfmt-dispatcher - Smart dispatcher for binfmt_misc
Summary: Review Request: rust-binfmt-dispatcher - Smart dispatcher for binfmt_misc
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-02-15 23:49 UTC by Davide Cavalca
Modified: 2025-03-27 18:26 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-02-16 00:07:41 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2025-02-15 23:49:55 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-binfmt-dispatcher/rust-binfmt-dispatcher.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-binfmt-dispatcher/rust-binfmt-dispatcher-0.1.0-1.fc43.src.rpm

Description:
binfmt-dispatcher is a simple dispatcher for binfmt_misc that dynamically picks the best interpreter to use at runtime.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2025-02-15 23:49:58 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=129280489

Comment 2 Fedora Review Service 2025-02-15 23:50:20 UTC
There seems to be some problem with the following file.
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-binfmt-dispatcher/rust-binfmt-dispatcher-0.1.0-1.fc43.src.rpm
Fetching it results in a 403 Forbidden error.
Please make sure the URL is correct and publicly available.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Davide Cavalca 2025-02-15 23:52:37 UTC
$ cat rust2rpm.toml 
[package]
description = "binfmt-dispatcher is a simple dispatcher for binfmt_misc that dynamically picks the best interpreter to use at runtime."
extra-files = [
  "%doc docs/binfmt-dispatcher.toml.example",
  "%dir %{_prefix}/lib/binfmt-dispatcher.d/",
  "%ifnarch %{ix86} %{x86_64}",
  "%{_binfmtdir}/zz-binfmt-dispatcher-*.conf",
  "%{_prefix}/lib/binfmt-dispatcher.d/*.toml",
  "%endif",
  "%{_datadir}/polkit-1/actions/org.AsahiLinux.binfmt_dispatcher.policy",
  "%config(noreplace) %ghost %{_sysconfdir}/binfmt-dispatcher.toml",
]

[requires]
build = [
  "make",
  "systemd-rpm-macros",
]
bin = [
  "polkit",
  "systemd",
]

[scripts]
install.post = [
  "make install-data DESTDIR=\"%{buildroot}\"",
  "install -Ddpm0755 %{buildroot}%{_prefix}/lib/binfmt-dispatcher.d",
  "%ifarch %{ix86} %{x86_64}",
  # Do not install any default config on x86
  "rm %{buildroot}%{_binfmtdir}/binfmt-dispatcher-*.conf",
  "rm %{buildroot}%{_sysconfdir}/binfmt-dispatcher.toml",
  "%else",
  # Prefix zz- to the binfmt.d configs to ensure they take precendence.
  "for f in %{buildroot}%{_binfmtdir}/binfmt-dispatcher-*.conf; do mv \"$f\" \"$(dirname \"$f\")/zz-$(basename \"$f\")\"; done",
  # Relocate the default config to /usr
  "mv %{buildroot}%{_sysconfdir}/binfmt-dispatcher.toml %{buildroot}%{_prefix}/lib/binfmt-dispatcher.d/00-default.toml",
  "%endif",
]

Comment 4 Davide Cavalca 2025-02-15 23:53:02 UTC
Permissions on fedorapeople were wrong for some reason, fixed that manually.

[fedora-review-service-build]

Comment 5 Neal Gompa 2025-02-15 23:53:40 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import tasks:

- set up package on release-monitoring.org:

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- add @asahi-sig with "admin" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 6 Fedora Admin user for bugzilla script actions 2025-02-15 23:54:27 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-binfmt-dispatcher

Comment 7 Fedora Update System 2025-02-16 00:03:46 UTC
FEDORA-2025-92b24d63fc (rust-binfmt-dispatcher-0.1.0-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-92b24d63fc

Comment 8 Fedora Update System 2025-02-16 00:06:44 UTC
FEDORA-2025-77f7ab4e93 (rust-binfmt-dispatcher-0.1.0-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-77f7ab4e93

Comment 9 Fedora Update System 2025-02-16 00:07:41 UTC
FEDORA-2025-92b24d63fc (rust-binfmt-dispatcher-0.1.0-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2025-02-16 00:10:42 UTC
FEDORA-2025-77f7ab4e93 (rust-binfmt-dispatcher-0.1.0-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2025-02-16 00:28:09 UTC
FEDORA-2025-4077eb041a (rust-binfmt-dispatcher-0.1.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-4077eb041a

Comment 12 Fedora Update System 2025-02-16 00:52:54 UTC
FEDORA-2025-63390563f3 (rust-binfmt-dispatcher-0.1.0-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-63390563f3

Comment 13 Fedora Update System 2025-02-17 01:16:27 UTC
FEDORA-2025-4077eb041a (rust-binfmt-dispatcher-0.1.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2025-02-17 01:28:10 UTC
FEDORA-2025-63390563f3 (rust-binfmt-dispatcher-0.1.0-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.