Bug 2345961 - Review Request: browserpass - Native messaging host
Summary: Review Request: browserpass - Native messaging host
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neel Chauhan
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 2251506 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-02-16 09:44 UTC by wojnilowicz
Modified: 2025-03-03 18:23 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-03-03 18:23:52 UTC
Type: ---
Embargoed:
neel: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 8660870 to 8660900 (1.04 KB, patch)
2025-02-16 10:26 UTC, Fedora Review Service
no flags Details | Diff

Description wojnilowicz 2025-02-16 09:44:51 UTC
Spec URL: https://wojnilowicz.fedorapeople.org/browserpass.spec
SRPM URL: https://wojnilowicz.fedorapeople.org/browserpass-3.1.0-1.fc41.src.rpm

Description:
                             This is a host application for browserpass browser extension providing it access to your password store.
                             The communication is handled through Native Messaging API.

Fedora Account System Username: wojnilowicz

Comment 1 wojnilowicz 2025-02-16 09:46:21 UTC
*** Bug 2251506 has been marked as a duplicate of this bug. ***

Comment 2 Fedora Review Service 2025-02-16 09:53:02 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8660870
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2345961-browserpass/fedora-rawhide-x86_64/08660870-browserpass/fedora-review/review.txt

Found issues:

- %config /usr/lib64/mozilla/native-messaging-hosts/com.github.browserpass.native.json
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_configuration_files

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 wojnilowicz 2025-02-16 10:19:20 UTC
[fedora-review-service-build]

Comment 4 Fedora Review Service 2025-02-16 10:26:38 UTC
Created attachment 2076719 [details]
The .spec file difference from Copr build 8660870 to 8660900

Comment 5 Fedora Review Service 2025-02-16 10:26:40 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8660900
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2345961-browserpass/fedora-rawhide-x86_64/08660900-browserpass/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Neel Chauhan 2025-03-02 17:08:44 UTC
Sorry for the delay. LGTM.

Comment 7 Fedora Admin user for bugzilla script actions 2025-03-03 17:58:27 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/browserpass

Comment 8 wojnilowicz 2025-03-03 18:04:37 UTC
No problem. Thanks for the review.

Comment 9 Fedora Update System 2025-03-03 18:20:51 UTC
FEDORA-2025-6e9f81ec87 (browserpass-3.1.0-2.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-6e9f81ec87

Comment 10 Fedora Update System 2025-03-03 18:23:52 UTC
FEDORA-2025-6e9f81ec87 (browserpass-3.1.0-2.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.