Bug 2347146 - Review Request: arduino-cli - Arduino command line tool
Summary: Review Request: arduino-cli - Arduino command line tool
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-02-22 23:21 UTC by Davide Cavalca
Modified: 2025-02-23 08:36 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Davide Cavalca 2025-02-22 23:21:16 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/arduino-cli/arduino-cli.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/arduino-cli/arduino-cli-1.1.1-1.fc43.src.rpm

Description:
Arduino CLI is an all-in-one solution that provides Boards/Library Managers,
sketch builder, board detection, uploader, and many other tools needed to use
any Arduino compatible board and platform from command line or machine
interfaces.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2025-02-22 23:21:19 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=129523976

Comment 2 Davide Cavalca 2025-02-22 23:21:52 UTC
$ cat go-vendor-tools.toml
[archive]

[licensing]
detector = "askalono"
[[licensing.licenses]]
path = "vendor/github.com/arduino/go-win32-utils/LICENSE.txt"
sha256sum = "42a3b126a6e18b51100a59437faee29c06ed52b61d94e522b4356ad6097c36eb"
expression = "GPL-2.0-only AND LGPL-2.1-only"

[[licensing.licenses]]
path = "vendor/github.com/cloudflare/circl/LICENSE"
sha256sum = "b0da1764fe4d13d610b695536fc3f2ebc362482d053a1cd258e36975bc6b97a7"
expression = "BSD-3-Clause"

[[licensing.licenses]]
path = "vendor/github.com/emirpasic/gods/LICENSE"
sha256sum = "871b440e9b348d6b2485c72e15f1d18f4cf8ee7bb424cbcd854b6a4a772b61d8"
expression = "BSD-2-Clause AND MIT"

[[licensing.licenses]]
path = "vendor/github.com/juju/errors/LICENSE"
sha256sum = "a92f49abd3f15a3523b022a9b74fb885b53c228f8244c817add3a835427b10d9"
expression = "LGPL-3.0-only"

[[licensing.licenses]]
path = "vendor/github.com/kevinburke/ssh_config/LICENSE"
sha256sum = "a15a6f732df3a033a71853ce1d255bd671f00fbc537fa629b78d71baecda0ace"
expression = "MIT"

[[licensing.licenses]]
path = "vendor/github.com/leonelquinteros/gotext/LICENSE"
sha256sum = "3a64aa4539f34bcf8370feb989228e6bd610e8d0d2991626c86d81ddd779ca31"
expression = "BSD-3-Clause AND MIT"

[[licensing.licenses]]
path = "vendor/gopkg.in/yaml.v3/LICENSE"
sha256sum = "d18f6323b71b0b768bb5e9616e36da390fbd39369a81807cca352de4e4e6aa0b"
expression = "Apache-2.0 AND MIT"

Comment 3 Davide Cavalca 2025-02-22 23:23:39 UTC
Tests fail with:

      testing: github.com/arduino/arduino-cli
github.com/arduino/arduino-cli/commands
# github.com/arduino/arduino-cli/commands
# [github.com/arduino/arduino-cli/commands]
./instances.go:342:46: non-constant format string in call to github.com/arduino/arduino-cli/vendor/google.golang.org/grpc/status.Newf
FAIL	github.com/arduino/arduino-cli/commands [build failed]

but the package itself seems to work fine when installed.

Comment 4 Davide Cavalca 2025-02-22 23:25:39 UTC
Package reports its version incorrectly, and seems to have some kind of built in autoupdate. Both will need to be fixed.

$ arduino-cli version
arduino-cli  Version: 0.0.0-git Commit:  Date: 


A new release of Arduino CLI is available: 0.0.0-git → 1.1.1
https://arduino.github.io/arduino-cli/latest/installation/#latest-packages
$

Comment 5 Davide Cavalca 2025-02-23 00:03:26 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/arduino-cli/arduino-cli.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/arduino-cli/arduino-cli-1.1.1-1.fc43.src.rpm

Changelog:
- correctly set version/commit/timestamp
- disable the autoupdater by default

Comment 6 Fedora Review Service 2025-02-23 08:36:04 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8686832
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2347146-arduino-cli/fedora-rawhide-x86_64/08686832-arduino-cli/fedora-review/review.txt

Found issues:

- Documentation size is 1213734 bytes in 34 files. 
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


Note You need to log in before you can comment on or make changes to this bug.