Bug 234814 - (perl-HTML-Encoding) Review Request: perl-HTML-Encoding - Determine the encoding of HTML/XML/XHTML documents
Review Request: perl-HTML-Encoding - Determine the encoding of HTML/XML/XHTML...
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Chris Weyl
Fedora Package Reviews List
Depends On:
  Show dependency treegraph
Reported: 2007-04-02 05:46 EDT by Ville Skyttä
Modified: 2007-11-30 17:12 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-04-03 05:33:02 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
cweyl: fedora‑review+
jwboyer: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Ville Skyttä 2007-04-02 05:46:53 EDT

HTML::Encoding helps to determine the encoding of HTML and XML/XHTML
Comment 1 Chris Weyl 2007-04-02 12:27:00 EDT
Please ensure release is bumped to 1 before building :)  Aside from that,
looks ready...

+ source files match upstream:
 ee31564305ffdaf24d99f26588f8eb9f  HTML-Encoding-0.52.tar.gz
 ee31564305ffdaf24d99f26588f8eb9f  ../HTML-Encoding-0.52.tar.gz
+ package meets naming and versioning guidelines.
O specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible; license text not included upstream.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package installs properly
O no debuginfo package -- noarch
+ rpmlint is silent.
+ final provides and requires are sane:
** perl-HTML-Encoding-0.52-0.5.fc6.noarch.rpm
== rpmlint
== provides
perl(HTML::Encoding) = 0.52
perl-HTML-Encoding = 0.52-0.5.fc6
== requires
+ %check is present and all tests pass:
All tests successful.
Files=1, Tests=1,  0 wallclock secs ( 0.04 cusr +  0.02 csys =  0.06 CPU)
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
+ not a GUI app.

Comment 2 Ville Skyttä 2007-04-02 12:55:50 EDT
Thanks.  Sure, will bump to 1%{?dist} before building.

New Package CVS Request
Package Name: perl-HTML-Encoding
Short Description: Determine the encoding of HTML/XML/XHTML documents
Owners: ville.skytta@iki.fi
Branches: FC-6
InitialCC: fedora-perl-devel-list@redhat.com
Comment 3 Ville Skyttä 2007-04-03 05:33:02 EDT
Imported and built.

Note You need to log in before you can comment on or make changes to this bug.