Bug 2348318 (CVE-2022-49660) - CVE-2022-49660 kernel: xen/arm: Fix race in RB-tree based P2M accounting
Summary: CVE-2022-49660 kernel: xen/arm: Fix race in RB-tree based P2M accounting
Keywords:
Status: NEW
Alias: CVE-2022-49660
Product: Security Response
Classification: Other
Component: vulnerability-draft
Version: unspecified
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Product Security DevOps Team
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-02-26 03:25 UTC by OSIDB Bzimport
Modified: 2025-02-27 15:30 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Embargoed:


Attachments (Terms of Use)

Description OSIDB Bzimport 2025-02-26 03:25:14 UTC
In the Linux kernel, the following vulnerability has been resolved:

xen/arm: Fix race in RB-tree based P2M accounting

During the PV driver life cycle the mappings are added to
the RB-tree by set_foreign_p2m_mapping(), which is called from
gnttab_map_refs() and are removed by clear_foreign_p2m_mapping()
which is called from gnttab_unmap_refs(). As both functions end
up calling __set_phys_to_machine_multi() which updates the RB-tree,
this function can be called concurrently.

There is already a "p2m_lock" to protect against concurrent accesses,
but the problem is that the first read of "phys_to_mach.rb_node"
in __set_phys_to_machine_multi() is not covered by it, so this might
lead to the incorrect mappings update (removing in our case) in RB-tree.

In my environment the related issue happens rarely and only when
PV net backend is running, the xen_add_phys_to_mach_entry() claims
that it cannot add new pfn <-> mfn mapping to the tree since it is
already exists which results in a failure when mapping foreign pages.

But there might be other bad consequences related to the non-protected
root reads such use-after-free, etc.

While at it, also fix the similar usage in __pfn_to_mfn(), so
initialize "struct rb_node *n" with the "p2m_lock" held in both
functions to avoid possible bad consequences.

This is CVE-2022-33744 / XSA-406.

Comment 1 Avinash Hanwate 2025-02-26 11:49:11 UTC
Upstream advisory:
https://lore.kernel.org/linux-cve-announce/2025022622-CVE-2022-49660-cf45@gregkh/T

Comment 2 Avinash Hanwate 2025-02-26 16:23:15 UTC
Upstream advisory:
https://lore.kernel.org/linux-cve-announce/2025022622-CVE-2022-49660-cf45@gregkh/T


Note You need to log in before you can comment on or make changes to this bug.