Bug 2348474 - Review Request: rust-below-tc - TC crate for below
Summary: Review Request: rust-below-tc - TC crate for below
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Davide Cavalca
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2347635
TreeView+ depends on / blocked
 
Reported: 2025-02-26 21:26 UTC by Michel Lind
Modified: 2025-02-26 21:50 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-02-26 21:50:51 UTC
Type: ---
Embargoed:
davide: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2025-02-26 21:26:32 UTC
Spec URL: https://salimma.fedorapeople.org/rust-below-tc.spec
SRPM URL: https://salimma.fedorapeople.org/rust-below-tc-0.9.0-1.fc41.src.rpm

Description:
TC crate for below.

Fedora Account System Username: salimma

Comment 1 Michel Lind 2025-02-26 21:27:53 UTC
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=129637126

Comment 2 Michel Lind 2025-02-26 21:29:56 UTC
❯ cat rust2rpm.toml 
[package]
license-files = [
  "LICENSE",
]

[[package.extra-sources]]
number = 2
file = "https://raw.githubusercontent.com/facebookincubator/below/refs/tags/v0.9.0/LICENSE"
comments = [
  "include license file",
  "https://github.com/facebookincubator/below/pull/8242",
]

[scripts]
prep.post = ["""\
# copy in license file
cp -p %{SOURCE2} ."""]

Comment 3 Davide Cavalca 2025-02-26 21:31:58 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 4 Fedora Admin user for bugzilla script actions 2025-02-26 21:34:32 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-below-tc

Comment 5 Michel Lind 2025-02-26 21:35:07 UTC
Thanks!

Comment 6 Fedora Update System 2025-02-26 21:47:14 UTC
FEDORA-2025-cbdcd83832 (rust-below-tc-0.9.0-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-cbdcd83832

Comment 7 Fedora Update System 2025-02-26 21:50:51 UTC
FEDORA-2025-cbdcd83832 (rust-below-tc-0.9.0-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.