Spec URL: https://fedorapeople.org/~cmadams/virtnbdbackup/virtnbdbackup.spec SRPM URL: https://fedorapeople.org/~cmadams/virtnbdbackup/virtnbdbackup-2.21-1.fc41.src.rpm Description: Backup utility for libvirt, using the latest changed block tracking features. Create online, thin provisioned full and incremental or differential backups of your kvm/qemu virtual machines. Fedora Account System Username: cmadams
Copr build: https://copr.fedorainfracloud.org/coprs/build/8703656 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2348475-virtnbdbackup/fedora-rawhide-x86_64/08703656-virtnbdbackup/fedora-review/review.txt Found issues: - Unversionned Python dependency found. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_dependencies Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Updated for newer upstream release Spec URL: https://fedorapeople.org/~cmadams/virtnbdbackup/virtnbdbackup.spec SRPM URL: https://fedorapeople.org/~cmadams/virtnbdbackup/virtnbdbackup-2.38-1.fc41.src.rpm
Created attachment 2110661 [details] The .spec file difference from Copr build 8703656 to 9726677
Copr build: https://copr.fedorainfracloud.org/coprs/build/9726677 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2348475-virtnbdbackup/fedora-rawhide-x86_64/09726677-virtnbdbackup/fedora-review/review.txt Found issues: - Unversionned Python dependency found. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_dependencies Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hi Chris, * I would do a bit of readability separation. Is: Name: virtnbdbackup Version: 2.38 Release: 1%{?dist} Summary: Backup utility for libvirt License: GPL-3.0-or-later URL: https://github.com/abbbi/%{name} Source0: https://github.com/abbbi/%{name}/releases/download/v%{version}/%{name}-%{version}.tar.gz BuildArch: noarch BuildRequires: findutils, sed BuildRequires: python3-devel BuildRequires: python3-libnbd >= 1.5.5 Requires: nbdkit-python-plugin Requires: nbdkit-server Requires: openssh-clients Requires: python3-libnbd >= 1.5.5 Requires: qemu-img Suggested: Name: virtnbdbackup Version: 2.38 Release: 1%{?dist} Summary: Backup utility for libvirt License: GPL-3.0-or-later URL: https://github.com/abbbi/%{name} Source0: https://github.com/abbbi/%{name}/releases/download/v%{version}/%{name}-%{version}.tar.gz BuildArch: noarch BuildRequires: findutils, sed BuildRequires: python3-devel BuildRequires: python3-libnbd >= 1.5.5 Requires: nbdkit-python-plugin Requires: nbdkit-server Requires: openssh-clients Requires: python3-libnbd >= 1.5.5 Requires: qemu-img * I would move: %generate_buildrequires %pyproject_buildrequires to just above the '%build' section. I would also add '-t' and the end of line '%pyproject_buildrequires'. See example linked to below. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_example_spec_file * '%setup -q' has been replaced by '%autosetup'. * I would be inclined to remove the old version requirement depends on 'python3-libnbd >= 1.5.5'. - Also look at if the requires for te above is needed. Regards Phil
Updated (spec tweaks and also new version): Spec URL: https://fedorapeople.org/~cmadams/virtnbdbackup/virtnbdbackup.spec SRPM URL: https://fedorapeople.org/~cmadams/virtnbdbackup/virtnbdbackup-2.45-1.fc45.src.rpm I prefer keeping all the Tag: entries together, that's the way all my other spec files are written. The python3-libnbd require is needed, it doesn't get pulled in automatically. The version requirement is valid, even it is always satisfied on current Fedora releases. The package has no build-time test, so adding -t to %pyproject_buildrequires is wrong.
Created attachment 2133900 [details] The .spec file difference from Copr build 9726677 to 10236141
Copr build: https://copr.fedorainfracloud.org/coprs/build/10236141 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2348475-virtnbdbackup/fedora-rawhide-x86_64/10236141-virtnbdbackup/fedora-review/review.txt Found issues: - Unversionned Python dependency found. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_dependencies Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hi, Sorry, got distracted by work. Thanks for the updates. Bring up to latest upstream is appreciated and 2.45-1 looks good here. Marking as '+'. You will now be able to request the repo and import your latest srpm. Regards Phil
The Pagure repository was created at https://src.fedoraproject.org/rpms/virtnbdbackup
FEDORA-2026-2e14bbd35f (virtnbdbackup-2.45-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2026-2e14bbd35f
FEDORA-2026-da18e85aff (virtnbdbackup-2.45-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2026-da18e85aff
FEDORA-2026-a616272990 (virtnbdbackup-2.45-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2026-a616272990
Thank you for your review!
FEDORA-2026-a616272990 has been pushed to the Fedora 44 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-a616272990 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-a616272990 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-2e14bbd35f has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-2e14bbd35f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-2e14bbd35f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-da18e85aff has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-da18e85aff \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-da18e85aff See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-064136c2df has been pushed to the Fedora 44 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-064136c2df` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-064136c2df See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-e14d3fbada has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-e14d3fbada` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-e14d3fbada See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-095537d36b has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-095537d36b` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-095537d36b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-064136c2df (virtnbdbackup-2.46-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2026-e14d3fbada (virtnbdbackup-2.46-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2026-095537d36b (virtnbdbackup-2.46-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.