Spec URL: http://www.auroralinux.org/people/spot/review/perl-Mail-IMAPClient.spec SRPM URL: http://www.auroralinux.org/people/spot/review/perl-Mail-IMAPClient-2.2.9-1.src.rpm Description: This module provides perl routines that simplify a sockets connection to and an IMAP conversation with an IMAP server.
Found no %doc with inclusion of docs and examples directory.
New Spec URL: http://www.auroralinux.org/people/spot/review/perl-Mail-IMAPClient.spec New SRPM URL: http://www.auroralinux.org/people/spot/review/perl-Mail-IMAPClient-2.2.9-2.src.rpm Added missing docs.
Add following lines to SPEC to silent rpmlint Warning spurious-executable-perm and Errors invalid-dependency and wrong-script-interpreter. find examples -type f -exec chmod -x {} 2>/dev/null ';' find examples -type f -exec sed -i 's#/usr/local/bin/perl#/usr/bin/perl#' {} 2>/dev/null ';'
New SRPM: http://www.auroralinux.org/people/spot/review/perl-Net-Domain-TLD-1.65-1.fc7.src.rpm New SPEC: http://www.auroralinux.org/people/spot/review/perl-Net-Domain-TLD.spec Handles rpmlint warnings.
Can you submit a new package that handles rpmlint warnings for this review ?
Heh. It helps if I link to the right package: New SRPM: http://www.auroralinux.org/people/spot/review/perl-Mail-IMAPClient-2.2.9-3.fc7.src.rpm New SPEC: http://www.auroralinux.org/people/spot/review/perl-Mail-IMAPClient.spec
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 21c1901d55a2d57f73840cad478c665d Mail-IMAPClient-2.2.9.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test is successful. + Provides: perl(Mail::IMAPClient) perl(Mail::IMAPClient::BodyStructure) perl(Mail::IMAPClient::BodyStructure::Address) perl(Mail::IMAPClient::BodyStructure::Envelope) perl(Mail::IMAPClient::BodyStructure::Parse) perl(Mail::IMAPClient::BodyStructure::Part) perl(Mail::IMAPClient::MessageSet) perl(Mail::IMAPClient::Thread) perl(Parse::RecDescent::Mail::IMAPClient::BodyStructure::Parse) perl(Parse::RecDescent::Mail::IMAPClient::Thread) APPROVED.
New Package CVS Request ======================= Package Name: perl-Mail-IMAPClient Short Description: An IMAP Client API Owners: tcallawa Branches: FC-5 FC-6 InitialCC: fedora-perl-devel-list
Built.