Spec URL: http://home.bawue.de/~ixs/libident/libident.spec SRPM URL: http://home.bawue.de/~ixs/libident/libident-0.30-1.src.rpm Description: LibIdent is a small C library for interfacing with RFC 1413 Identification protocol servers, which are used for identifying users. LibIdent supports both IPv4 and IPv6 addresses transparently. It is meant to be used by daemons to try to authenticate users using the Ident protocol. For this to work, users need to have an Ident server running on the system from which they are connected.
Good: + Naming is ok. + Tar ball matches with upstream. + License ok. + Package contains verbatin copy of the license. + rpmlint quite on source rpm. + Local build works fine. + Rpmlint quite on binary package ü Rpmlint quite on debuginfo package Bad: - you should create a package called libident which contains a shared library. Providing only a static library vaiolate the packaging rules.
Well, this might be a bit problematic, as libident has code currently to provide a shared libary.
Ahh, just to clarify: The problem is not creating a shared library for libident. This can be done probably with something like gcc -shared -Wl,-soname,libident -o libident.so *.o. The problem is more that all the tools I've seen which use libident are expecting this to be a static lib. So we're in a similar situation as with libnet.
Mhm, Seems like my testcase ngircd works with the shared library as well. Must have been updated in the last months then. I uploaded a new spec which created a shared library. Please take a look.
Good: + Local build works fine. Bad: - in.libidenttestd seems to be staticly linked agains libident - Please upload a full source rpm for review.
Mhm. I must have missed the static linking against in.libidenttestd. Fixed. And please do take a look into the directory <http://home.bawue.de/~ixs/libident/>. You'll find not only the spec but all SRPMS and the extracted contents as well...
Bad: - libident-tools subpackage should contains Requires: %{name} = %{version}.%{release}
New package with the require at the usual place.
Sorry, But I could not found the suggested chage in the tools subpackage.:q!
Uhm. Please check <http://home.bawue.de/~ixs/libident/libident-0.30-4.src.rpm> and <http://home.bawue.de/~ixs/libident/libident.spec>. Both should have the Requires line you asked for.
Good: + Local install and uninstall works fine. + in.libidentd was dynamicly linked agains libident.so + Mockbuild works fine. *** APPROVED ***
New Package CVS Request ======================= Package Name: libident Short Description: New LibIdent C library Owners: ixs Branches: F-7 F-8 EL-5 EL-4 Cvsextras Commits: yes
cvs done.