Spec URL: https://gitlab.com/fedora/sigs/robotics/rpms/recastnavigation/-/raw/main/recastnavigation.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/saypaul/recastnavigation/fedora-rawhide-x86_64/08710807-recastnavigation/recastnavigation-1.6.0-1.fc43.src.rpm Description: Recast Navigation is a state of the art navigation system for games and 3D applications. Fedora Account System Username:saypaul Reproducible: Always
Copr build: https://copr.fedorainfracloud.org/coprs/build/8707412 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2348850-recastnavigation/fedora-rawhide-x86_64/08707412-recastnavigation/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/8707450 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2348850-recastnavigation/fedora-rawhide-x86_64/08707450-recastnavigation/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
mock is failing for me, so i could not run a full fedora-review. I added the sed line to fix, and removed setting cmake min on the command line %build/install should be using the %cmake macros https://docs.fedoraproject.org/en-US/packaging-guidelines/CMake/ And the libraries should not be static. sed -i -e 's@cmake_minimum_required(VERSION 3.1)@cmake_minimum_required(VERSION 3.5)@' CMakeLists.txt %build mkdir -p build cd build cmake .. -DCMAKE_INSTALL_PREFIX=%{_prefix} -DCMAKE_BUILD_TYPE=Release make %{?_smp_mflags} %install mkdir -p %{buildroot}%{_prefix}/lib mkdir -p %{buildroot}%{_prefix}/include/recastnavigation
Created attachment 2078275 [details] The .spec file difference from Copr build 8707450 to 8710853
Copr build: https://copr.fedorainfracloud.org/coprs/build/8710853 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2348850-recastnavigation/fedora-rawhide-x86_64/08710853-recastnavigation/fedora-review/review.txt Found issues: - recastnavigation : /usr/include/recastnavigation/DebugDraw.h recastnavigation : /usr/include/recastnavigation/DetourAlloc.h recastnavigation : /usr/include/recastnavigation/DetourAssert.h recastnavigation : /usr/include/recastnavigation/DetourCommon.h recastnavigation : /usr/include/recastnavigation/DetourCrowd.h recastnavigation : /usr/include/recastnavigation/DetourDebugDraw.h recastnavigation : /usr/include/recastnavigation/DetourLocalBoundary.h recastnavigation : /usr/include/recastnavigation/DetourMath.h recastnavigation : /usr/include/recastnavigation/DetourNavMesh.h recastnavigation : /usr/include/recastnavigation/DetourNavMeshBuilder.h recastnavigation : /usr/include/recastnavigation/DetourNavMeshQuery.h recastnavigation : /usr/include/recastnavigation/DetourNode.h recastnavigation : /usr/include/recastnavigation/DetourObstacleAvoidance.h recastnavigation : /usr/include/recastnavigation/DetourPathCorridor.h recastnavigation : /usr/include/recastnavigation/DetourPathQueue.h recastnavigation : /usr/include/recastnavigation/DetourProximityGrid.h recastnavigation : /usr/include/recastnavigation/DetourStatus.h recastnavigation : /usr/include/recastnavigation/DetourTileCache.h recastnavigation : /usr/include/recastnavigation/DetourTileCacheBuilder.h recastnavigation : /usr/include/recastnavigation/Recast.h recastnavigation : /usr/include/recastnavigation/RecastAlloc.h recastnavigation : /usr/include/recastnavigation/RecastAssert.h recastnavigation : /usr/include/recastnavigation/RecastDebugDraw.h recastnavigation : /usr/include/recastnavigation/RecastDump.h recastnavigation : /usr/include/recastnavigation/version.h Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages - Unversioned so-files directly in %_libdir. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://gitlab.com/fedora/sigs/robotics/rpms/recastnavigation/-/raw/main/recastnavigation.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/saypaul/recastnavigation/fedora-rawhide-x86_64/08714112-recastnavigation/recastnavigation-1.6.0-1.fc43.src.rpm Description: Recast Navigation is a state of the art navigation system for games and 3D applications. Fedora Account System Username:saypaul Reproducible: Always
Copr build: https://copr.fedorainfracloud.org/coprs/build/8714113 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2348850-recastnavigation/fedora-rawhide-x86_64/08714113-recastnavigation/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/8714114 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2348850-recastnavigation/fedora-rawhide-x86_64/08714114-recastnavigation/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
@Tom.Rix I have updated the spec as per the packaging guideline. When you have time, please review. Thanks
Release: 1%{?dist} - this can be %autorelease Summary: Recast Navigation is a state of the art navigation system for games and 3D applications. - rmplint complains this is tool long, I use the 'About' field in github, so can change to. - 'Industry-standard navigation-mesh toolset for games' License: zlib - license is tricky, look - https://docs.fedoraproject.org/en-US/legal/allowed-licenses/ - should be Zlib - the license check flag a few more licenses, if the files are not really used, rm them in the %prep step. - if they are needed, License: needs to be updated, and breakdown of the which files use which URL: https://github.com/recastnavigation/recastnavigation Source0: https://github.com/recastnavigation/recastnavigation/archive/refs/tags/v%{version}.tar.gz - Source0: should be prefixed with %{url}, and the 'ref/tags' may not be needed Requires: libdecor-devel - Should not need this, rpmlint complains. # Disable debug source package to avoid issues with empty debugsourcefiles.list %define debug_package %{nil} - rpmlint complains about unstripped files, so something is wrong, generally we want the libraries to be build with some level debugging for the user. %{_bindir}/Meshes/dungeon.obj %{_bindir}/Meshes/nav_test.obj %{_bindir}/Meshes/undulating.obj - These were in the tarball, it looks like the upstream was sloppy, review the RecastDemo/Bin from the tarball, and remove all/most of it in %prep %{_prefix}/bin/DroidSans.ttf - this is data, not a binary, so it needs to go somewhere like %_datadir/%{name} - likely this means any binary that needs to use it needs to be changed to look for the new location %{_bindir}/TestCases/movement_test.txt %{_bindir}/TestCases/nav_mesh_test.txt %{_bindir}/TestCases/raycast_test.txt - Similar, but maybe there needs to be an optional -test subpackage - i would like a %check to make sure it is working.
Spec URL: https://gitlab.com/fedora/sigs/robotics/rpms/recastnavigation/-/raw/main/recastnavigation.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/saypaul/recastnavigation/fedora-rawhide-x86_64/08732197-recastnavigation/recastnavigation-1.6.0-7.fc43.src.rpm Description: Recast Navigation is a state of the art navigation system for games and 3D applications. Fedora Account System Username:saypaul Reproducible: Always
Created attachment 2079067 [details] The .spec file difference from Copr build 8714114 to 8732269
Copr build: https://copr.fedorainfracloud.org/coprs/build/8732269 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2348850-recastnavigation/fedora-rawhide-x86_64/08732269-recastnavigation/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://gitlab.com/fedora/sigs/robotics/rpms/recastnavigation/-/raw/main/recastnavigation.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/saypaul/recastnavigation/fedora-rawhide-x86_64/08735410-recastnavigation/recastnavigation-1.6.0-8.fc43.src.rpm Description: Recast Navigation is a state of the art navigation system for games and 3D applications. Fedora Account System Username:saypaul Reproducible: Always
@Tom.Rix I have modified the spec file as per your comments and have added inline comments for the change details. Please let me know if it looks good, Thanks. Release: 1%{?dist} - this can be %autorelease -- Added autorelease Summary: Recast Navigation is a state of the art navigation system for games and 3D applications. - rmplint complains this is tool long, I use the 'About' field in github, so can change to. - 'Industry-standard navigation-mesh toolset for games' -- Condensed the summary License: zlib - license is tricky, look - https://docs.fedoraproject.org/en-US/legal/allowed-licenses/ - should be Zlib - the license check flag a few more licenses, if the files are not really used, rm them in the %prep step. - if they are needed, License: needs to be updated, and breakdown of the which files use which -- Validated the license from the allowed list and updated to: Zlib AND MIT AND BSL-1.0 AND Apache-2.0 URL: https://github.com/recastnavigation/recastnavigation Source0: https://github.com/recastnavigation/recastnavigation/archive/refs/tags/v%{version}.tar.gz - Source0: should be prefixed with %{url}, and the 'ref/tags' may not be needed -- Modified to: %{url}/archive/v%{version}.tar.gz Requires: libdecor-devel - Should not need this, rpmlint complains. -- Removed it. # Disable debug source package to avoid issues with empty debugsourcefiles.list %define debug_package %{nil} - rpmlint complains about unstripped files, so something is wrong, generally, we want the libraries to be build with some level debugging for the user. -- I couldn't get past it, so I kept it. %{_bindir}/Meshes/dungeon.obj %{_bindir}/Meshes/nav_test.obj %{_bindir}/Meshes/undulating.obj - These were in the tarball, it looks like the upstream was sloppy, review the RecastDemo/Bin from the tarball, and remove all/most of it in %prep -- This is required by the binary RecastDemo , since its just a demo moved to /var/lib/recastnavigation %{_prefix}/bin/DroidSans.ttf - this is data, not a binary, so it needs to go somewhere like %_datadir/%{name} - likely this means any binary that needs to use it needs to be changed to look for the new location -- same as above. %{_bindir}/TestCases/movement_test.txt %{_bindir}/TestCases/nav_mesh_test.txt %{_bindir}/TestCases/raycast_test.txt - Similar, but maybe there needs to be an optional -test subpackage - i would like a %check to make sure it is working. -- Added %ctest, removed the test cases as there is already a Test binary which run checks.
Created attachment 2079117 [details] The .spec file difference from Copr build 8732269 to 8735444
Copr build: https://copr.fedorainfracloud.org/coprs/build/8735444 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2348850-recastnavigation/fedora-rawhide-x86_64/08735444-recastnavigation/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
fedora > /var/lib/recastnavigation/recastdemo/RecastDemo Could not init GUI renderer. Can you check if this works ? If it doesn't work, don't package it. I was confused on *.obj files, I thought these were windows obj's, they are wavefront obj's, just text data. Adding a comment would help others not familar with obj as a geometry file. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "zlib License", "MIT License", "Apache License 2.0 and/or MIT License", "Boost Software License 1.0". 51 files have unknown license. Detailed output of licensecheck in /sfs/fedora-review/review-recastnavigation/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. Please breakdown the license's [ ]: Package requires other packages for directories it uses. Note: No known owner of /var/lib/recastnavigation, /var/lib/recastnavigation/recastdemo, /var/lib/recastnavigation/recastdemo/Meshes [ ]: Package must own all directories that it creates. Note: Directories without known owners: /var/lib/recastnavigation/recastdemo/Meshes, /var/lib/recastnavigation, /var/lib/recastnavigation/recastdemo I do not know if this is where the demo to live. The binary is fine in /usr/bin The other part is static data, so should go to /usr/share [ ]: %build honors applicable compiler flags or justifies otherwise. Why is it necessary to set the cflags ? -DCMAKE_C_FLAGS="${RPM_OPT_FLAGS}" [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [!]: Package obeys FHS, except libexecdir and /usr/target. see above for /var/lib [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [!]: Useful -debuginfo package or justification otherwise. -DCMAKE_BUILD_TYPE=RelWithDebInfo instead of RELEASE [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 8233 bytes in 3 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files DroidSans.ttf [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in recastnavigation-devel Requires: %{name}%{?_isa} = %{version}-%{release} looks good to me [x]: Package functions as described. [x]: Latest version is packaged. %check works [x]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define debug_package %{nil} [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) This may be my fault. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. recastnavigation.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/recastnavigation/License.txt needs a dos2unix, see fedora > file usr/share/doc/recastnavigation/License.txt usr/share/doc/recastnavigation/License.txt: ASCII text, with CRLF line terminators fedora > dos2unix usr/share/doc/recastnavigation/License.txt dos2unix: converting file usr/share/doc/recastnavigation/License.txt to Unix format... fedora > file usr/share/doc/recastnavigation/License.txt usr/share/doc/recastnavigation/License.txt: ASCII text recastnavigation-devel.x86_64: E: description-line-too-long Development files for recastnavigation, a state-of-the-art navigation system for games and 3D applications. recastnavigation-devel.x86_64: E: description-line-too-long This package includes header files, unversioned shared libraries, and CMake configuration files Make these lines a little shorter.