Bug 2348991 - Review Request: rust-deku - Bit level serialization/deserialization proc-macro for structs
Summary: Review Request: rust-deku - Bit level serialization/deserialization proc-macr...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Dan Horák
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/deku
Whiteboard:
Depends On: 2348990
Blocks: 2330787
TreeView+ depends on / blocked
 
Reported: 2025-02-28 09:39 UTC by Jakub Čajka
Modified: 2025-03-04 11:53 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-02-28 16:44:50 UTC
Type: ---
Embargoed:
dan: fedora-review+


Attachments (Terms of Use)

Description Jakub Čajka 2025-02-28 09:39:50 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/jcajka/rusted-s390-utils/fedora-rawhide-x86_64/08693853-rust-deku/rust-deku.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/jcajka/rusted-s390-utils/fedora-rawhide-x86_64/08693853-rust-deku/rust-deku-0.18.1-1.fc43.src.rpm
Description: Bit level serialization/deserialization proc-macro for structs
Fedora Account System Username: jcajka
This package have been generated by rust2rpm and it is dependency of s390utils. Tests has been disabled as they have extensive dependencies and contain dependency cycles and obsoleted crates. Spec will be imported unexpanded.

Comment 1 Fedora Review Service 2025-02-28 09:41:44 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8709072
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2348991-rust-deku/fedora-rawhide-x86_64/08709072-rust-deku/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Dan Horák 2025-02-28 13:25:47 UTC
LGTM

Comment 3 Fedora Admin user for bugzilla script actions 2025-02-28 14:04:10 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-deku

Comment 4 Fedora Update System 2025-02-28 16:40:45 UTC
FEDORA-2025-28964cbdd0 (rust-deku-0.18.1-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-28964cbdd0

Comment 5 Fedora Update System 2025-02-28 16:44:50 UTC
FEDORA-2025-28964cbdd0 (rust-deku-0.18.1-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Fabio Valentini 2025-03-04 11:53:49 UTC
(In reply to Dan Horák from comment #2)
> LGTM

That's a rather ... bare-bones review.

At the very least, a comment in the spec file why tests are disabled would be great.


Note You need to log in before you can comment on or make changes to this bug.