Spec URL: https://download.copr.fedorainfracloud.org/results/mavit/tree-sitter/fedora-rawhide-x86_64/08719625-tree-sitter-elixir/tree-sitter-elixir.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mavit/tree-sitter/fedora-rawhide-x86_64/08719625-tree-sitter-elixir/tree-sitter-elixir-0.3.4-1.fc43.src.rpm Description: Add support for Elixir to Tree-sitter, an incremental parsing system for programming tools. Fedora Account System Username: mavit
Copr build: https://copr.fedorainfracloud.org/coprs/build/8719654 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2349521-tree-sitter-elixir/fedora-rawhide-x86_64/08719654-tree-sitter-elixir/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I'll review it.
I cannot run fedora-review. It fails with "Unknown buildsystem: tree_sitter". Could you please address/explain this one?
(In reply to Peter Lemenkov from comment #3) > I cannot run fedora-review. It fails with "Unknown buildsystem: > tree_sitter". Could you please address/explain this one? This relates to RPM's declarative builds feature, which is new in Fedora 41. https://rpm-software-management.github.io/rpm/manual/buildsystem.html The tree_sitter buildsystem is provided by the tree-sitter-srpm-macros package, which is pulled in by redhat-rpm-config from Fedora 42 onwards. It should work on Fedora 41 if you install it manually. Thanks for picking this up.
Ok, now it builds just fine. I can't find any issues so here is my formal Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Dist tag is present. ^^^ false positives ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package owns all directories that it creates. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package does not contain desktop file (not a GUI application). [x]: Development files are in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: The package is not a rename of another package. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package does not contain systemd file(s). [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 449 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: I did not test if the package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources weren't verified with gpgverify. [?]: I did not test if the package compiles and builds into binary rpms on all supported architectures. [-]: Missing %check section. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: libtree-sitter-elixir-0.3.4-1.fc43.x86_64.rpm libtree-sitter-elixir-devel-0.3.4-1.fc43.x86_64.rpm tree-sitter-elixir-0.3.4-1.fc43.src.rpm Reading /var/tmp/rpm-tmp.iQCFYO Reading /var/tmp/rpm-tmp.KrK9Qz ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp821pcce_')] checks: 32, packages: 3 tree-sitter-elixir.spec: W: no-%prep-section tree-sitter-elixir.spec: W: no-%check-section tree-sitter-elixir.spec: W: no-%build-section 3 packages and 0 specfiles checked; 0 errors, 3 warnings, 22 filtered, 0 badness; has taken 0.4 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 18 filtered, 0 badness; has taken 0.1 s Source checksums ---------------- https://github.com/elixir-lang/tree-sitter-elixir/archive/v0.3.4/tree-sitter-elixir-0.3.4.tar.gz : CHECKSUM(SHA256) this package : cd40b25fc0259fda2f456d7a1e29c067c58c11cd7d96fbf71b546da069d92239 CHECKSUM(SHA256) upstream package : cd40b25fc0259fda2f456d7a1e29c067c58c11cd7d96fbf71b546da069d92239 Requires -------- libtree-sitter-elixir (rpmlib, GLIBC filtered): rtld(GNU_HASH) libtree-sitter-elixir-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libtree-sitter-elixir(x86-64) libtree-sitter-elixir.so.0()(64bit) Provides -------- libtree-sitter-elixir: libtree-sitter-elixir libtree-sitter-elixir(x86-64) libtree-sitter-elixir.so.0()(64bit) libtree-sitter-elixir-devel: libtree-sitter-elixir-devel libtree-sitter-elixir-devel(x86-64) pkgconfig(tree-sitter-elixir) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2349521 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: R, Java, Haskell, Perl, PHP, fonts, SugarActivity, Ocaml, Python Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH This package is ================ === APPROVED === ================
The Pagure repository was created at https://src.fedoraproject.org/rpms/tree-sitter-elixir
Thanks for the review!