Spec URL: https://dcavalca.fedorapeople.org/review/apfsprogs/apfsprogs.spec SRPM URL: https://dcavalca.fedorapeople.org/review/apfsprogs/apfsprogs-0.2.0-1.fc43.src.rpm Description: Apfsprogs is a suite of userland software to work with the Apple File System on Linux. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=130009330
Taking this package. Davide, your files are returning HTTP 403 errors.
Should be fixed now, the directory on fedorapeople was missing the execute bit for some reason
Review notes: * Package follows Fedora packaging guidelines * Package builds and installs correctly * Package licensing is mostly correct and provided license files are installed + I see code from zlib, wpa_supplicant, and some other vendored projects in here with licenses other than GPL-2.0-only. These need to be enumerated in the license tag and bundled provides where relevant. * No serious issues from rpmlint Please address the licensing related issues and then we should be good to go.
Hello, I do realize that this is possibly an old ticket. I am sorry that it hasn't been reviewed yet. Let me trigger the Fedora Review Service to see if the package builds successfully. Hopefully, a green check mark will attract some reviewer. If I am resurrecting an old ticket that you are not interested in anymore, my apologies, feel free to close it. [fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/9819840 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2350914-apfsprogs/fedora-rawhide-x86_64/09819840-apfsprogs/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Can you address my feedback in comment 4?