Bug 2350914 - Review Request: apfsprogs - Experimental APFS tools for Linux
Summary: Review Request: apfsprogs - Experimental APFS tools for Linux
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-03-08 22:43 UTC by Davide Cavalca
Modified: 2025-03-10 18:20 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
ngompa13: fedora-review?


Attachments (Terms of Use)

Description Davide Cavalca 2025-03-08 22:43:26 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/apfsprogs/apfsprogs.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/apfsprogs/apfsprogs-0.2.0-1.fc43.src.rpm

Description:
Apfsprogs is a suite of userland software to work with the Apple File System on
Linux.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2025-03-08 22:43:29 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=130009330

Comment 2 Neal Gompa 2025-03-09 14:40:31 UTC
Taking this package.

Davide, your files are returning HTTP 403 errors.

Comment 3 Davide Cavalca 2025-03-10 03:36:26 UTC
Should be fixed now, the directory on fedorapeople was missing the execute bit for some reason

Comment 4 Neal Gompa 2025-03-10 18:20:31 UTC
Review notes:

* Package follows Fedora packaging guidelines
* Package builds and installs correctly
* Package licensing is mostly correct and provided license files are installed
  + I see code from zlib, wpa_supplicant, and some other vendored projects in here with licenses other than GPL-2.0-only. These need to be enumerated in the license tag and bundled provides where relevant.
* No serious issues from rpmlint

Please address the licensing related issues and then we should be good to go.


Note You need to log in before you can comment on or make changes to this bug.