Spec URL: https://raw.githubusercontent.com/dorindabassey/rust-vhost-device-gpu-copr/refs/heads/main/rust-vhost-device-gpu.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/dorinda/vhost-device-gpu/fedora-42-x86_64/08746346-rust-vhost-device-gpu/rust-vhost-device-gpu-0.1.0-1.fc42.src.rpm Description: A virtio-gpu device using the vhost-user protocol. Fedora Account System Username: dorinda
Copr build: https://copr.fedorainfracloud.org/coprs/build/8750599 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2351395-rust-vhost-device-gpu/fedora-rawhide-x86_64/08750599-rust-vhost-device-gpu/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://raw.githubusercontent.com/dorindabassey/rust-vhost-device-gpu-copr/refs/heads/main/rust-vhost-device-gpu.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/dorinda/vhost-device-gpu/fedora-42-x86_64/08746346-rust-vhost-device-gpu/rust-vhost-device-gpu-0.1.0-1.fc42.src.rpm
Created attachment 2079709 [details] The .spec file difference from Copr build 8750599 to 8750686
Copr build: https://copr.fedorainfracloud.org/coprs/build/8750686 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2351395-rust-vhost-device-gpu/fedora-rawhide-x86_64/08750686-rust-vhost-device-gpu/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Created attachment 2079711 [details] Suggested changes to the spec file Suggesting to add RHEL build support to the spec file.
Thank you for the review and suggestion @sbonazzo I will apply this patch for the RHEL build support.
Spec URL: https://raw.githubusercontent.com/dorindabassey/rust-vhost-device-gpu-copr/refs/heads/main/rust-vhost-device-gpu.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/dorinda/vhost-device-gpu/fedora-42-x86_64/08753034-rust-vhost-device-gpu/rust-vhost-device-gpu-0.1.0-1.fc42.src.rpm
Created attachment 2079795 [details] The .spec file difference from Copr build 8750686 to 8753046
Copr build: https://copr.fedorainfracloud.org/coprs/build/8753046 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2351395-rust-vhost-device-gpu/fedora-rawhide-x86_64/08753046-rust-vhost-device-gpu/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Going to review this tomorrow morning.
`fedpkg --release eln mockbuild --enablerepo local` (where local is the one provided by default with mock pointing to koji buildroot) is failing with: ``` + /usr/bin/env CARGO_HOME=.cargo 'RUSTFLAGS=-Copt-level=3 -Cdebuginfo=2 -Ccodegen-units=1 -Cstrip=none -Cforce-frame-pointers=yes -Clink-arg=-specs=/usr/lib/rpm/redhat/redhat-package-notes' /usr/bin/cargo build -j12 --profile rpm error: failed to select a version for the requirement `mockall = "^0.11.4"` candidate versions found which didn't match: 0.13.1 location searched: directory source `/builddir/build/BUILD/rust-vhost-device-gpu-0.1.0-build/vhost-device-gpu-0.1.0/vendor` (which is replacing registry `crates-io`) required by package `vhost-device-gpu v0.1.0 (/builddir/build/BUILD/rust-vhost-device-gpu-0.1.0-build/vhost-device-gpu-0.1.0)` perhaps a crate was updated and forgotten to be re-vendored? ``` I see ``` $ cargo vendor-filterer --platform x86_64-unknown-linux-gnu \ > --platform powerpc64le-unknown-linux-gnu \ > --platform aarch64-unknown-linux-gnu \ > --platform s390x-unknown-linux-gnu \ > --platform i686-unknown-linux-gnu ``` printing: ``` Vendoring mockall v0.13.1 (/home/sbonazzo/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/mockall-0.13.1) to vendor/mockall Vendoring mockall_derive v0.13.1 (/home/sbonazzo/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/mockall_derive-0.13.1) to vendor/mockall_derive ``` I'm not sure where the `mockall = "^0.11.4"` is being pulled in as a requirement. Can you check?
I see, it's coming from ``` # allow mockall 0.11.4 and tempfile <= 3.16.0 for now Patch: vhost-device-gpu-fix-metadata.diff ``` Can you change above with ``` %if %{without bundled_rust_deps} # allow mockall 0.11.4 and tempfile <= 3.16.0 for now Patch: vhost-device-gpu-fix-metadata.diff %endif ```
Created attachment 2079901 [details] ELN build fixes Attaching an additional patch to the spec file to make it build on ELN.
> I see, it's coming from > ``` > # allow mockall 0.11.4 and tempfile <= 3.16.0 for now > Patch: vhost-device-gpu-fix-metadata.diff > ``` > > Can you change above with > > ``` > %if %{without bundled_rust_deps} > # allow mockall 0.11.4 and tempfile <= 3.16.0 for now > Patch: vhost-device-gpu-fix-metadata.diff > %endif > ``` I will add that patch. It seems, the patch wasn't applied for rhel build.
Spec URL: https://raw.githubusercontent.com/dorindabassey/rust-vhost-device-gpu-copr/refs/heads/main/rust-vhost-device-gpu.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/dorinda/vhost-device-gpu/fedora-rawhide-x86_64/08766330-rust-vhost-device-gpu/rust-vhost-device-gpu-0.1.0-1.fc43.src.rpm
Created attachment 2080242 [details] The .spec file difference from Copr build 8753046 to 8768877
Copr build: https://copr.fedorainfracloud.org/coprs/build/8768877 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2351395-rust-vhost-device-gpu/fedora-rawhide-x86_64/08768877-rust-vhost-device-gpu/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ licenses of statically linked dependencies are correctly taken into account ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-vhost-device-gpu
FEDORA-2025-bae18336d8 (rust-vhost-device-gpu-0.1.0-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-bae18336d8
FEDORA-2025-bae18336d8 (rust-vhost-device-gpu-0.1.0-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.