Bug 2351539 - Review Request: redisx - Free and independent Redis / Valkey client library for C/C++
Summary: Review Request: redisx - Free and independent Redis / Valkey client library f...
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL: https://smithsonian.github.io/redisx
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-03-12 10:15 UTC by Attila Kovacs
Modified: 2025-05-06 10:30 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:


Attachments (Terms of Use)
The .spec file difference from Copr build 8753347 to 8753385 (1.69 KB, patch)
2025-03-12 11:14 UTC, Fedora Review Service
no flags Details | Diff
The .spec file difference from Copr build 8753464 to 8753502 (678 bytes, patch)
2025-03-12 12:05 UTC, Fedora Review Service
no flags Details | Diff
The .spec file difference from Copr build 8753502 to 8772887 (1.66 KB, patch)
2025-03-17 10:46 UTC, Fedora Review Service
no flags Details | Diff
The .spec file difference from Copr build 8772887 to 8816141 (767 bytes, patch)
2025-03-25 09:04 UTC, Fedora Review Service
no flags Details | Diff
The .spec file difference from Copr build 8816141 to 9000609 (473 bytes, patch)
2025-05-06 10:30 UTC, Fedora Review Service
no flags Details | Diff

Description Attila Kovacs 2025-03-12 10:15:06 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/attipaci/redisx/fedora-rawhide-x86_64/08753167-redisx/redisx.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/attipaci/redisx/fedora-rawhide-x86_64/08753167-redisx/redisx-1.0.0~rc2-1.fc43.src.rpm
Description: 
RedisX is a free, light-weight Redis client library for C/C++. As such, it works with Redis forks / clones like Dragonfly or Valkey also. It supports both interactive and pipelined Redis queries, managing and processing subscriptions, atomic execution blocks, and LUA scripts loading. It can be used with multiple Redis servers simultaneously also. RedisX is free to use, in any way you like, without licensing restrictions.

Build for all Fedora supported platforms are available on Copr at https://copr.fedorainfracloud.org/coprs/attipaci/redisx/build/8753167/

Fedora Account System Username: attipaci

Comment 1 Fedora Review Service 2025-03-12 10:24:28 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8753234
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2351539-redisx/fedora-rawhide-x86_64/08753234-redisx/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Attila Kovacs 2025-03-12 10:56:14 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/attipaci/redisx/fedora-rawhide-x86_64/08753336-redisx/redisx.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/attipaci/redisx/fedora-rawhide-x86_64/08753336-redisx/redisx-1.0.0~rc2-1.fc43.src.rpm

 - Removed period at the end of the summary
 - Changed description to work around spell-checker
 - Added `%{_isa}` to dependent packages (maybe all should need it?)

-- A.

Comment 4 Fedora Review Service 2025-03-12 11:12:17 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8753347
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2351539-redisx/fedora-rawhide-x86_64/08753347-redisx/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Fedora Review Service 2025-03-12 11:14:06 UTC
Created attachment 2079815 [details]
The .spec file difference from Copr build 8753347 to 8753385

Comment 6 Fedora Review Service 2025-03-12 11:14:08 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8753385
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2351539-redisx/fedora-rawhide-x86_64/08753385-redisx/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 8 Fedora Review Service 2025-03-12 11:37:56 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8753464
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2351539-redisx/fedora-rawhide-x86_64/08753464-redisx/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 10 Fedora Review Service 2025-03-12 12:05:09 UTC
Created attachment 2079847 [details]
The .spec file difference from Copr build 8753464 to 8753502

Comment 11 Fedora Review Service 2025-03-12 12:05:11 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8753502
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2351539-redisx/fedora-rawhide-x86_64/08753502-redisx/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 12 Attila Kovacs 2025-03-12 12:17:43 UTC
As for the two remaining rpmlint warnings:

> redisx.x86_64: W: crypto-policy-non-compliance-openssl /usr/lib64/libredisx.so.1 SSL_CTX_set_cipher_list
> redisx.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/lib64/libredisx.so.1

I will change upstream (next release candidate) to address these there. The first one is for legacy OpenSSL support (<1.1.1), and can be completely disabled when built against newer versions (openssl >= 1.1.1). The second will be fixed by using `getaddrinfo()` instead.

-- A.

Comment 14 Fedora Review Service 2025-03-17 10:46:18 UTC
Created attachment 2080520 [details]
The .spec file difference from Copr build 8753502 to 8772887

Comment 15 Fedora Review Service 2025-03-17 10:46:20 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8772887
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2351539-redisx/fedora-rawhide-x86_64/08772887-redisx/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 17 Fedora Review Service 2025-03-25 09:04:54 UTC
Created attachment 2081857 [details]
The .spec file difference from Copr build 8772887 to 8816141

Comment 18 Fedora Review Service 2025-03-25 09:04:57 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8816141
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2351539-redisx/fedora-rawhide-x86_64/08816141-redisx/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 20 Fedora Review Service 2025-05-06 10:30:42 UTC
Created attachment 2088617 [details]
The .spec file difference from Copr build 8816141 to 9000609

Comment 21 Fedora Review Service 2025-05-06 10:30:44 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9000609
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2351539-redisx/fedora-rawhide-x86_64/09000609-redisx/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


Note You need to log in before you can comment on or make changes to this bug.