Spec URL: http://beer.tclug.org/fedora-extras/aoetools/aoetools.spec SRPM URL: http://beer.tclug.org/fedora-extras/aoetools/aoetools-14-1.fc6.src.rpm Description: The aoetools are programs that assist in using ATA over Ethernet on systems with version 2.6 Linux kernels.
One note before I post the actual review -- it looks like the Makefile doesn't honor the Fedora compiler flags -- I suspect something like this would resolve that: %build make %{?_smp_mflags} CFLAGS="$RPM_OPT_FLAGS"
Thanks for picking this up. Just kicked off a test build with your suggestion, I'll see what the build.log looks like. I readily acknowledge that I'm not too good at compiler flags, so I appreciate the pointer.
Yep, looks way better. The highlights from the build.log diff: -+ make -j2 -cc -Wall -O -g -o aoeping.o -c aoeping.c ++ make -j2 'CFLAGS=-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic' +cc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -o aoeping.o -c aoeping.c -cc -Wall -O -g -o linux.o -c linux.c -cc -Wall -O -g -o aoeping aoeping.o linux.o +cc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -o linux.o -c linux.c +cc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -o aoeping aoeping.o linux.o You get the idea. Fairly obvious, but here are the new spec/SRPM: http://beer.tclug.org/fedora-extras/aoetools/aoetools.spec http://beer.tclug.org/fedora-extras/aoetools/aoetools-14-2.fc6.src.rpm
There is a devnodes.txt that's included with the distribution that you may also want to stick in %doc + source files match upstream: 592f9f031796b4f0b90166a8cd5f9e30 aoetools-14.tar.gz 592f9f031796b4f0b90166a8cd5f9e30 ../aoetools-14.tar.gz package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license. + license is open source-compatible. (GPL) License text included in package. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate. + %clean is present. + package installs properly + debuginfo package looks complete. + rpmlint is silent. + final provides and requires are sane: ** aoetools-14-1.fc6.x86_64.rpm == rpmlint == provides aoetools = 14-1.fc6 == requires /bin/bash /bin/sh libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) ** aoetools-debuginfo-14-1.fc6.x86_64.rpm == rpmlint == provides aoetools-debuginfo = 14-1.fc6 == requires O %check is not present -- no tests defined, however + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no scriptlets present. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. + no headers. + no pkgconfig files. + no libtool .la droppings. + not a GUI app. APPROVED
Thanks for the review! Requesting CVS Admin attention to get the module created. Also, maybe we should mention the AoE userspace support in the release notes? No idea. Flagging it, someone smarter than me can make that determination. I'll include the devnotes.txt in the copy I upload. Thanks again!
Oops, I'm supposed to use this here template, huh? New Package CVS Request ======================= Package Name: aoetools Short Description: ATA over Ethernet Tools Owners: jima.org Branches: FC-5, FC-6, devel InitialCC:
Oops. Turns out there was a new release (15) four days after my original R&D, but two days before I submitted this review request. Only minor bugfixes, which had the net result of eliminating one of my patches and reducing the other. I'm pushing the updated version as 15-1. In other news, 15-1 builds successfully in the official buildsys, so I'm closing this review out. Thanks again, Chris!
Oops, Firefox caching seemed to reset fedora‑cvs to ?; unsetting.
Note in FC7 release notes under "PackageNotes". Thanks for thinking of us. :)
Package Change Request ====================== Package Name: aoetools New Branches: EL-4 EL-5
cvs done.