Bug 2352385 - unable to reuse the btrfs-formatted disks for other filesystems
Summary: unable to reuse the btrfs-formatted disks for other filesystems
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: cockpit
Version: 42
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Marius Vollmer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: RejectedBlocker AcceptedFreezeException
Depends On:
Blocks: F42FinalFreezeException
TreeView+ depends on / blocked
 
Reported: 2025-03-13 16:45 UTC by lnie
Modified: 2025-03-26 02:22 UTC (History)
13 users (show)

Fixed In Version: cockpit-336-1.fc43 cockpit-336-1.fc42 cockpit-336-1.fc41
Clone Of:
Environment:
Last Closed: 2025-03-24 23:53:55 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
anaconda.log (10.10 KB, text/plain)
2025-03-13 16:46 UTC, lnie
no flags Details
storage.log (111.01 KB, text/plain)
2025-03-13 16:47 UTC, lnie
no flags Details
journal (630.12 KB, text/plain)
2025-03-13 16:48 UTC, lnie
no flags Details
screencast (635.38 KB, video/mp4)
2025-03-13 16:50 UTC, lnie
no flags Details
screenshot (152.88 KB, image/png)
2025-03-14 14:41 UTC, lnie
no flags Details

Description lnie 2025-03-13 16:45:14 UTC
1.Boot  Fedora-Workstation-Live-42_Beta-1.4.x86_64.iso on a VM containing two disks, select the two disks,and "use all disks",and finish a guided installation.
2.Boot the installer again, select the two disks and launch storage editor,
try to delete the btrfs device, but failed with "The device is currently in use". 

Please note this only affects system with more than one disks.

Reproducible: Always

Comment 1 lnie 2025-03-13 16:46:17 UTC
Created attachment 2080062 [details]
anaconda.log

Comment 2 lnie 2025-03-13 16:47:16 UTC
Created attachment 2080063 [details]
storage.log

Comment 3 lnie 2025-03-13 16:48:57 UTC
Created attachment 2080064 [details]
journal

Comment 4 lnie 2025-03-13 16:50:11 UTC
Created attachment 2080065 [details]
screencast

Comment 5 lnie 2025-03-14 09:09:45 UTC
Just checked with f41,not affected by this bug.

Comment 6 Fedora Blocker Bugs Application 2025-03-14 09:14:59 UTC
Proposed as a Blocker for 42-final by Fedora user lnie using the blocker tracking app because:

 Affects the  "Remove existing storage volumes" part of custmom_partitioning criteria:
https://fedoraproject.org/wiki/Fedora_42_Beta_Release_Criteria#Custom_partitioning

Comment 7 Katerina Koukiou 2025-03-14 14:23:01 UTC
I believe the dialog hint suggests that the Btrfs device is in use because it contains a Btrfs subvolume. If you delete the subvolume first, you should be able to proceed with removing the device.

Comment 8 lnie 2025-03-14 14:39:20 UTC
yeah,I guess so, but there is no delete button in the choice list,which could be told from the screencast,and the screenshot I'm gonna to attach.

Comment 9 lnie 2025-03-14 14:41:54 UTC
Created attachment 2080216 [details]
screenshot

Comment 10 Katerina Koukiou 2025-03-14 15:50:12 UTC
For the record the device was probably created with:

mkfs.btrfs -L fedora -d single -m single /dev/vda3 /dev/vdb1

Comment 11 Marius Vollmer 2025-03-17 10:29:05 UTC
This is a missing feature in Cockpit Storage.  Cockpit Storage can not manage the devices of multi-device btrfs filesystems yet.  If you create a multi-device btrfs filesystem externally, Cockpit will let you manage the subvolumes of it, but you can't add or remove devices, nor can you delete the whole thing.

To resolve this bug report, it would be enough to implement erasing a multi-device btrfs filesystem, right?

That should be pretty straightforward, and not involve any of the subtleties that come with raid profiles.

Comment 12 Kashyap Chamarthy 2025-03-17 10:50:20 UTC
(In reply to Marius Vollmer from comment #11)
> This is a missing feature in Cockpit Storage.  Cockpit Storage can not
> manage the devices of multi-device btrfs filesystems yet.  If you create a
> multi-device btrfs filesystem externally, Cockpit will let you manage the
> subvolumes of it, but you can't add or remove devices, nor can you delete
> the whole thing.
> 
> To resolve this bug report, it would be enough to implement erasing a
> multi-device btrfs filesystem, right?
> 
> That should be pretty straightforward, and not involve any of the subtleties
> that come with raid profiles.

(Randomly chiming in.)

If this is a missing feature in Cockpit, is it reasonable to expect to get this fixed before F42 GA and unblock this? 

Comment#7 indicates there's a workaround of deleting Btrfs sub-volume allows you to delete the full volume.  Can someone confirm this?

Comment 13 Katerina Koukiou 2025-03-17 11:04:36 UTC
@Kashyap, my https://bugzilla.redhat.com/show_bug.cgi?id=2352385#c7 would not solve the issue, I misunderstood the report initially. We need the new feature as described in https://bugzilla.redhat.com/show_bug.cgi?id=2352385#c11 .

Comment 14 Marius Vollmer 2025-03-17 14:28:15 UTC
Here is a pull request that implements deletion of multi-device btrfs filesystems: https://github.com/cockpit-project/cockpit/pull/21719

Comment 15 Marius Vollmer 2025-03-17 14:31:17 UTC
> If this is a missing feature in Cockpit, is it reasonable to expect to get this fixed before F42 GA and unblock this? 

I am optimistic that we can land https://github.com/cockpit-project/cockpit/pull/21719 this week.

Comment 16 Adam Williamson (Red Hat non-Fedora) 2025-03-17 15:49:19 UTC
-4 blocker votes in https://pagure.io/fedora-qa/blocker-review/issue/1793 so rejected as a blocker, but I'm proposing it as an FE as it *would* be good to fix this for Final if we can do so safely.

Comment 17 Lukas Brabec 2025-03-17 17:55:43 UTC
Discussed during the 2025-03-17 blocker review meeting [1]:

* AGREED: 2352385 - AcceptedFreezeException (Final) - this is accepted as an FE as it's a desirable feature that it would be good to get into F42 if we can land it in enough time to test it. we won't take it very late during freeze

[1] https://meetbot-raw.fedoraproject.org/blocker-review_matrix_fedoraproject-org/2025-03-17/f42-blocker-review.2025-03-17-16.00.log.html

Comment 18 Fedora Update System 2025-03-24 08:13:40 UTC
FEDORA-2025-5f443b7585 (cockpit-336-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-5f443b7585

Comment 19 Fedora Update System 2025-03-24 08:16:07 UTC
FEDORA-2025-f696bd8401 (cockpit-336-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-f696bd8401

Comment 20 Fedora Update System 2025-03-24 08:16:36 UTC
FEDORA-2025-d0209082ac (cockpit-336-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-d0209082ac

Comment 21 Fedora Update System 2025-03-24 23:53:55 UTC
FEDORA-2025-5f443b7585 (cockpit-336-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 22 Fedora Update System 2025-03-25 00:16:33 UTC
FEDORA-2025-f696bd8401 (cockpit-336-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 23 Fedora Update System 2025-03-25 04:00:14 UTC
FEDORA-2025-d0209082ac has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-d0209082ac`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-d0209082ac

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 24 Fedora Update System 2025-03-26 02:22:37 UTC
FEDORA-2025-d0209082ac (cockpit-336-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.