Bug 2352665 - Review Request: rust-rfd - Rusty File Dialog
Summary: Review Request: rust-rfd - Rusty File Dialog
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/rfd
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-03-15 03:45 UTC by Davide Cavalca
Modified: 2025-03-15 15:53 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-03-15 15:53:54 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2025-03-15 03:45:41 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-rfd/rust-rfd.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-rfd/rust-rfd-0.15.3-1.fc43.src.rpm

Description:
Rusty File Dialog.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2025-03-15 03:45:44 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=130286242

Comment 2 Fedora Review Service 2025-03-15 03:47:38 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8770054
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2352665-rust-rfd/fedora-rawhide-x86_64/08770054-rust-rfd/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fabio Valentini 2025-03-15 15:15:05 UTC
I checked that this indeed compiles with both pollster 0.3 and 0.4.
In this case, I would recommend to patch the dependency to ">=0.3,<0.5" so we can avoid having to patch this package again when pollster is updated from v0.3 to v0.4 in Fedora.

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

Comment 4 Fedora Admin user for bugzilla script actions 2025-03-15 15:31:24 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rfd

Comment 5 Fedora Update System 2025-03-15 15:49:21 UTC
FEDORA-2025-0ef1029af2 (rust-rfd-0.15.3-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-0ef1029af2

Comment 6 Fedora Update System 2025-03-15 15:53:54 UTC
FEDORA-2025-0ef1029af2 (rust-rfd-0.15.3-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.