Spec URL: https://src.fedoraproject.org/fork/jvanek/rpms/java-latest-openjdk/raw/jdk25/f/java-25-openjdk.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/7383/130397383/java-25-openjdk-25.0.0.0.13-0.1.ea.fc43.src.rpm Description: OpenJDK 25 Runtime Environment Fedora Account System Username: jvanek
sscratch: https://koji.fedoraproject.org/koji/taskinfo?taskID=130397370
There is a reason BZ was not able to provide review template.. it is 1.1 MB in size. Adding it to the attachement.. I don't think there should be this many issues listed.
Created attachment 2080926 [details] review template - too large to fit a comment
Thanx! I jhad removed the superlong listings, as they seemed ok by me. I think you can proceed with review. Seek for [jv]: This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Header files in -devel subpackage, if present. Note: java-25-openjdk-src : /usr/lib/jvm/java-25-openjdk/full_sources/jdk-25+13/make/data/autoheaders/assemblyprefix.h java-25-openjdk-src : ... [jv] seems ok to me, as java-25-openjdk-src-fastdebug : /usr/lib/jvm/java-25-openjdk- fastdebug/generated_sources/jdk25.build/support/modules_include/jdk.jdwp.agent/jdwpTransport.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'Apache-1.1 AND Apache-2.0 AND LicenseRef-Callaway-BSD AND LicenseRef-Callaway-BSD-with-advertising AND GPL-1.0-or-later AND GPL-2.0-only AND LicenseRef-Callaway-GPLv2-with- exceptions AND IJG AND LicenseRef-Callaway-LGPLv2+ AND LicenseRef- Callaway-MIT AND MPL-2.0 AND LicenseRef-Callaway-Public-Domain AND W3C AND Zlib AND ISC AND FTL AND LicenseRef-RSA'. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 - Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: java-25-openjdk-static-libs, java-25-openjdk- static-libs-slowdebug, java-25-openjdk-static-libs-fastdebug, java-25-openjdk-src, java-25-openjdk-src-slowdebug, java-25-openjdk-src- fastdebug. Illegal package name: java-25-openjdk-static-libs, java-25-openjdk-static-libs-slowdebug, java-25-openjdk-static-libs- fastdebug, java-25-openjdk-src, java-25-openjdk-src-slowdebug, java-25-openjdk-src-fastdebug. Does not provide -static: java-25-openjdk- static-libs, java-25-openjdk-static-libs-slowdebug, java-25-openjdk- static-libs-fastdebug, java-25-openjdk-src, java-25-openjdk-src- slowdebug, java-25-openjdk-src-fastdebug. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#packaging-static-libraries - gtk-update-icon-cache must not be invoked in %post and %posttrans for Fedora 26 and later. Note: icons in java-25-openjdk, java-25-openjdk-slowdebug, java-25-openjdk-fastdebug See: - Packages have proper BuildRequires/Requires on javapackages-tools (jpackage-utils) ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [!]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. java-25-openjdk-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libawt_xawt.so ... [jv] are ok as they are JVM private. java-25-openjdk-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libsplashscreen.so [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [?]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/jvm/java-25-openjdk/lib/static/linux- amd64/glibc/server, /usr/lib/jvm/java-25-openjdk- slowdebug/lib/static/linux-amd64/glibc/server, /usr/lib/jvm/java-25-openjdk-fastdebug/lib/static/linux- amd64/glibc/server Reviewer note: look below. [?]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor, /usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor/48x48, /usr/lib/jvm/java-25-openjdk-slowdebug/lib/static/linux- amd64/glibc/server, /usr/lib/jvm/java-25-openjdk-fastdebug, /usr/lib/jvm/java-25-openjdk-fastdebug/lib, /usr/lib/jvm/java-25-openjdk-fastdebug/lib/static/linux- amd64/glibc/server, /usr/share/icons/hicolor/24x24, /usr/lib/jvm/java-25-openjdk-slowdebug/lib, /usr/lib/jvm/java-25-openjdk, /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor/32x32/apps, /usr/lib/jvm/java-25-openjdk/lib, /usr/share/icons/hicolor/16x16, /usr/lib/jvm/java-25-openjdk/lib/static/linux-amd64/glibc/server, /usr/lib/jvm, /usr/lib/jvm/java-25-openjdk-slowdebug, /usr/share/icons/hicolor/24x24/apps, /usr/share/icons/hicolor/16x16/apps Reviewer note: this looks wrong. [?]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /etc/.java(java-latest- openjdk-headless-fastdebug, java-21-openjdk-headless, java-latest- openjdk-headless-slowdebug, java-latest-openjdk-headless, java-21-openjdk-headless-slowdebug, java-21-openjdk-headless- fastdebug), /etc/.java/.systemPrefs(java-latest-openjdk-headless- fastdebug, java-21-openjdk-headless, java-latest-openjdk-headless- slowdebug, java-latest-openjdk-headless, java-21-openjdk-headless- slowdebug, java-21-openjdk-headless-fastdebug), /usr/share/systemtap(java-latest-openjdk-devel-slowdebug, systemtap- client, perl-devel, java-21-openjdk-devel-fastdebug, systemtap-devel, java-21-openjdk-devel-slowdebug, ruby-libs, sssd-common, java-21-openjdk-devel, java-latest-openjdk-devel, systemtap-jupyter, java-latest-openjdk-devel-fastdebug, systemtap-testsuite, glib2-devel), /usr/share/systemtap/tapset(java-latest-openjdk-devel- slowdebug, systemtap-client, perl-devel, java-21-openjdk-devel- fastdebug, systemtap-devel, java-21-openjdk-devel-slowdebug, pcp, ruby-libs, sssd-common, java-21-openjdk-devel, libvirt-libs, java- latest-openjdk-devel, java-latest-openjdk-devel-fastdebug, glib2-devel), /usr/share/systemtap/tapset/x86_64(java-latest-openjdk- devel-slowdebug, systemtap-client, java-21-openjdk-devel-fastdebug, systemtap-devel, java-21-openjdk-devel-slowdebug, java-21-openjdk- devel, java-latest-openjdk-devel, java-latest-openjdk-devel-fastdebug, glib2-devel) Reviewer note: I assume this one is ok. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: %config files are marked noreplace or the reason is justified. Note: No (noreplace) in %config /etc/java/java-25-openjdk/java-25-openjdk/conf/management/jmxremote.password.template %config /etc/java/java-25-openjdk/java-25-openjdk/conf/sdp/sdp.conf.template %config /etc/java/java-25-openjdk/java-25-openjdk- slowdebug/conf/management/jmxremote.password.template %config /etc/java/java-25-openjdk/java-25-openjdk- slowdebug/conf/sdp/sdp.conf.template %config /etc/java/java-25-openjdk/java-25-openjdk- fastdebug/conf/management/jmxremote.password.template %config /etc/java/java-25-openjdk/java-25-openjdk- fastdebug/conf/sdp/sdp.conf.template [ ]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 36540 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: javapackages-tools (jpackage-utils) [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: Old add_to_maven_depmap macro is not being used Perl: [x]: Package contains the mandatory BuildRequires and Requires:. ===== SHOULD items ===== Generic: [?]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in java-25-openjdk-slowdebug , java-25-openjdk-fastdebug , java-25-openjdk-headless , java-25-openjdk-headless-slowdebug , java-25-openjdk-headless-fastdebug , java-25-openjdk-devel , java-25-openjdk-devel-slowdebug , java-25-openjdk-devel-fastdebug , java-25-openjdk-static-libs , java-25-openjdk-static-libs-slowdebug , java-25-openjdk-static-libs-fastdebug , java-25-openjdk-jmods , java-25-openjdk-jmods-slowdebug , java-25-openjdk-jmods-fastdebug , java-25-openjdk-demo , java-25-openjdk-demo-slowdebug , java-25-openjdk-demo-fastdebug , java-25-openjdk-src , java-25-openjdk-src-slowdebug , java-25-openjdk-src-fastdebug , java-25-openjdk-javadoc-zip [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments Reviewer note: IcedTea [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. Reviewer note: generated sources [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [?]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define debug_package %{nil}, %define __brp_strip_static_archive %{nil}, %define is_release_build() %( if [ "%{?1}" == "%{debug_suffix_unquoted}" -o "%{?1}" == "%{fastdebug_suffix_unquoted}" ]; then echo "0" ; else echo "1"; fi ), %define fullversion() %{expand:%{compatiblename}%{?1}-%{version}-%{release}}, %define uniquejavadocdir() %{expand:%{compatiblename}%{?1}}, %define uniquesuffix() %{expand:%{compatiblename}%{?1}}, %define etcjavadir() %{expand:%{etcjavasubdir}/%{uniquesuffix -- %{?1}}}, %define sdkdir() %{expand:%{uniquesuffix -- %{?1}}}, %define sdkbindir() %{expand:%{_jvmdir}/%{sdkdir -- %{?1}}/bin}, %define jrebindir() %{expand:%{_jvmdir}/%{sdkdir -- %{?1}}/bin}, %define post_script() %{expand:, %define priority_for() %{expand:%[%{?1:1}%{!?1:0} ? %{priority} - 1 : %{priority}]}, %define alternatives_java_install() %{expand:, %define post_headless() %{expand:, %define postun_script() %{expand:, %define preun_headless() %{expand:, %define posttrans_script() %{expand:, %define alternatives_javac_install() %{expand:, %define post_devel() %{expand:, %define preun_devel() %{expand:, %define postun_devel() %{expand:, %define posttrans_devel() %{expand:, %define alternatives_javadoc_install() %{expand:, %define preun_javadoc() %{expand:, %define alternatives_javadoczip_install() %{expand:, %define preun_javadoc_zip() %{expand:, %define files_jre() %{expand:, %define files_jre_headless() %{expand:, %define files_devel() %{expand:, %define files_jmods() %{expand:, %define files_demo() %{expand:, %define files_src() %{expand:, %define files_static_libs() %{expand:, %define files_javadoc() %{expand:, %define files_javadoc_zip() %{expand:, %define java_rpo() %{expand:, %define java_headless_rpo() %{expand:, %define java_devel_rpo() %{expand:, %define java_static_libs_rpo() %{expand:, %define java_jmods_rpo() %{expand:, %define java_demo_rpo() %{expand:, %define java_javadoc_rpo() %{expand:, %define java_src_rpo() %{expand:, %define lua_delete_old_link() %{expand: Reviewer note: ## FIXME FIXME FIXME %define debug_package %{nil} ## FIXME FIXME FIXME the above looks wrong. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. Java: [x]: Packages are noarch unless they use JNI Note: java-25-openjdk subpackage is not noarch. Please verify manually Reviewer note: uses JNI [x]: Package uses upstream build method (ant/maven/etc.) ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 734238720 bytes in /usr/share java-25-openjdk-javadoc-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm:337930240, java-25-openjdk-javadoc- zip-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm:395110400 See: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Unversioned so-files -------------------- java-25-openjdk: /usr/lib/jvm/java-25-openjdk/lib/libawt_xawt.so ... [jv] are ok as they are JVM private. java-25-openjdk-headless-fastdebug: /usr/lib/jvm/java-25-openjdk-fastdebug/lib/server/libjvm.so Requires -------- java-25-openjdk (rpmlib, GLIBC filtered): /bin/sh fontconfig(x86-64) java-25-openjdk-headless(x86-64) libX11.so.6()(64bit) libXcomposite(x86-64) libXext.so.6()(64bit) libXi.so.6()(64bit) libXrender.so.1()(64bit) libXtst.so.6()(64bit) libc.so.6()(64bit) libm.so.6()(64bit) rtld(GNU_HASH) xorg-x11-fonts-Type1 java-25-openjdk-slowdebug (rpmlib, GLIBC filtered): /bin/sh fontconfig(x86-64) java-25-openjdk-headless-slowdebug(x86-64) libX11.so.6()(64bit) libXcomposite(x86-64) libXext.so.6()(64bit) libXi.so.6()(64bit) libXrender.so.1()(64bit) libXtst.so.6()(64bit) libc.so.6()(64bit) libm.so.6()(64bit) rtld(GNU_HASH) xorg-x11-fonts-Type1 java-25-openjdk-fastdebug (rpmlib, GLIBC filtered): /bin/sh fontconfig(x86-64) java-25-openjdk-headless-fastdebug(x86-64) libX11.so.6()(64bit) libXcomposite(x86-64) libXext.so.6()(64bit) libXi.so.6()(64bit) libXrender.so.1()(64bit) libXtst.so.6()(64bit) libc.so.6()(64bit) libm.so.6()(64bit) rtld(GNU_HASH) xorg-x11-fonts-Type1 java-25-openjdk-headless (rpmlib, GLIBC filtered): /bin/sh /usr/bin/alternatives ca-certificates config(java-25-openjdk-headless) crypto-policies cups-libs javapackages-filesystem libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libasound.so.2(ALSA_0.9.0rc4)(64bit) libc.so.6()(64bit) libm.so.6()(64bit) lksctp-tools(x86-64) nss rtld(GNU_HASH) tzdata-java java-25-openjdk-headless-slowdebug (rpmlib, GLIBC filtered): /bin/sh /usr/bin/alternatives ca-certificates config(java-25-openjdk-headless-slowdebug) crypto-policies cups-libs javapackages-filesystem libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libasound.so.2(ALSA_0.9.0rc4)(64bit) libc.so.6()(64bit) libm.so.6()(64bit) lksctp-tools(x86-64) nss rtld(GNU_HASH) tzdata-java java-25-openjdk-headless-fastdebug (rpmlib, GLIBC filtered): /bin/sh /usr/bin/alternatives ca-certificates config(java-25-openjdk-headless-fastdebug) crypto-policies cups-libs javapackages-filesystem libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libasound.so.2(ALSA_0.9.0rc4)(64bit) libc.so.6()(64bit) libm.so.6()(64bit) lksctp-tools(x86-64) nss rtld(GNU_HASH) tzdata-java java-25-openjdk-devel (rpmlib, GLIBC filtered): /bin/sh /usr/bin/alternatives java-25-openjdk(x86-64) libc.so.6()(64bit) rtld(GNU_HASH) java-25-openjdk-devel-slowdebug (rpmlib, GLIBC filtered): /bin/sh /usr/bin/alternatives java-25-openjdk-slowdebug(x86-64) libc.so.6()(64bit) rtld(GNU_HASH) java-25-openjdk-devel-fastdebug (rpmlib, GLIBC filtered): /bin/sh /usr/bin/alternatives java-25-openjdk-fastdebug(x86-64) libc.so.6()(64bit) rtld(GNU_HASH) java-25-openjdk-static-libs (rpmlib, GLIBC filtered): java-25-openjdk-devel(x86-64) java-25-openjdk-static-libs-slowdebug (rpmlib, GLIBC filtered): java-25-openjdk-devel-slowdebug(x86-64) java-25-openjdk-static-libs-fastdebug (rpmlib, GLIBC filtered): java-25-openjdk-devel-fastdebug(x86-64) java-25-openjdk-jmods (rpmlib, GLIBC filtered): java-25-openjdk-devel java-25-openjdk-jmods-slowdebug (rpmlib, GLIBC filtered): java-25-openjdk-devel-slowdebug java-25-openjdk-jmods-fastdebug (rpmlib, GLIBC filtered): java-25-openjdk-devel-fastdebug java-25-openjdk-demo (rpmlib, GLIBC filtered): java-25-openjdk(x86-64) java-25-openjdk-demo-slowdebug (rpmlib, GLIBC filtered): java-25-openjdk-slowdebug(x86-64) java-25-openjdk-demo-fastdebug (rpmlib, GLIBC filtered): java-25-openjdk-fastdebug(x86-64) java-25-openjdk-src (rpmlib, GLIBC filtered): java-25-openjdk-headless(x86-64) java-25-openjdk-src-slowdebug (rpmlib, GLIBC filtered): java-25-openjdk-headless-slowdebug(x86-64) java-25-openjdk-src-fastdebug (rpmlib, GLIBC filtered): java-25-openjdk-headless-fastdebug(x86-64) java-25-openjdk-javadoc (rpmlib, GLIBC filtered): /bin/sh /usr/bin/alternatives javapackages-filesystem java-25-openjdk-javadoc-zip (rpmlib, GLIBC filtered): /bin/sh /usr/bin/alternatives javapackages-filesystem Provides -------- java-25-openjdk: bundled(freetype) bundled(giflib) bundled(harfbuzz) bundled(lcms2) bundled(libjpeg) bundled(libpng) bundled(zlib) java-25 java-25-openjdk java-25-openjdk(x86-64) jre-25 jre-25-openjdk java-25-openjdk-slowdebug: java-25-openjdk-slowdebug java-25-openjdk-slowdebug(x86-64) java-25-slowdebug jre-25-openjdk-slowdebug jre-25-slowdebug java-25-openjdk-fastdebug: java-25-fastdebug java-25-openjdk-fastdebug java-25-openjdk-fastdebug(x86-64) jre-25-fastdebug jre-25-openjdk-fastdebug java-25-openjdk-headless: config(java-25-openjdk-headless) java-25-headless java-25-openjdk-headless java-25-openjdk-headless(x86-64) jre-25-headless jre-25-openjdk-headless libjsvml.so()(64bit) libsimdsort.so()(64bit) libsyslookup.so()(64bit) java-25-openjdk-headless-slowdebug: config(java-25-openjdk-headless-slowdebug) java-25-headless-slowdebug java-25-openjdk-headless-slowdebug java-25-openjdk-headless-slowdebug(x86-64) jre-25-headless-slowdebug jre-25-openjdk-headless-slowdebug libjsvml.so()(64bit) libsimdsort.so()(64bit) libsyslookup.so()(64bit) java-25-openjdk-headless-fastdebug: config(java-25-openjdk-headless-fastdebug) java-25-headless-fastdebug java-25-openjdk-headless-fastdebug java-25-openjdk-headless-fastdebug(x86-64) jre-25-headless-fastdebug jre-25-openjdk-headless-fastdebug libjsvml.so()(64bit) libsimdsort.so()(64bit) libsyslookup.so()(64bit) java-25-openjdk-devel: application() application(java-25-openjdk-jconsole.desktop) java-25-devel java-25-openjdk-devel java-25-openjdk-devel(x86-64) java-sdk-25 java-sdk-25-openjdk java-25-openjdk-devel-slowdebug: application() application(java-25-openjdk-slowdebug-jconsole-slowdebug.desktop) java-25-devel-slowdebug java-25-openjdk-devel-slowdebug java-25-openjdk-devel-slowdebug(x86-64) java-sdk-25-openjdk-slowdebug java-sdk-25-slowdebug java-25-openjdk-devel-fastdebug: application() application(java-25-openjdk-fastdebug-jconsole-fastdebug.desktop) java-25-devel-fastdebug java-25-openjdk-devel-fastdebug java-25-openjdk-devel-fastdebug(x86-64) java-sdk-25-fastdebug java-sdk-25-openjdk-fastdebug java-25-openjdk-static-libs: java-25-openjdk-static-libs java-25-openjdk-static-libs(x86-64) java-25-openjdk-static-libs-slowdebug: java-25-openjdk-static-libs-slowdebug java-25-openjdk-static-libs-slowdebug(x86-64) java-25-openjdk-static-libs-fastdebug: java-25-openjdk-static-libs-fastdebug java-25-openjdk-static-libs-fastdebug(x86-64) java-25-openjdk-jmods: java-25-jmods java-25-openjdk-jmods java-25-openjdk-jmods(x86-64) java-25-openjdk-jmods-slowdebug: java-25-jmods-slowdebug java-25-openjdk-jmods-slowdebug java-25-openjdk-jmods-slowdebug(x86-64) java-25-openjdk-jmods-fastdebug: java-25-jmods-fastdebug java-25-openjdk-jmods-fastdebug java-25-openjdk-jmods-fastdebug(x86-64) java-25-openjdk-demo: java-25-demo java-25-openjdk-demo java-25-openjdk-demo(x86-64) java-25-openjdk-demo-slowdebug: java-25-demo-slowdebug java-25-openjdk-demo-slowdebug java-25-openjdk-demo-slowdebug(x86-64) java-25-openjdk-demo-fastdebug: java-25-demo-fastdebug java-25-openjdk-demo-fastdebug java-25-openjdk-demo-fastdebug(x86-64) java-25-openjdk-src: java-25-openjdk-src java-25-openjdk-src(x86-64) java-25-src java-25-openjdk-src-slowdebug: java-25-openjdk-src-slowdebug java-25-openjdk-src-slowdebug(x86-64) java-25-src-slowdebug java-25-openjdk-src-fastdebug: java-25-openjdk-src-fastdebug java-25-openjdk-src-fastdebug(x86-64) java-25-src-fastdebug java-25-openjdk-javadoc: java-25-javadoc java-25-openjdk-javadoc java-25-openjdk-javadoc(x86-64) java-25-openjdk-javadoc-zip: java-25-javadoc java-25-javadoc-zip java-25-openjdk-javadoc java-25-openjdk-javadoc-zip java-25-openjdk-javadoc-zip(x86-64) Diff spec file in url and in SRPM --------------------------------- --- /home/jandrlik/2352963-java-25-openjdk/srpm/java-25-openjdk.spec 2025-03-19 16:08:34.977408862 +0100 +++ /home/jandrlik/2352963-java-25-openjdk/srpm-unpacked/java-25-openjdk.spec 2025-03-17 01:00:00.000000000 +0100 @@ -1,2 +1,7 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.7.3) +## RPMAUTOSPEC: autochangelog +## END: Set by rpmautospec + ## FIXME FIXME FIXME %define debug_package %{nil} @@ -2365,3 +2370,6 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Mon Mar 17 2025 Jiri <jvanek> - 1:25.0.0.0.13-1 +- Uncommitted changes +## END: Generated by rpmautospec Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2352963 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Java, C/C++, Perl Disabled plugins: R, Haskell, PHP, Python, SugarActivity, Ocaml, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Header files in -devel subpackage, if present. Note: java-25-openjdk-src See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text - The License field must be a valid SPDX expression. Note: Not a valid SPDX expression 'Apache-1.1 AND Apache-2.0 AND LicenseRef-Callaway-BSD AND LicenseRef-Callaway-BSD-with-advertising AND GPL-1.0-or-later AND GPL-2.0-only AND LicenseRef-Callaway-GPLv2-with- exceptions AND IJG AND LicenseRef-Callaway-LGPLv2+ AND LicenseRef- Callaway-MIT AND MPL-2.0 AND LicenseRef-Callaway-Public-Domain AND W3C AND Zlib AND ISC AND FTL AND LicenseRef-RSA'. See: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 - Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: java-25-openjdk-static-libs, java-25-openjdk- static-libs-slowdebug, java-25-openjdk-static-libs-fastdebug, java-25-openjdk-src, java-25-openjdk-src-slowdebug, java-25-openjdk-src- fastdebug. Illegal package name: java-25-openjdk-static-libs, java-25-openjdk-static-libs-slowdebug, java-25-openjdk-static-libs- fastdebug, java-25-openjdk-src, java-25-openjdk-src-slowdebug, java-25-openjdk-src-fastdebug. Does not provide -static: java-25-openjdk- static-libs, java-25-openjdk-static-libs-slowdebug, java-25-openjdk- static-libs-fastdebug, java-25-openjdk-src, java-25-openjdk-src- slowdebug, java-25-openjdk-src-fastdebug. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#packaging-static-libraries - gtk-update-icon-cache must not be invoked in %post and %posttrans for Fedora 26 and later. Note: icons in java-25-openjdk, java-25-openjdk-slowdebug, java-25-openjdk-fastdebug See: - Packages have proper BuildRequires/Requires on javapackages-tools (jpackage-utils) ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [!]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. java-25-openjdk-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libawt_xawt.so java-25-openjdk-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libjawt.so java-25-openjdk-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libsplashscreen.so java-25-openjdk-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libawt_xawt.so java-25-openjdk-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libjawt.so java-25-openjdk-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libsplashscreen.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libattach.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libawt.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libawt_headless.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libdt_socket.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libextnet.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libfontmanager.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libfreetype.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libinstrument.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libj2gss.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libj2pcsc.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libj2pkcs11.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libjaas.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libjava.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libjavajpeg.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libjdwp.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libjimage.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libjli.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libjsig.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libjsound.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libjsvml.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/liblcms.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libmanagement.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libmanagement_agent.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libmanagement_ext.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libmlib_image.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libnet.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libnio.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libprefs.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/librmi.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libsaproc.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libsctp.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libsimdsort.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libsyslookup.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libverify.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libzip.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/server/libjsig.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/server/libjvm.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libattach.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libawt.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libawt_headless.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libdt_socket.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libextnet.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libfontmanager.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libfreetype.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libinstrument.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libj2gss.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libj2pcsc.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libj2pkcs11.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libjaas.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libjava.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libjavajpeg.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libjdwp.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libjimage.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libjli.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libjsig.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libjsound.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libjsvml.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/liblcms.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libmanagement.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libmanagement_agent.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libmanagement_ext.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libmlib_image.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libnet.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libnio.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libprefs.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/librmi.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libsaproc.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libsctp.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libsimdsort.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libsyslookup.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libverify.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libzip.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/server/libjsig.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/server/libjvm.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libattach.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libawt.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libawt_headless.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libdt_socket.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libextnet.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libfontmanager.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libfreetype.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libinstrument.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libj2gss.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libj2pcsc.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libj2pkcs11.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libjaas.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libjava.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libjavajpeg.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libjdwp.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libjimage.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libjli.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libjsig.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libjsound.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libjsvml.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/liblcms.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libmanagement.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libmanagement_agent.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libmanagement_ext.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libmlib_image.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libnet.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libnio.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libprefs.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/librmi.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libsaproc.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libsctp.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libsimdsort.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libsyslookup.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libverify.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libzip.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/server/libjsig.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/server/libjvm.so java-25-openjdk-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libawt_xawt.so java-25-openjdk-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libjawt.so java-25-openjdk-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libsplashscreen.so [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [?]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/jvm/java-25-openjdk/lib/static/linux- amd64/glibc/server, /usr/lib/jvm/java-25-openjdk- slowdebug/lib/static/linux-amd64/glibc/server, /usr/lib/jvm/java-25-openjdk-fastdebug/lib/static/linux- amd64/glibc/server Reviewer note: look below. [?]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor, /usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor/48x48, /usr/lib/jvm/java-25-openjdk-slowdebug/lib/static/linux- amd64/glibc/server, /usr/lib/jvm/java-25-openjdk-fastdebug, /usr/lib/jvm/java-25-openjdk-fastdebug/lib, /usr/lib/jvm/java-25-openjdk-fastdebug/lib/static/linux- amd64/glibc/server, /usr/share/icons/hicolor/24x24, /usr/lib/jvm/java-25-openjdk-slowdebug/lib, /usr/lib/jvm/java-25-openjdk, /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor/32x32/apps, /usr/lib/jvm/java-25-openjdk/lib, /usr/share/icons/hicolor/16x16, /usr/lib/jvm/java-25-openjdk/lib/static/linux-amd64/glibc/server, /usr/lib/jvm, /usr/lib/jvm/java-25-openjdk-slowdebug, /usr/share/icons/hicolor/24x24/apps, /usr/share/icons/hicolor/16x16/apps Reviewer note: this looks wrong. [?]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /etc/.java(java-latest- openjdk-headless-fastdebug, java-21-openjdk-headless, java-latest- openjdk-headless-slowdebug, java-latest-openjdk-headless, java-21-openjdk-headless-slowdebug, java-21-openjdk-headless- fastdebug), /etc/.java/.systemPrefs(java-latest-openjdk-headless- fastdebug, java-21-openjdk-headless, java-latest-openjdk-headless- slowdebug, java-latest-openjdk-headless, java-21-openjdk-headless- slowdebug, java-21-openjdk-headless-fastdebug), /usr/share/systemtap(java-latest-openjdk-devel-slowdebug, systemtap- client, perl-devel, java-21-openjdk-devel-fastdebug, systemtap-devel, java-21-openjdk-devel-slowdebug, ruby-libs, sssd-common, java-21-openjdk-devel, java-latest-openjdk-devel, systemtap-jupyter, java-latest-openjdk-devel-fastdebug, systemtap-testsuite, glib2-devel), /usr/share/systemtap/tapset(java-latest-openjdk-devel- slowdebug, systemtap-client, perl-devel, java-21-openjdk-devel- fastdebug, systemtap-devel, java-21-openjdk-devel-slowdebug, pcp, ruby-libs, sssd-common, java-21-openjdk-devel, libvirt-libs, java- latest-openjdk-devel, java-latest-openjdk-devel-fastdebug, glib2-devel), /usr/share/systemtap/tapset/x86_64(java-latest-openjdk- devel-slowdebug, systemtap-client, java-21-openjdk-devel-fastdebug, systemtap-devel, java-21-openjdk-devel-slowdebug, java-21-openjdk- devel, java-latest-openjdk-devel, java-latest-openjdk-devel-fastdebug, glib2-devel) Reviewer note: I assume this one is ok. [x]: %build honors applicable compiler flags or justifies otherwise. [-]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: %config files are marked noreplace or the reason is justified. Note: No (noreplace) in %config /etc/java/java-25-openjdk/java-25-openjdk/conf/management/jmxremote.password.template %config /etc/java/java-25-openjdk/java-25-openjdk/conf/sdp/sdp.conf.template %config /etc/java/java-25-openjdk/java-25-openjdk- slowdebug/conf/management/jmxremote.password.template %config /etc/java/java-25-openjdk/java-25-openjdk- slowdebug/conf/sdp/sdp.conf.template %config /etc/java/java-25-openjdk/java-25-openjdk- fastdebug/conf/management/jmxremote.password.template %config /etc/java/java-25-openjdk/java-25-openjdk- fastdebug/conf/sdp/sdp.conf.template [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 36540 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: javapackages-tools (jpackage-utils) [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: Old add_to_maven_depmap macro is not being used Perl: [x]: Package contains the mandatory BuildRequires and Requires:. ===== SHOULD items ===== Generic: [?]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in java-25-openjdk-slowdebug , java-25-openjdk-fastdebug , java-25-openjdk-headless , java-25-openjdk-headless-slowdebug , java-25-openjdk-headless-fastdebug , java-25-openjdk-devel , java-25-openjdk-devel-slowdebug , java-25-openjdk-devel-fastdebug , java-25-openjdk-static-libs , java-25-openjdk-static-libs-slowdebug , java-25-openjdk-static-libs-fastdebug , java-25-openjdk-jmods , java-25-openjdk-jmods-slowdebug , java-25-openjdk-jmods-fastdebug , java-25-openjdk-demo , java-25-openjdk-demo-slowdebug , java-25-openjdk-demo-fastdebug , java-25-openjdk-src , java-25-openjdk-src-slowdebug , java-25-openjdk-src-fastdebug , java-25-openjdk-javadoc-zip [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments Reviewer note: IcedTea [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. Reviewer note: generated sources [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [?]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define debug_package %{nil}, %define __brp_strip_static_archive %{nil}, %define is_release_build() %( if [ "%{?1}" == "%{debug_suffix_unquoted}" -o "%{?1}" == "%{fastdebug_suffix_unquoted}" ]; then echo "0" ; else echo "1"; fi ), %define fullversion() %{expand:%{compatiblename}%{?1}-%{version}-%{release}}, %define uniquejavadocdir() %{expand:%{compatiblename}%{?1}}, %define uniquesuffix() %{expand:%{compatiblename}%{?1}}, %define etcjavadir() %{expand:%{etcjavasubdir}/%{uniquesuffix -- %{?1}}}, %define sdkdir() %{expand:%{uniquesuffix -- %{?1}}}, %define sdkbindir() %{expand:%{_jvmdir}/%{sdkdir -- %{?1}}/bin}, %define jrebindir() %{expand:%{_jvmdir}/%{sdkdir -- %{?1}}/bin}, %define post_script() %{expand:, %define priority_for() %{expand:%[%{?1:1}%{!?1:0} ? %{priority} - 1 : %{priority}]}, %define alternatives_java_install() %{expand:, %define post_headless() %{expand:, %define postun_script() %{expand:, %define preun_headless() %{expand:, %define posttrans_script() %{expand:, %define alternatives_javac_install() %{expand:, %define post_devel() %{expand:, %define preun_devel() %{expand:, %define postun_devel() %{expand:, %define posttrans_devel() %{expand:, %define alternatives_javadoc_install() %{expand:, %define preun_javadoc() %{expand:, %define alternatives_javadoczip_install() %{expand:, %define preun_javadoc_zip() %{expand:, %define files_jre() %{expand:, %define files_jre_headless() %{expand:, %define files_devel() %{expand:, %define files_jmods() %{expand:, %define files_demo() %{expand:, %define files_src() %{expand:, %define files_static_libs() %{expand:, %define files_javadoc() %{expand:, %define files_javadoc_zip() %{expand:, %define java_rpo() %{expand:, %define java_headless_rpo() %{expand:, %define java_devel_rpo() %{expand:, %define java_static_libs_rpo() %{expand:, %define java_jmods_rpo() %{expand:, %define java_demo_rpo() %{expand:, %define java_javadoc_rpo() %{expand:, %define java_src_rpo() %{expand:, %define lua_delete_old_link() %{expand: Reviewer note: ## FIXME FIXME FIXME %define debug_package %{nil} ## FIXME FIXME FIXME the above looks wrong. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. Java: [x]: Packages are noarch unless they use JNI Note: java-25-openjdk subpackage is not noarch. Please verify manually Reviewer note: uses JNI [x]: Package uses upstream build method (ant/maven/etc.) ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 734238720 bytes in /usr/share java-25-openjdk-javadoc-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm:337930240, java-25-openjdk-javadoc- zip-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm:395110400 See: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Requires -------- java-25-openjdk (rpmlib, GLIBC filtered): /bin/sh fontconfig(x86-64) java-25-openjdk-headless(x86-64) libX11.so.6()(64bit) libXcomposite(x86-64) libXext.so.6()(64bit) libXi.so.6()(64bit) libXrender.so.1()(64bit) libXtst.so.6()(64bit) libc.so.6()(64bit) libm.so.6()(64bit) rtld(GNU_HASH) xorg-x11-fonts-Type1 java-25-openjdk-slowdebug (rpmlib, GLIBC filtered): /bin/sh fontconfig(x86-64) java-25-openjdk-headless-slowdebug(x86-64) libX11.so.6()(64bit) libXcomposite(x86-64) libXext.so.6()(64bit) libXi.so.6()(64bit) libXrender.so.1()(64bit) libXtst.so.6()(64bit) libc.so.6()(64bit) libm.so.6()(64bit) rtld(GNU_HASH) xorg-x11-fonts-Type1 java-25-openjdk-fastdebug (rpmlib, GLIBC filtered): /bin/sh fontconfig(x86-64) java-25-openjdk-headless-fastdebug(x86-64) libX11.so.6()(64bit) libXcomposite(x86-64) libXext.so.6()(64bit) libXi.so.6()(64bit) libXrender.so.1()(64bit) libXtst.so.6()(64bit) libc.so.6()(64bit) libm.so.6()(64bit) rtld(GNU_HASH) xorg-x11-fonts-Type1 java-25-openjdk-headless (rpmlib, GLIBC filtered): /bin/sh /usr/bin/alternatives ca-certificates config(java-25-openjdk-headless) crypto-policies cups-libs javapackages-filesystem libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libasound.so.2(ALSA_0.9.0rc4)(64bit) libc.so.6()(64bit) libm.so.6()(64bit) lksctp-tools(x86-64) nss rtld(GNU_HASH) tzdata-java java-25-openjdk-headless-slowdebug (rpmlib, GLIBC filtered): /bin/sh /usr/bin/alternatives ca-certificates config(java-25-openjdk-headless-slowdebug) crypto-policies cups-libs javapackages-filesystem libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libasound.so.2(ALSA_0.9.0rc4)(64bit) libc.so.6()(64bit) libm.so.6()(64bit) lksctp-tools(x86-64) nss rtld(GNU_HASH) tzdata-java java-25-openjdk-headless-fastdebug (rpmlib, GLIBC filtered): /bin/sh /usr/bin/alternatives ca-certificates config(java-25-openjdk-headless-fastdebug) crypto-policies cups-libs javapackages-filesystem libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libasound.so.2(ALSA_0.9.0rc4)(64bit) libc.so.6()(64bit) libm.so.6()(64bit) lksctp-tools(x86-64) nss rtld(GNU_HASH) tzdata-java java-25-openjdk-devel (rpmlib, GLIBC filtered): /bin/sh /usr/bin/alternatives java-25-openjdk(x86-64) libc.so.6()(64bit) rtld(GNU_HASH) java-25-openjdk-devel-slowdebug (rpmlib, GLIBC filtered): /bin/sh /usr/bin/alternatives java-25-openjdk-slowdebug(x86-64) libc.so.6()(64bit) rtld(GNU_HASH) java-25-openjdk-devel-fastdebug (rpmlib, GLIBC filtered): /bin/sh /usr/bin/alternatives java-25-openjdk-fastdebug(x86-64) libc.so.6()(64bit) rtld(GNU_HASH) java-25-openjdk-static-libs (rpmlib, GLIBC filtered): java-25-openjdk-devel(x86-64) java-25-openjdk-static-libs-slowdebug (rpmlib, GLIBC filtered): java-25-openjdk-devel-slowdebug(x86-64) java-25-openjdk-static-libs-fastdebug (rpmlib, GLIBC filtered): java-25-openjdk-devel-fastdebug(x86-64) java-25-openjdk-jmods (rpmlib, GLIBC filtered): java-25-openjdk-devel java-25-openjdk-jmods-slowdebug (rpmlib, GLIBC filtered): java-25-openjdk-devel-slowdebug java-25-openjdk-jmods-fastdebug (rpmlib, GLIBC filtered): java-25-openjdk-devel-fastdebug java-25-openjdk-demo (rpmlib, GLIBC filtered): java-25-openjdk(x86-64) java-25-openjdk-demo-slowdebug (rpmlib, GLIBC filtered): java-25-openjdk-slowdebug(x86-64) java-25-openjdk-demo-fastdebug (rpmlib, GLIBC filtered): java-25-openjdk-fastdebug(x86-64) java-25-openjdk-src (rpmlib, GLIBC filtered): java-25-openjdk-headless(x86-64) java-25-openjdk-src-slowdebug (rpmlib, GLIBC filtered): java-25-openjdk-headless-slowdebug(x86-64) java-25-openjdk-src-fastdebug (rpmlib, GLIBC filtered): java-25-openjdk-headless-fastdebug(x86-64) java-25-openjdk-javadoc (rpmlib, GLIBC filtered): /bin/sh /usr/bin/alternatives javapackages-filesystem java-25-openjdk-javadoc-zip (rpmlib, GLIBC filtered): /bin/sh /usr/bin/alternatives javapackages-filesystem Provides -------- java-25-openjdk: bundled(freetype) bundled(giflib) bundled(harfbuzz) bundled(lcms2) bundled(libjpeg) bundled(libpng) bundled(zlib) java-25 java-25-openjdk java-25-openjdk(x86-64) jre-25 jre-25-openjdk java-25-openjdk-slowdebug: java-25-openjdk-slowdebug java-25-openjdk-slowdebug(x86-64) java-25-slowdebug jre-25-openjdk-slowdebug jre-25-slowdebug java-25-openjdk-fastdebug: java-25-fastdebug java-25-openjdk-fastdebug java-25-openjdk-fastdebug(x86-64) jre-25-fastdebug jre-25-openjdk-fastdebug java-25-openjdk-headless: config(java-25-openjdk-headless) java-25-headless java-25-openjdk-headless java-25-openjdk-headless(x86-64) jre-25-headless jre-25-openjdk-headless libjsvml.so()(64bit) libsimdsort.so()(64bit) libsyslookup.so()(64bit) java-25-openjdk-headless-slowdebug: config(java-25-openjdk-headless-slowdebug) java-25-headless-slowdebug java-25-openjdk-headless-slowdebug java-25-openjdk-headless-slowdebug(x86-64) jre-25-headless-slowdebug jre-25-openjdk-headless-slowdebug libjsvml.so()(64bit) libsimdsort.so()(64bit) libsyslookup.so()(64bit) java-25-openjdk-headless-fastdebug: config(java-25-openjdk-headless-fastdebug) java-25-headless-fastdebug java-25-openjdk-headless-fastdebug java-25-openjdk-headless-fastdebug(x86-64) jre-25-headless-fastdebug jre-25-openjdk-headless-fastdebug libjsvml.so()(64bit) libsimdsort.so()(64bit) libsyslookup.so()(64bit) java-25-openjdk-devel: application() application(java-25-openjdk-jconsole.desktop) java-25-devel java-25-openjdk-devel java-25-openjdk-devel(x86-64) java-sdk-25 java-sdk-25-openjdk java-25-openjdk-devel-slowdebug: application() application(java-25-openjdk-slowdebug-jconsole-slowdebug.desktop) java-25-devel-slowdebug java-25-openjdk-devel-slowdebug java-25-openjdk-devel-slowdebug(x86-64) java-sdk-25-openjdk-slowdebug java-sdk-25-slowdebug java-25-openjdk-devel-fastdebug: application() application(java-25-openjdk-fastdebug-jconsole-fastdebug.desktop) java-25-devel-fastdebug java-25-openjdk-devel-fastdebug java-25-openjdk-devel-fastdebug(x86-64) java-sdk-25-fastdebug java-sdk-25-openjdk-fastdebug java-25-openjdk-static-libs: java-25-openjdk-static-libs java-25-openjdk-static-libs(x86-64) java-25-openjdk-static-libs-slowdebug: java-25-openjdk-static-libs-slowdebug java-25-openjdk-static-libs-slowdebug(x86-64) java-25-openjdk-static-libs-fastdebug: java-25-openjdk-static-libs-fastdebug java-25-openjdk-static-libs-fastdebug(x86-64) java-25-openjdk-jmods: java-25-jmods java-25-openjdk-jmods java-25-openjdk-jmods(x86-64) java-25-openjdk-jmods-slowdebug: java-25-jmods-slowdebug java-25-openjdk-jmods-slowdebug java-25-openjdk-jmods-slowdebug(x86-64) java-25-openjdk-jmods-fastdebug: java-25-jmods-fastdebug java-25-openjdk-jmods-fastdebug java-25-openjdk-jmods-fastdebug(x86-64) java-25-openjdk-demo: java-25-demo java-25-openjdk-demo java-25-openjdk-demo(x86-64) java-25-openjdk-demo-slowdebug: java-25-demo-slowdebug java-25-openjdk-demo-slowdebug java-25-openjdk-demo-slowdebug(x86-64) java-25-openjdk-demo-fastdebug: java-25-demo-fastdebug java-25-openjdk-demo-fastdebug java-25-openjdk-demo-fastdebug(x86-64) java-25-openjdk-src: java-25-openjdk-src java-25-openjdk-src(x86-64) java-25-src java-25-openjdk-src-slowdebug: java-25-openjdk-src-slowdebug java-25-openjdk-src-slowdebug(x86-64) java-25-src-slowdebug java-25-openjdk-src-fastdebug: java-25-openjdk-src-fastdebug java-25-openjdk-src-fastdebug(x86-64) java-25-src-fastdebug java-25-openjdk-javadoc: java-25-javadoc java-25-openjdk-javadoc java-25-openjdk-javadoc(x86-64) java-25-openjdk-javadoc-zip: java-25-javadoc java-25-javadoc-zip java-25-openjdk-javadoc java-25-openjdk-javadoc-zip java-25-openjdk-javadoc-zip(x86-64) Diff spec file in url and in SRPM --------------------------------- --- /home/jandrlik/2352963-java-25-openjdk/srpm/java-25-openjdk.spec 2025-03-19 16:08:34.977408862 +0100 +++ /home/jandrlik/2352963-java-25-openjdk/srpm-unpacked/java-25-openjdk.spec 2025-03-17 01:00:00.000000000 +0100 @@ -1,2 +1,7 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.7.3) +## RPMAUTOSPEC: autochangelog +## END: Set by rpmautospec + ## FIXME FIXME FIXME %define debug_package %{nil} @@ -2365,3 +2370,6 @@ %changelog -%autochangelog +## START: Generated by rpmautospec +* Mon Mar 17 2025 Jiri <jvanek> - 1:25.0.0.0.13-1 +- Uncommitted changes +## END: Generated by rpmautospec Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2352963 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Java, C/C++, Perl Disabled plugins: R, Haskell, PHP, Python, SugarActivity, Ocaml, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH @jvanek please it would mean a lot if you could comment on the points where I put "?" or "!". Thanks!
[!]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. java-25-openjdk-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libawt_xawt.so java-25-openjdk-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libjawt.so java-25-openjdk-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libsplashscreen.so java-25-openjdk-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libawt_xawt.so java-25-openjdk-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libjawt.so java-25-openjdk-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libsplashscreen.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libattach.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libawt.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libawt_headless.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libdt_socket.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libextnet.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libfontmanager.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libfreetype.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libinstrument.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libj2gss.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libj2pcsc.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libj2pkcs11.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libjaas.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libjava.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libjavajpeg.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libjdwp.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libjimage.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libjli.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libjsig.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libjsound.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libjsvml.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/liblcms.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libmanagement.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libmanagement_agent.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libmanagement_ext.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libmlib_image.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libnet.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libnio.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libprefs.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/librmi.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libsaproc.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libsctp.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libsimdsort.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libsyslookup.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libverify.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libzip.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/server/libjsig.so java-25-openjdk-headless-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/server/libjvm.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libattach.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libawt.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libawt_headless.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libdt_socket.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libextnet.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libfontmanager.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libfreetype.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libinstrument.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libj2gss.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libj2pcsc.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libj2pkcs11.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libjaas.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libjava.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libjavajpeg.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libjdwp.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libjimage.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libjli.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libjsig.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libjsound.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libjsvml.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/liblcms.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libmanagement.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libmanagement_agent.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libmanagement_ext.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libmlib_image.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libnet.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libnio.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libprefs.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/librmi.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libsaproc.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libsctp.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libsimdsort.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libsyslookup.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libverify.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/libzip.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/server/libjsig.so java-25-openjdk-headless-fastdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-fastdebug/lib/server/libjvm.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libattach.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libawt.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libawt_headless.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libdt_socket.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libextnet.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libfontmanager.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libfreetype.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libinstrument.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libj2gss.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libj2pcsc.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libj2pkcs11.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libjaas.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libjava.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libjavajpeg.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libjdwp.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libjimage.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libjli.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libjsig.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libjsound.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libjsvml.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/liblcms.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libmanagement.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libmanagement_agent.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libmanagement_ext.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libmlib_image.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libnet.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libnio.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libprefs.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/librmi.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libsaproc.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libsctp.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libsimdsort.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libsyslookup.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libverify.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libzip.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/server/libjsig.so java-25-openjdk-headless-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/server/libjvm.so java-25-openjdk-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libawt_xawt.so java-25-openjdk-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libjawt.so java-25-openjdk-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libsplashscreen.so [?]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/jvm/java-25-openjdk/lib/static/linux- amd64/glibc/server, /usr/lib/jvm/java-25-openjdk- slowdebug/lib/static/linux-amd64/glibc/server, /usr/lib/jvm/java-25-openjdk-fastdebug/lib/static/linux- amd64/glibc/server Reviewer note: look below. [?]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor, /usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor/48x48, /usr/lib/jvm/java-25-openjdk-slowdebug/lib/static/linux- amd64/glibc/server, /usr/lib/jvm/java-25-openjdk-fastdebug, /usr/lib/jvm/java-25-openjdk-fastdebug/lib, /usr/lib/jvm/java-25-openjdk-fastdebug/lib/static/linux- amd64/glibc/server, /usr/share/icons/hicolor/24x24, /usr/lib/jvm/java-25-openjdk-slowdebug/lib, /usr/lib/jvm/java-25-openjdk, /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor/32x32/apps, /usr/lib/jvm/java-25-openjdk/lib, /usr/share/icons/hicolor/16x16, /usr/lib/jvm/java-25-openjdk/lib/static/linux-amd64/glibc/server, /usr/lib/jvm, /usr/lib/jvm/java-25-openjdk-slowdebug, /usr/share/icons/hicolor/24x24/apps, /usr/share/icons/hicolor/16x16/apps Reviewer note: this looks wrong. [?]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /etc/.java(java-latest- openjdk-headless-fastdebug, java-21-openjdk-headless, java-latest- openjdk-headless-slowdebug, java-latest-openjdk-headless, java-21-openjdk-headless-slowdebug, java-21-openjdk-headless- fastdebug), /etc/.java/.systemPrefs(java-latest-openjdk-headless- fastdebug, java-21-openjdk-headless, java-latest-openjdk-headless- slowdebug, java-latest-openjdk-headless, java-21-openjdk-headless- slowdebug, java-21-openjdk-headless-fastdebug), /usr/share/systemtap(java-latest-openjdk-devel-slowdebug, systemtap- client, perl-devel, java-21-openjdk-devel-fastdebug, systemtap-devel, java-21-openjdk-devel-slowdebug, ruby-libs, sssd-common, java-21-openjdk-devel, java-latest-openjdk-devel, systemtap-jupyter, java-latest-openjdk-devel-fastdebug, systemtap-testsuite, glib2-devel), /usr/share/systemtap/tapset(java-latest-openjdk-devel- slowdebug, systemtap-client, perl-devel, java-21-openjdk-devel- fastdebug, systemtap-devel, java-21-openjdk-devel-slowdebug, pcp, ruby-libs, sssd-common, java-21-openjdk-devel, libvirt-libs, java- latest-openjdk-devel, java-latest-openjdk-devel-fastdebug, glib2-devel), /usr/share/systemtap/tapset/x86_64(java-latest-openjdk- devel-slowdebug, systemtap-client, java-21-openjdk-devel-fastdebug, systemtap-devel, java-21-openjdk-devel-slowdebug, java-21-openjdk- devel, java-latest-openjdk-devel, java-latest-openjdk-devel-fastdebug, glib2-devel) Reviewer note: I assume this one is ok. [?]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in java-25-openjdk-slowdebug , java-25-openjdk-fastdebug , java-25-openjdk-headless , java-25-openjdk-headless-slowdebug , java-25-openjdk-headless-fastdebug , java-25-openjdk-devel , java-25-openjdk-devel-slowdebug , java-25-openjdk-devel-fastdebug , java-25-openjdk-static-libs , java-25-openjdk-static-libs-slowdebug , java-25-openjdk-static-libs-fastdebug , java-25-openjdk-jmods , java-25-openjdk-jmods-slowdebug , java-25-openjdk-jmods-fastdebug , java-25-openjdk-demo , java-25-openjdk-demo-slowdebug , java-25-openjdk-demo-fastdebug , java-25-openjdk-src , java-25-openjdk-src-slowdebug , java-25-openjdk-src-fastdebug , java-25-openjdk-javadoc-zip [?]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define debug_package %{nil}, %define __brp_strip_static_archive %{nil}, %define is_release_build() %( if [ "%{?1}" == "%{debug_suffix_unquoted}" -o "%{?1}" == "%{fastdebug_suffix_unquoted}" ]; then echo "0" ; else echo "1"; fi ), %define fullversion() %{expand:%{compatiblename}%{?1}-%{version}-%{release}}, %define uniquejavadocdir() %{expand:%{compatiblename}%{?1}}, %define uniquesuffix() %{expand:%{compatiblename}%{?1}}, %define etcjavadir() %{expand:%{etcjavasubdir}/%{uniquesuffix -- %{?1}}}, %define sdkdir() %{expand:%{uniquesuffix -- %{?1}}}, %define sdkbindir() %{expand:%{_jvmdir}/%{sdkdir -- %{?1}}/bin}, %define jrebindir() %{expand:%{_jvmdir}/%{sdkdir -- %{?1}}/bin}, %define post_script() %{expand:, %define priority_for() %{expand:%[%{?1:1}%{!?1:0} ? %{priority} - 1 : %{priority}]}, %define alternatives_java_install() %{expand:, %define post_headless() %{expand:, %define postun_script() %{expand:, %define preun_headless() %{expand:, %define posttrans_script() %{expand:, %define alternatives_javac_install() %{expand:, %define post_devel() %{expand:, %define preun_devel() %{expand:, %define postun_devel() %{expand:, %define posttrans_devel() %{expand:, %define alternatives_javadoc_install() %{expand:, %define preun_javadoc() %{expand:, %define alternatives_javadoczip_install() %{expand:, %define preun_javadoc_zip() %{expand:, %define files_jre() %{expand:, %define files_jre_headless() %{expand:, %define files_devel() %{expand:, %define files_jmods() %{expand:, %define files_demo() %{expand:, %define files_src() %{expand:, %define files_static_libs() %{expand:, %define files_javadoc() %{expand:, %define files_javadoc_zip() %{expand:, %define java_rpo() %{expand:, %define java_headless_rpo() %{expand:, %define java_devel_rpo() %{expand:, %define java_static_libs_rpo() %{expand:, %define java_jmods_rpo() %{expand:, %define java_demo_rpo() %{expand:, %define java_javadoc_rpo() %{expand:, %define java_src_rpo() %{expand:, %define lua_delete_old_link() %{expand: Reviewer note: ## FIXME FIXME FIXME %define debug_package %{nil} ## FIXME FIXME FIXME the above looks wrong. [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 734238720 bytes in /usr/share java-25-openjdk-javadoc-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm:337930240, java-25-openjdk-javadoc- zip-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm:395110400 See: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL)
[!]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. java-25-openjdk-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk/lib/libawt_xawt.so ... java-25-openjdk-slowdebug-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm/usr/lib/jvm/java-25-openjdk-slowdebug/lib/libsplashscreen.so [jv] This is ok. They are no not on LD_PATH and are JDK private. [?]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/jvm/java-25-openjdk/lib/static/linux- amd64/glibc/server, /usr/lib/jvm/java-25-openjdk- slowdebug/lib/static/linux-amd64/glibc/server, /usr/lib/jvm/java-25-openjdk-fastdebug/lib/static/linux- amd64/glibc/server Reviewer note: look below. [jv] This tis looks indeed wrong. Will elaborate. [?]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor, /usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor/48x48, .... /usr/share/icons/hicolor/16x16/apps Reviewer note: this looks wrong. [jv] This tis looks indeed wrong. Will elaborate. [?]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /etc/.java(java-latest- ... devel, java-latest-openjdk-devel, java-latest-openjdk-devel-fastdebug, glib2-devel) Reviewer note: I assume this one is ok. [jv] tbh, not sure Looks good to me too, but maybe it is just lack of specifick nowledge. [?]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [jv] I'm not aware of any fonts inside, if they are here, they are not published and are jdk internal only [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in java-25-openjdk-slowdebug , java-25-openjdk-fastdebug , java-25-openjdk-headless , java-25-openjdk-headless-slowdebug , java-25-openjdk-headless-fastdebug , java-25-openjdk-devel , java-25-openjdk-devel-slowdebug , java-25-openjdk-devel-fastdebug , java-25-openjdk-static-libs , java-25-openjdk-static-libs-slowdebug , java-25-openjdk-static-libs-fastdebug , java-25-openjdk-jmods , java-25-openjdk-jmods-slowdebug , java-25-openjdk-jmods-fastdebug , java-25-openjdk-demo , java-25-openjdk-demo-slowdebug , java-25-openjdk-demo-fastdebug , java-25-openjdk-src , java-25-openjdk-src-slowdebug , java-25-openjdk-src-fastdebug , java-25-openjdk-javadoc-zip [jv] All subpakcages are correctly requiring is variant wehre applicable. In additional base of everything is -headless subpackage. demo and javadocs and soources can indeed be instaleld spearately. This is ok [?]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define debug_package %{nil}, %define __brp_strip_static_archive %{nil}, %define is_release_build() ... [jv] This is ok. Those prametrised macros do nto work as expected when moved to global. Reviewer note: ## FIXME FIXME FIXME %define debug_package %{nil} ## FIXME FIXME FIXME the above looks wrong. [jv] This is indeed wrong. However fix is currentlyt not known. It popped up when I updated to jdk23->jdk24, and remians present in jdk25. However it can now be called feature, as it is the only reason why jlink will work. So my goal is to fix jlink, which musst be fixed in portbales first. Once it is done, I will make jlink work also from rpms, and once all this is fixed, I willr eturn to debuginfo, which must be fixed with jmodless-jlink in mind. It may happen teat %define debug_package will be the only solution for that [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 734238720 bytes in /usr/share java-25-openjdk-javadoc-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm:337930240, java-25-openjdk-javadoc- zip-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm:395110400 See: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [jv] that is javadoc, thats ok. It is really big, and really per-platform different. [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [jv] I saw that. It seems itt is related only to comments and autochangelog. So ok?
updated review (only two failures should remain): Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/jvm/java-25-openjdk/lib/static/linux- amd64/glibc/server, /usr/lib/jvm/java-25-openjdk- slowdebug/lib/static/linux-amd64/glibc/server, /usr/lib/jvm/java-25-openjdk-fastdebug/lib/static/linux- amd64/glibc/server [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor, /usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor/48x48, /usr/lib/jvm/java-25-openjdk-slowdebug/lib/static/linux- amd64/glibc/server, /usr/lib/jvm/java-25-openjdk-fastdebug, /usr/lib/jvm/java-25-openjdk-fastdebug/lib, /usr/lib/jvm/java-25-openjdk-fastdebug/lib/static/linux- amd64/glibc/server, /usr/share/icons/hicolor/24x24, /usr/lib/jvm/java-25-openjdk-slowdebug/lib, /usr/lib/jvm/java-25-openjdk, /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor/32x32/apps, /usr/lib/jvm/java-25-openjdk/lib, /usr/share/icons/hicolor/16x16, /usr/lib/jvm/java-25-openjdk/lib/static/linux-amd64/glibc/server, /usr/lib/jvm, /usr/lib/jvm/java-25-openjdk-slowdebug, /usr/share/icons/hicolor/24x24/apps, /usr/share/icons/hicolor/16x16/apps [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /etc/.java(java-latest- openjdk-headless-fastdebug, java-21-openjdk-headless, java-latest- openjdk-headless-slowdebug, java-latest-openjdk-headless, java-21-openjdk-headless-slowdebug, java-21-openjdk-headless- fastdebug), /etc/.java/.systemPrefs(java-latest-openjdk-headless- fastdebug, java-21-openjdk-headless, java-latest-openjdk-headless- slowdebug, java-latest-openjdk-headless, java-21-openjdk-headless- slowdebug, java-21-openjdk-headless-fastdebug), /usr/share/systemtap(java-latest-openjdk-devel-slowdebug, systemtap- client, perl-devel, java-21-openjdk-devel-fastdebug, systemtap-devel, java-21-openjdk-devel-slowdebug, ruby-libs, sssd-common, java-21-openjdk-devel, java-latest-openjdk-devel, systemtap-jupyter, java-latest-openjdk-devel-fastdebug, systemtap-testsuite, glib2-devel), /usr/share/systemtap/tapset(java-latest-openjdk-devel- slowdebug, systemtap-client, perl-devel, java-21-openjdk-devel- fastdebug, systemtap-devel, java-21-openjdk-devel-slowdebug, pcp, ruby-libs, sssd-common, java-21-openjdk-devel, libvirt-libs, java- latest-openjdk-devel, java-latest-openjdk-devel-fastdebug, glib2-devel), /usr/share/systemtap/tapset/x86_64(java-latest-openjdk- devel-slowdebug, systemtap-client, java-21-openjdk-devel-fastdebug, systemtap-devel, java-21-openjdk-devel-slowdebug, java-21-openjdk- devel, java-latest-openjdk-devel, java-latest-openjdk-devel-fastdebug, glib2-devel) Reviewer note: I assume this one is ok. [x]: %build honors applicable compiler flags or justifies otherwise. [-]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: %config files are marked noreplace or the reason is justified. Note: No (noreplace) in %config /etc/java/java-25-openjdk/java-25-openjdk/conf/management/jmxremote.password.template %config /etc/java/java-25-openjdk/java-25-openjdk/conf/sdp/sdp.conf.template %config /etc/java/java-25-openjdk/java-25-openjdk- slowdebug/conf/management/jmxremote.password.template %config /etc/java/java-25-openjdk/java-25-openjdk- slowdebug/conf/sdp/sdp.conf.template %config /etc/java/java-25-openjdk/java-25-openjdk- fastdebug/conf/management/jmxremote.password.template %config /etc/java/java-25-openjdk/java-25-openjdk- fastdebug/conf/sdp/sdp.conf.template [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 36540 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: javapackages-tools (jpackage-utils) [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: Old add_to_maven_depmap macro is not being used Perl: [x]: Package contains the mandatory BuildRequires and Requires:. ===== SHOULD items ===== Generic: [x]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in java-25-openjdk-slowdebug , java-25-openjdk-fastdebug , java-25-openjdk-headless , java-25-openjdk-headless-slowdebug , java-25-openjdk-headless-fastdebug , java-25-openjdk-devel , java-25-openjdk-devel-slowdebug , java-25-openjdk-devel-fastdebug , java-25-openjdk-static-libs , java-25-openjdk-static-libs-slowdebug , java-25-openjdk-static-libs-fastdebug , java-25-openjdk-jmods , java-25-openjdk-jmods-slowdebug , java-25-openjdk-jmods-fastdebug , java-25-openjdk-demo , java-25-openjdk-demo-slowdebug , java-25-openjdk-demo-fastdebug , java-25-openjdk-src , java-25-openjdk-src-slowdebug , java-25-openjdk-src-fastdebug , java-25-openjdk-javadoc-zip [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments Reviewer note: IcedTea [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. Reviewer note: generated sources [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define debug_package %{nil}, %define __brp_strip_static_archive %{nil}, %define is_release_build() %( if [ "%{?1}" == "%{debug_suffix_unquoted}" -o "%{?1}" == "%{fastdebug_suffix_unquoted}" ]; then echo "0" ; else echo "1"; fi ), %define fullversion() %{expand:%{compatiblename}%{?1}-%{version}-%{release}}, %define uniquejavadocdir() %{expand:%{compatiblename}%{?1}}, %define uniquesuffix() %{expand:%{compatiblename}%{?1}}, %define etcjavadir() %{expand:%{etcjavasubdir}/%{uniquesuffix -- %{?1}}}, %define sdkdir() %{expand:%{uniquesuffix -- %{?1}}}, %define sdkbindir() %{expand:%{_jvmdir}/%{sdkdir -- %{?1}}/bin}, %define jrebindir() %{expand:%{_jvmdir}/%{sdkdir -- %{?1}}/bin}, %define post_script() %{expand:, %define priority_for() %{expand:%[%{?1:1}%{!?1:0} ? %{priority} - 1 : %{priority}]}, %define alternatives_java_install() %{expand:, %define post_headless() %{expand:, %define postun_script() %{expand:, %define preun_headless() %{expand:, %define posttrans_script() %{expand:, %define alternatives_javac_install() %{expand:, %define post_devel() %{expand:, %define preun_devel() %{expand:, %define postun_devel() %{expand:, %define posttrans_devel() %{expand:, %define alternatives_javadoc_install() %{expand:, %define preun_javadoc() %{expand:, %define alternatives_javadoczip_install() %{expand:, %define preun_javadoc_zip() %{expand:, %define files_jre() %{expand:, %define files_jre_headless() %{expand:, %define files_devel() %{expand:, %define files_jmods() %{expand:, %define files_demo() %{expand:, %define files_src() %{expand:, %define files_static_libs() %{expand:, %define files_javadoc() %{expand:, %define files_javadoc_zip() %{expand:, %define java_rpo() %{expand:, %define java_headless_rpo() %{expand:, %define java_devel_rpo() %{expand:, %define java_static_libs_rpo() %{expand:, %define java_jmods_rpo() %{expand:, %define java_demo_rpo() %{expand:, %define java_javadoc_rpo() %{expand:, %define java_src_rpo() %{expand:, %define lua_delete_old_link() %{expand: Reviewer note: ## FIXME FIXME FIXME %define debug_package %{nil} ## FIXME FIXME FIXME the above looks wrong, but is promised to be looked at later. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. Java: [x]: Packages are noarch unless they use JNI Note: java-25-openjdk subpackage is not noarch. Please verify manually Reviewer note: uses JNI [x]: Package uses upstream build method (ant/maven/etc.) ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 734238720 bytes in /usr/share java-25-openjdk-javadoc-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm:337930240, java-25-openjdk-javadoc- zip-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm:395110400 See: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [x]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment).
rpm -qf /usr/share/icons/hicolor/ appimagelauncher-2.2.0-travis995~0f91801.x86_64 fedora-logos-38.1.0-6.fc41.noarch hicolor-icon-theme-0.17-19.fc41.noarch qemu-common-9.1.3-2.fc41.x86_64 rpm -qf /usr/share/icons/hicolor/32... appimagelauncher-2.2.0-travis995~0f91801.x86_64 fedora-logos-38.1.0-6.fc41.noarch hicolor-icon-theme-0.17-19.fc41.noarch qemu-common-9.1.3-2.fc41.x86_64 rpm -qf /usr/share/systemtap/ python2.7-2.7.18-43.fc40.x86_64 ruby-libs-3.3.7-18.fc41.x86_64 glib2-devel-2.82.2-1.fc41.x86_64 sssd-common-2.10.2-1.fc41.x86_64 java-21-openjdk-devel-21.0.6.0.7-6.fc41.x86_64 perl-devel-5.40.1-514.fc41.x86_64 java-latest-openjdk-devel-24.0.0.0.36-1.rolling.fc41.x86_64 Fixing the others. TY sir!
rpm -qf /usr/lib/jvm javapackages-filesystem-6.2.0-14.fc41.noarch # Require javapackages-filesystem for ownership of /usr/lib/jvm/ and macros Requires: javapackages-filesystem
https://src.fedoraproject.org/fork/jvanek/rpms/java-latest-openjdk/c/d0a49b45847e3aa72bc50a0dbae37294f6cbc863?branch=jdk25 https://koji.fedoraproject.org/koji/taskinfo?taskID=130559412 Should be fixed now Spec URL: https://src.fedoraproject.org/fork/jvanek/rpms/java-latest-openjdk/raw/jdk25/f/java-25-openjdk.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/9416/130559416/java-25-openjdk-25.0.0.0.13-0.1.ea.fc43.src.rpm Description: OpenJDK 25 Runtime Environment Fedora Account System Username: jvanek
Created attachment 2081256 [details] The .spec file difference from Copr build 8777944 to 8801120
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor, /usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor/48x48, /usr/lib/jvm/java-25-openjdk-slowdebug/lib/static/linux- amd64/glibc/server, /usr/lib/jvm/java-25-openjdk-fastdebug, /usr/lib/jvm/java-25-openjdk-fastdebug/lib, /usr/lib/jvm/java-25-openjdk-fastdebug/lib/static/linux- amd64/glibc/server, /usr/share/icons/hicolor/24x24, /usr/lib/jvm/java-25-openjdk-slowdebug/lib, /usr/lib/jvm/java-25-openjdk, /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor/32x32/apps, /usr/lib/jvm/java-25-openjdk/lib, /usr/share/icons/hicolor/16x16, /usr/lib/jvm/java-25-openjdk/lib/static/linux-amd64/glibc/server, /usr/lib/jvm, /usr/lib/jvm/java-25-openjdk-slowdebug, /usr/share/icons/hicolor/24x24/apps, /usr/share/icons/hicolor/16x16/apps [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /etc/.java(java-latest- openjdk-headless-fastdebug, java-21-openjdk-headless, java-latest- openjdk-headless-slowdebug, java-latest-openjdk-headless, java-21-openjdk-headless-slowdebug, java-21-openjdk-headless- fastdebug), /etc/.java/.systemPrefs(java-latest-openjdk-headless- fastdebug, java-21-openjdk-headless, java-latest-openjdk-headless- slowdebug, java-latest-openjdk-headless, java-21-openjdk-headless- slowdebug, java-21-openjdk-headless-fastdebug), /usr/share/systemtap(java-latest-openjdk-devel-slowdebug, systemtap- client, perl-devel, java-21-openjdk-devel-fastdebug, systemtap-devel, java-21-openjdk-devel-slowdebug, ruby-libs, sssd-common, java-21-openjdk-devel, java-latest-openjdk-devel, systemtap-jupyter, java-latest-openjdk-devel-fastdebug, systemtap-testsuite, glib2-devel), /usr/share/systemtap/tapset(java-latest-openjdk-devel- slowdebug, systemtap-client, perl-devel, java-21-openjdk-devel- fastdebug, systemtap-devel, java-21-openjdk-devel-slowdebug, pcp, ruby-libs, sssd-common, java-21-openjdk-devel, libvirt-libs, java- latest-openjdk-devel, java-latest-openjdk-devel-fastdebug, glib2-devel), /usr/share/systemtap/tapset/x86_64(java-latest-openjdk- devel-slowdebug, systemtap-client, java-21-openjdk-devel-fastdebug, systemtap-devel, java-21-openjdk-devel-slowdebug, java-21-openjdk- devel, java-latest-openjdk-devel, java-latest-openjdk-devel-fastdebug, glib2-devel) Reviewer note: I assume this one is ok. [x]: %build honors applicable compiler flags or justifies otherwise. [-]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: %config files are marked noreplace or the reason is justified. Note: No (noreplace) in %config /etc/java/java-25-openjdk/java-25-openjdk/conf/management/jmxremote.password.template %config /etc/java/java-25-openjdk/java-25-openjdk/conf/sdp/sdp.conf.template %config /etc/java/java-25-openjdk/java-25-openjdk- slowdebug/conf/management/jmxremote.password.template %config /etc/java/java-25-openjdk/java-25-openjdk- slowdebug/conf/sdp/sdp.conf.template %config /etc/java/java-25-openjdk/java-25-openjdk- fastdebug/conf/management/jmxremote.password.template %config /etc/java/java-25-openjdk/java-25-openjdk- fastdebug/conf/sdp/sdp.conf.template [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 36540 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: javapackages-tools (jpackage-utils) [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [x]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: Old add_to_maven_depmap macro is not being used Perl: [x]: Package contains the mandatory BuildRequires and Requires:. ===== SHOULD items ===== Generic: [x]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in java-25-openjdk-slowdebug , java-25-openjdk-fastdebug , java-25-openjdk-headless , java-25-openjdk-headless-slowdebug , java-25-openjdk-headless-fastdebug , java-25-openjdk-devel , java-25-openjdk-devel-slowdebug , java-25-openjdk-devel-fastdebug , java-25-openjdk-static-libs , java-25-openjdk-static-libs-slowdebug , java-25-openjdk-static-libs-fastdebug , java-25-openjdk-jmods , java-25-openjdk-jmods-slowdebug , java-25-openjdk-jmods-fastdebug , java-25-openjdk-demo , java-25-openjdk-demo-slowdebug , java-25-openjdk-demo-fastdebug , java-25-openjdk-src , java-25-openjdk-src-slowdebug , java-25-openjdk-src-fastdebug , java-25-openjdk-javadoc-zip [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments Reviewer note: IcedTea [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. Reviewer note: generated sources [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define debug_package %{nil}, %define __brp_strip_static_archive %{nil}, %define is_release_build() %( if [ "%{?1}" == "%{debug_suffix_unquoted}" -o "%{?1}" == "%{fastdebug_suffix_unquoted}" ]; then echo "0" ; else echo "1"; fi ), %define fullversion() %{expand:%{compatiblename}%{?1}-%{version}-%{release}}, %define uniquejavadocdir() %{expand:%{compatiblename}%{?1}}, %define uniquesuffix() %{expand:%{compatiblename}%{?1}}, %define etcjavadir() %{expand:%{etcjavasubdir}/%{uniquesuffix -- %{?1}}}, %define sdkdir() %{expand:%{uniquesuffix -- %{?1}}}, %define sdkbindir() %{expand:%{_jvmdir}/%{sdkdir -- %{?1}}/bin}, %define jrebindir() %{expand:%{_jvmdir}/%{sdkdir -- %{?1}}/bin}, %define post_script() %{expand:, %define priority_for() %{expand:%[%{?1:1}%{!?1:0} ? %{priority} - 1 : %{priority}]}, %define alternatives_java_install() %{expand:, %define post_headless() %{expand:, %define postun_script() %{expand:, %define preun_headless() %{expand:, %define posttrans_script() %{expand:, %define alternatives_javac_install() %{expand:, %define post_devel() %{expand:, %define preun_devel() %{expand:, %define postun_devel() %{expand:, %define posttrans_devel() %{expand:, %define alternatives_javadoc_install() %{expand:, %define preun_javadoc() %{expand:, %define alternatives_javadoczip_install() %{expand:, %define preun_javadoc_zip() %{expand:, %define files_jre() %{expand:, %define files_jre_headless() %{expand:, %define files_devel() %{expand:, %define files_jmods() %{expand:, %define files_demo() %{expand:, %define files_src() %{expand:, %define files_static_libs() %{expand:, %define files_javadoc() %{expand:, %define files_javadoc_zip() %{expand:, %define java_rpo() %{expand:, %define java_headless_rpo() %{expand:, %define java_devel_rpo() %{expand:, %define java_static_libs_rpo() %{expand:, %define java_jmods_rpo() %{expand:, %define java_demo_rpo() %{expand:, %define java_javadoc_rpo() %{expand:, %define java_src_rpo() %{expand:, %define lua_delete_old_link() %{expand: Reviewer note: ## FIXME FIXME FIXME %define debug_package %{nil} ## FIXME FIXME FIXME the above looks wrong, but is promised to be looked at later. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. Java: [x]: Packages are noarch unless they use JNI Note: java-25-openjdk subpackage is not noarch. Please verify manually Reviewer note: uses JNI [x]: Package uses upstream build method (ant/maven/etc.) ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 734238720 bytes in /usr/share java-25-openjdk-javadoc-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm:337930240, java-25-openjdk-javadoc- zip-25.0.0.0.13-0.1.ea.fc43.x86_64.rpm:395110400 See: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [x]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment).
The Pagure repository was created at https://src.fedoraproject.org/rpms/java-25-openjdk
https://koji.fedoraproject.org/koji/taskinfo?taskID=130773374