Spec URL: https://dcavalca.fedorapeople.org/review/rust-zenity-dialog/rust-zenity-dialog.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-zenity-dialog/rust-zenity-dialog-0.3.6-1.fc43.src.rpm Description: Provides a statically typed wrapper around the Zenity dialog rendering tool for Linux. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=130467154
Copr build: https://copr.fedorainfracloud.org/coprs/build/8791490 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2353299-rust-zenity-dialog/fedora-rawhide-x86_64/08791490-rust-zenity-dialog/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Two comments: - The "doctests" are broken indeed, but they're not *really* doctests ... not sure how upstream doesn't notice that running "cargo test" fails, but the code snippet that's broken is actually the one from the README.md that's include_str!d as a docstring. - Thanks for filing a PR to include license files upstream - let's see if upstream reacts in a timely fashion. If not, it's probably acceptable to say "these are the standardized Apache-2.0 and MIT license texts, this is the best we can do here".
No response from upstream so far unfortunately :(
Since the Apache-2.0 and MIT license texts associated with the SPDX identifiers of the same names are well-defined, I think this should be OK. Hopefully upstream wakes up at some point, so this won't be necessary for all time. === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide 🫤 test suite is run and all unit tests pass (there are no tests) ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora 🫤 license files are included with %license in %files (standard MIT / Apache-2.0 texts included manually, PR submitted upstream to add them) ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-zenity-dialog
FEDORA-2025-a0e8c68399 (rust-zenity-dialog-0.3.6-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-a0e8c68399
FEDORA-2025-a0e8c68399 (rust-zenity-dialog-0.3.6-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-e96ed3712d (rust-zenity-dialog-0.3.6-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-e96ed3712d
FEDORA-2025-e96ed3712d (rust-zenity-dialog-0.3.6-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.