Bug 2353415 - Review Request: libstroke - A stroke interface library
Summary: Review Request: libstroke - A stroke interface library
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL: http://www.etla.net/
Whiteboard:
Depends On:
Blocks: 2353363
TreeView+ depends on / blocked
 
Reported: 2025-03-19 18:51 UTC by Steve
Modified: 2025-03-25 16:10 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Steve 2025-03-19 18:51:20 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/s-kro/libstroke/fedora-rawhide-x86_64/08818638-libstroke/libstroke.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/s-kro/libstroke/fedora-rawhide-x86_64/08818638-libstroke/libstroke-0.5.1-49.fc43.src.rpm
Description: LibStroke is a stroke interface library.  Strokes are motions of the mouse that can be interpreted by a program as a command.
Fedora Account System Username: s-kro

Comment 1 Fedora Review Service 2025-03-19 18:59:33 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8795016
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2353415-libstroke/fedora-rawhide-x86_64/08795016-libstroke/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/libstroke
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Artur Frenszek-Iwicki 2025-03-24 18:53:33 UTC
> Obsoletes:         libgstroke < %{version}-%{release}
> Provides:          libgstroke = %{version}-%{release}
> Obsoletes:         libgstroke-devel < %{version}-%{release}
> Provides:          libgstroke-devel = %{version}-%{release}
The provides should be archful, i.e. "Provides: libgstroke%{?_isa}".

> %package doc
> Summary:           Documentation files for the  %{name} library
Remove the double space before "%{name}".

> %package devel
> Summary:           Development files for the libstroke library
This seems a bit inconsistent. ;)

> %package -n javastroke
> Summary:           Optional java files
> Requires:          %{name}%{?_isa} = %{version}-%{release}
> Buildarch: noarch
Since this is a noarch package, the requirement should be arch-less.
Otherwise you'll end up with the noarch package requiring whichever architecture the package builder used.
Same issue on the -doc subpackage.

Comment 3 Steve 2025-03-25 13:36:49 UTC
Thanks, Artur

Changes made, however I now get the following, so I just want to make sure I made the correct edit.

[ ]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     javastroke

Also, do the obsoletes need to be archful?

Comment 4 Steve 2025-03-25 13:39:13 UTC
fedora-review-service-build]

Comment 5 Steve 2025-03-25 14:16:35 UTC
fedora-review-service-build

Comment 6 Steve 2025-03-25 15:50:07 UTC
Grrrrrr.....

Comment 8 Steve 2025-03-25 16:02:41 UTC
[fedora-review-service-build]

Comment 9 Fedora Review Service 2025-03-25 16:05:18 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8819293
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2353415-libstroke/fedora-rawhide-x86_64/08819293-libstroke/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/libstroke
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 10 Fedora Review Service 2025-03-25 16:10:03 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8819317
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2353415-libstroke/fedora-rawhide-x86_64/08819317-libstroke/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/libstroke
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


Note You need to log in before you can comment on or make changes to this bug.