Spec URL: https://dcavalca.fedorapeople.org/review/rust-base2048/rust-base2048.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-base2048/rust-base2048-2.0.2-1.fc43.src.rpm Description: Base2048 encoding for efficient encoding of binary data on twitter. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=130509294
Copr build: https://copr.fedorainfracloud.org/coprs/build/8796414 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2353501-rust-base2048/fedora-rawhide-x86_64/08796414-rust-base2048/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
$ cat rust2rpm.toml [features] hide = ["nightly"] [scripts] prep.pre = [ # Remove spurious executable bit "chmod -x src/lib.rs", ]
Some minor issues: - The built -devel package has a dependency on /usr/bin/raku due to gen_tables.raku, please exclude that file from the built package. - The base2048.txt file doesn't look like documentation - prevent it from being marked as %doc. Both should be possible to handle with rust2rpm settings, i.e. [package] doc-files.exclude = ["base2048.txt"] exclude-crate-files = ["gen_tables.raku"]
> ERROR: Invalid rust2rpm.toml file (invalid setting at '.features'): > ERROR: Additional properties are not allowed ('doc-files', 'exclude-crate-files' > were unexpected) Looks like these aren't in rust2rpm-27.0.1-2.fc42 yet
Oh nevermind, I can't read.
Spec URL: https://dcavalca.fedorapeople.org/review/rust-base2048/rust-base2048.spec SRPM URL: https://dcavalca.fedorapeople.org/review/rust-base2048/rust-base2048-2.0.2-1.fc43.src.rpm Changelog: - exclude gen_tables.raku - exclude base2048.txt from docs
$ cat rust2rpm.toml [package] doc-files.exclude = ["base2048.txt"] exclude-crate-files = ["gen_tables.raku"] [features] hide = ["nightly"] [scripts] prep.pre = [ # Remove spurious executable bit "chmod -x src/lib.rs", ]
Created attachment 2081974 [details] The .spec file difference from Copr build 8796414 to 8819393
Copr build: https://copr.fedorainfracloud.org/coprs/build/8819393 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2353501-rust-base2048/fedora-rawhide-x86_64/08819393-rust-base2048/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-base2048
FEDORA-2025-f3fc01efe7 (rust-base2048-2.0.2-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-f3fc01efe7
FEDORA-2025-f3fc01efe7 (rust-base2048-2.0.2-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.