Bug 2353504 - Review Request: rust-revision - Serialization and deserialization implementation
Summary: Review Request: rust-revision - Serialization and deserialization implementation
Keywords:
Status: POST
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/revision
Whiteboard:
Depends On: 2353503
Blocks:
TreeView+ depends on / blocked
 
Reported: 2025-03-20 05:03 UTC by Davide Cavalca
Modified: 2025-03-31 16:33 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2025-03-20 05:03:04 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-revision/rust-revision.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-revision/rust-revision-0.11.0-1.fc43.src.rpm

Description:
A serialization and deserialization implementation which allows for
schema-evolution.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2025-03-20 05:03:25 UTC
$ cat rust2rpm.toml 
[package]
summary = "Serialization and deserialization implementation"
cargo-toml-patch-comments = ["Drop unnecessary criterion dependency"]

[features]
hide = [
  # Missing dependencies
  "geo",
  "roaring",
]

[scripts]
prep.pre = [
  # Remove spurious executable bits
  "chmod -x LICENSE README.md src/lib.rs tests/test.rs"
]

Comment 2 Fedora Review Service 2025-03-20 05:05:04 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8796428
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2353504-rust-revision/fedora-rawhide-x86_64/08796428-rust-revision/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fabio Valentini 2025-03-31 16:33:37 UTC
Package looks good to me. Please file an upstream PR for dropping the executable bit from non-executable source files.

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)


Note You need to log in before you can comment on or make changes to this bug.